Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1236964 > unrolled thread
| Started by | Vaishali Thakkar <vthakkar1994@gmail.com> |
|---|---|
| First post | 2015-10-01 07:00 +0200 |
| Last post | 2015-10-01 10:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-10-01 07:00 +0200
Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE Ingo Molnar <mingo@kernel.org> - 2015-10-01 10:10 +0200
Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-10-01 10:30 +0200
Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE Ingo Molnar <mingo@kernel.org> - 2015-10-01 10:30 +0200
Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE Vaishali Thakkar <vthakkar1994@gmail.com> - 2015-10-01 10:40 +0200
| From | Vaishali Thakkar <vthakkar1994@gmail.com> |
|---|---|
| Date | 2015-10-01 07:00 +0200 |
| Subject | Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE |
| Message-ID | <qeE8h-1P6-1@gated-at.bofh.it> |
Ping!
On Fri, Jul 17, 2015 at 10:57 AM, Vaishali Thakkar
<vthakkar1994@gmail.com> wrote:
> Macro DEFINE_PCI_DEVICE_TABLE is deprecated. So, here use
> struct pci_device_id instead of DEFINE_PCI_DEVICE_TABLE with
> the goal of getting rid of this macro completely.
>
> The Coccinelle semantic patch that performs this transformation
> is as follows:
>
> @@
> identifier a;
> declarer name DEFINE_PCI_DEVICE_TABLE;
> initializer i;
> @@
> - DEFINE_PCI_DEVICE_TABLE(a)
> + const struct pci_device_id a[]
> = i;
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c b/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
> index 6d6e85d..76a3feb 100644
> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore_snbep.c
> @@ -2215,7 +2215,7 @@ static struct intel_uncore_type *hswep_pci_uncores[] = {
> NULL,
> };
>
> -static DEFINE_PCI_DEVICE_TABLE(hswep_uncore_pci_ids) = {
> +static const struct pci_device_id hswep_uncore_pci_ids[] = {
> { /* Home Agent 0 */
> PCI_DEVICE(PCI_VENDOR_ID_INTEL, 0x2f30),
> .driver_data = UNCORE_PCI_DEV_DATA(HSWEP_PCI_UNCORE_HA, 0),
> --
> 1.9.1
>
--
Vaishali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2015-10-01 10:10 +0200 |
| Subject | Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE |
| Message-ID | <qeH6a-6r6-7@gated-at.bofh.it> |
| In reply to | #1236964 |
* Vaishali Thakkar <vthakkar1994@gmail.com> wrote: > Ping! Pong. This patch is already upstream. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaishali Thakkar <vthakkar1994@gmail.com> |
|---|---|
| Date | 2015-10-01 10:30 +0200 |
| Message-ID | <qeHpw-6S6-9@gated-at.bofh.it> |
| In reply to | #1237109 |
On Thu, Oct 1, 2015 at 1:37 PM, Ingo Molnar <mingo@kernel.org> wrote: > > * Vaishali Thakkar <vthakkar1994@gmail.com> wrote: > >> Ping! > > Pong. This patch is already upstream. Oops! Sorry. I just realized that you already applied it but it is still showing me in linux-next when grepped for it and is blocking the road in removing the macro definition. Sorry for the noise. > Thanks, > > Ingo -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Date | 2015-10-01 10:30 +0200 |
| Subject | Re: [PATCH] perf/x86/intel/uncore: Remove use of macro DEFINE_PCI_DEVICE_TABLE |
| Message-ID | <qeHpw-6S6-11@gated-at.bofh.it> |
| In reply to | #1237122 |
* Vaishali Thakkar <vthakkar1994@gmail.com> wrote: > On Thu, Oct 1, 2015 at 1:37 PM, Ingo Molnar <mingo@kernel.org> wrote: > > > > * Vaishali Thakkar <vthakkar1994@gmail.com> wrote: > > > >> Ping! > > > > Pong. This patch is already upstream. > > Oops! Sorry. I just realized that you already applied it but it is > still showing me in linux-next > when grepped for it and is blocking the road in removing the macro definition. So I think what you saw in linux-next is another usage of the old macro, in the same file - which usage arrived since you did the first patch. > > Sorry for the noise. np. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Vaishali Thakkar <vthakkar1994@gmail.com> |
|---|---|
| Date | 2015-10-01 10:40 +0200 |
| Message-ID | <qeHzc-76i-13@gated-at.bofh.it> |
| In reply to | #1237123 |
On Thu, Oct 1, 2015 at 1:55 PM, Ingo Molnar <mingo@kernel.org> wrote: > > * Vaishali Thakkar <vthakkar1994@gmail.com> wrote: > >> On Thu, Oct 1, 2015 at 1:37 PM, Ingo Molnar <mingo@kernel.org> wrote: >> > >> > * Vaishali Thakkar <vthakkar1994@gmail.com> wrote: >> > >> >> Ping! >> > >> > Pong. This patch is already upstream. >> >> Oops! Sorry. I just realized that you already applied it but it is >> still showing me in linux-next >> when grepped for it and is blocking the road in removing the macro definition. > > So I think what you saw in linux-next is another usage of the old macro, in the > same file - which usage arrived since you did the first patch. Ah, yes. That's why I was confused. Thanks. Let me send a patch for that. >> >> Sorry for the noise. > > np. > > Thanks, > > Ingo -- Vaishali -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web