Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1235388 > unrolled thread
| Started by | Tejun Heo <tj@kernel.org> |
|---|---|
| First post | 2015-09-29 18:50 +0200 |
| Last post | 2015-10-02 16:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/5] writeback: laptop_mode_timer_fn() needs rcu_read_lock() around bdi_writeback iteration Tejun Heo <tj@kernel.org> - 2015-09-29 18:50 +0200
Re: [PATCH 1/5] writeback: laptop_mode_timer_fn() needs rcu_read_lock() around bdi_writeback iteration Jan Kara <jack@suse.cz> - 2015-10-02 16:20 +0200
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Date | 2015-09-29 18:50 +0200 |
| Subject | [PATCH 1/5] writeback: laptop_mode_timer_fn() needs rcu_read_lock() around bdi_writeback iteration |
| Message-ID | <qe6gi-3Gy-17@gated-at.bofh.it> |
laptop_mode_timer_fn() was using bdi_for_each_wb() without the
required RCU locking leading to the following warning.
WARNING: CPU: 0 PID: 0 at include/linux/backing-dev.h:415 laptop_mode_timer_fn+0x106/0x170()
...
Call Trace:
<IRQ> [<ffffffff81480cdc>] dump_stack+0x4e/0x82
[<ffffffff81051912>] warn_slowpath_common+0x82/0xc0
[<ffffffff81051a0a>] warn_slowpath_null+0x1a/0x20
[<ffffffff8115f0e6>] laptop_mode_timer_fn+0x106/0x170
[<ffffffff810ca8e3>] call_timer_fn+0xb3/0x2f0
[<ffffffff810cad25>] run_timer_softirq+0x205/0x370
[<ffffffff81056854>] __do_softirq+0xd4/0x460
[<ffffffff81056d69>] irq_exit+0x89/0xa0
[<ffffffff8185a892>] smp_apic_timer_interrupt+0x42/0x50
[<ffffffff81858a44>] apic_timer_interrupt+0x84/0x90
...
Fix it by adding rcu_read_lock() around the iteration.
Signed-off-by: Tejun Heo <tj@kernel.org>
Fixes: a06fd6b10228 ("writeback: make laptop_mode_timer_fn() handle multiple bdi_writeback's")
---
mm/page-writeback.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index 0a931cd..902e5f2 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -1965,10 +1965,12 @@ void laptop_mode_timer_fn(unsigned long data)
if (!bdi_has_dirty_io(&q->backing_dev_info))
return;
+ rcu_read_lock();
bdi_for_each_wb(wb, &q->backing_dev_info, &iter, 0)
if (wb_has_dirty_io(wb))
wb_start_writeback(wb, nr_pages, true,
WB_REASON_LAPTOP_TIMER);
+ rcu_read_unlock();
}
/*
--
2.4.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Jan Kara <jack@suse.cz> |
|---|---|
| Date | 2015-10-02 16:20 +0200 |
| Subject | Re: [PATCH 1/5] writeback: laptop_mode_timer_fn() needs rcu_read_lock() around bdi_writeback iteration |
| Message-ID | <qf9lM-5Mt-11@gated-at.bofh.it> |
| In reply to | #1235388 |
On Tue 29-09-15 12:47:50, Tejun Heo wrote:
> laptop_mode_timer_fn() was using bdi_for_each_wb() without the
> required RCU locking leading to the following warning.
>
> WARNING: CPU: 0 PID: 0 at include/linux/backing-dev.h:415 laptop_mode_timer_fn+0x106/0x170()
> ...
> Call Trace:
> <IRQ> [<ffffffff81480cdc>] dump_stack+0x4e/0x82
> [<ffffffff81051912>] warn_slowpath_common+0x82/0xc0
> [<ffffffff81051a0a>] warn_slowpath_null+0x1a/0x20
> [<ffffffff8115f0e6>] laptop_mode_timer_fn+0x106/0x170
> [<ffffffff810ca8e3>] call_timer_fn+0xb3/0x2f0
> [<ffffffff810cad25>] run_timer_softirq+0x205/0x370
> [<ffffffff81056854>] __do_softirq+0xd4/0x460
> [<ffffffff81056d69>] irq_exit+0x89/0xa0
> [<ffffffff8185a892>] smp_apic_timer_interrupt+0x42/0x50
> [<ffffffff81858a44>] apic_timer_interrupt+0x84/0x90
> ...
>
> Fix it by adding rcu_read_lock() around the iteration.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Fixes: a06fd6b10228 ("writeback: make laptop_mode_timer_fn() handle multiple bdi_writeback's")
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.com>
Honza
> ---
> mm/page-writeback.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 0a931cd..902e5f2 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -1965,10 +1965,12 @@ void laptop_mode_timer_fn(unsigned long data)
> if (!bdi_has_dirty_io(&q->backing_dev_info))
> return;
>
> + rcu_read_lock();
> bdi_for_each_wb(wb, &q->backing_dev_info, &iter, 0)
> if (wb_has_dirty_io(wb))
> wb_start_writeback(wb, nr_pages, true,
> WB_REASON_LAPTOP_TIMER);
> + rcu_read_unlock();
> }
>
> /*
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web