Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233375 > unrolled thread

[PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-26 23:20 +0200
    Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling  gesture mode Josh Boyer <jwboyer@fedoraproject.org> - 2015-09-29 14:30 +0200
      Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling  gesture mode Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-29 15:20 +0200
        Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling  gesture mode Josh Boyer <jwboyer@fedoraproject.org> - 2015-09-29 15:40 +0200
          Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling  gesture mode Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-09-29 15:50 +0200
            Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-09-29 16:00 +0200

#1233375 — [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

4.1-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>

commit e51e38494a8ecc18650efb0c840600637891de2c upstream.

Bit 2 of the mode byte has dual meaning: it can disable reporting of
gestures when touchpad works in Relative mode or normal Absolute mode,
or it can enable so called Extended W-Mode when touchpad uses enhanced
Absolute mode (W-mode). The extended W-Mode confuses our driver and
causes missing button presses on some Thinkpads (x250, T450s), so let's
make sure we do not enable it.

Also, according to the spec W mode "... bit is defined only in Absolute
mode on pads whose capExtended capability bit is set. In Relative mode and
in TouchPads without this capability, the bit is reserved and should be
left at 0.", so let's make sure we respect this requirement as well.

Reported-by: Nick Bowler <nbowler@draconx.ca>
Suggested-by: Gabor Balla <gaborwho@gmail.com>
Tested-by: Gabor Balla <gaborwho@gmail.com>
Tested-by: Nick Bowler <nbowler@draconx.ca>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/input/mouse/synaptics.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

--- a/drivers/input/mouse/synaptics.c
+++ b/drivers/input/mouse/synaptics.c
@@ -519,14 +519,18 @@ static int synaptics_set_mode(struct psm
 	struct synaptics_data *priv = psmouse->private;
 
 	priv->mode = 0;
-	if (priv->absolute_mode)
+
+	if (priv->absolute_mode) {
 		priv->mode |= SYN_BIT_ABSOLUTE_MODE;
-	if (priv->disable_gesture)
+		if (SYN_CAP_EXTENDED(priv->capabilities))
+			priv->mode |= SYN_BIT_W_MODE;
+	}
+
+	if (!SYN_MODE_WMODE(priv->mode) && priv->disable_gesture)
 		priv->mode |= SYN_BIT_DISABLE_GESTURE;
+
 	if (psmouse->rate >= 80)
 		priv->mode |= SYN_BIT_HIGH_RATE;
-	if (SYN_CAP_EXTENDED(priv->capabilities))
-		priv->mode |= SYN_BIT_W_MODE;
 
 	if (synaptics_mode_cmd(psmouse, priv->mode))
 		return -1;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1235015 — Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

On Sat, Sep 26, 2015 at 4:54 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> 4.1-stable review patch.  If anyone has any objections, please let me know.
>
> ------------------
>
> From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> commit e51e38494a8ecc18650efb0c840600637891de2c upstream.
>
> Bit 2 of the mode byte has dual meaning: it can disable reporting of
> gestures when touchpad works in Relative mode or normal Absolute mode,
> or it can enable so called Extended W-Mode when touchpad uses enhanced
> Absolute mode (W-mode). The extended W-Mode confuses our driver and
> causes missing button presses on some Thinkpads (x250, T450s), so let's
> make sure we do not enable it.
>
> Also, according to the spec W mode "... bit is defined only in Absolute
> mode on pads whose capExtended capability bit is set. In Relative mode and
> in TouchPads without this capability, the bit is reserved and should be
> left at 0.", so let's make sure we respect this requirement as well.
>
> Reported-by: Nick Bowler <nbowler@draconx.ca>
> Suggested-by: Gabor Balla <gaborwho@gmail.com>
> Tested-by: Gabor Balla <gaborwho@gmail.com>
> Tested-by: Nick Bowler <nbowler@draconx.ca>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I believe Dmitry is going to revert this commit very shortly.  See

http://www.spinics.net/lists/linux-input/msg41176.html

You might want to leave this one out of both 4.2.y and 4.1.1y.

josh

> ---
>  drivers/input/mouse/synaptics.c |   12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
>
> --- a/drivers/input/mouse/synaptics.c
> +++ b/drivers/input/mouse/synaptics.c
> @@ -519,14 +519,18 @@ static int synaptics_set_mode(struct psm
>         struct synaptics_data *priv = psmouse->private;
>
>         priv->mode = 0;
> -       if (priv->absolute_mode)
> +
> +       if (priv->absolute_mode) {
>                 priv->mode |= SYN_BIT_ABSOLUTE_MODE;
> -       if (priv->disable_gesture)
> +               if (SYN_CAP_EXTENDED(priv->capabilities))
> +                       priv->mode |= SYN_BIT_W_MODE;
> +       }
> +
> +       if (!SYN_MODE_WMODE(priv->mode) && priv->disable_gesture)
>                 priv->mode |= SYN_BIT_DISABLE_GESTURE;
> +
>         if (psmouse->rate >= 80)
>                 priv->mode |= SYN_BIT_HIGH_RATE;
> -       if (SYN_CAP_EXTENDED(priv->capabilities))
> -               priv->mode |= SYN_BIT_W_MODE;
>
>         if (synaptics_mode_cmd(psmouse, priv->mode))
>                 return -1;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1235046 — Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

On Tue, Sep 29, 2015 at 08:27:14AM -0400, Josh Boyer wrote:
> On Sat, Sep 26, 2015 at 4:54 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > 4.1-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >
> > commit e51e38494a8ecc18650efb0c840600637891de2c upstream.
> >
> > Bit 2 of the mode byte has dual meaning: it can disable reporting of
> > gestures when touchpad works in Relative mode or normal Absolute mode,
> > or it can enable so called Extended W-Mode when touchpad uses enhanced
> > Absolute mode (W-mode). The extended W-Mode confuses our driver and
> > causes missing button presses on some Thinkpads (x250, T450s), so let's
> > make sure we do not enable it.
> >
> > Also, according to the spec W mode "... bit is defined only in Absolute
> > mode on pads whose capExtended capability bit is set. In Relative mode and
> > in TouchPads without this capability, the bit is reserved and should be
> > left at 0.", so let's make sure we respect this requirement as well.
> >
> > Reported-by: Nick Bowler <nbowler@draconx.ca>
> > Suggested-by: Gabor Balla <gaborwho@gmail.com>
> > Tested-by: Gabor Balla <gaborwho@gmail.com>
> > Tested-by: Nick Bowler <nbowler@draconx.ca>
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I believe Dmitry is going to revert this commit very shortly.  See
> 
> http://www.spinics.net/lists/linux-input/msg41176.html
> 
> You might want to leave this one out of both 4.2.y and 4.1.1y.

I prefer to wait for stuff like this to hit Linus's tree to keep in
sync, bugs at all at times.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1235060 — Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

On Tue, Sep 29, 2015 at 8:53 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Sep 29, 2015 at 08:27:14AM -0400, Josh Boyer wrote:
>> On Sat, Sep 26, 2015 at 4:54 PM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > 4.1-stable review patch.  If anyone has any objections, please let me know.
>> >
>> > ------------------
>> >
>> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> >
>> > commit e51e38494a8ecc18650efb0c840600637891de2c upstream.
>> >
>> > Bit 2 of the mode byte has dual meaning: it can disable reporting of
>> > gestures when touchpad works in Relative mode or normal Absolute mode,
>> > or it can enable so called Extended W-Mode when touchpad uses enhanced
>> > Absolute mode (W-mode). The extended W-Mode confuses our driver and
>> > causes missing button presses on some Thinkpads (x250, T450s), so let's
>> > make sure we do not enable it.
>> >
>> > Also, according to the spec W mode "... bit is defined only in Absolute
>> > mode on pads whose capExtended capability bit is set. In Relative mode and
>> > in TouchPads without this capability, the bit is reserved and should be
>> > left at 0.", so let's make sure we respect this requirement as well.
>> >
>> > Reported-by: Nick Bowler <nbowler@draconx.ca>
>> > Suggested-by: Gabor Balla <gaborwho@gmail.com>
>> > Tested-by: Gabor Balla <gaborwho@gmail.com>
>> > Tested-by: Nick Bowler <nbowler@draconx.ca>
>> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>>
>> I believe Dmitry is going to revert this commit very shortly.  See
>>
>> http://www.spinics.net/lists/linux-input/msg41176.html
>>
>> You might want to leave this one out of both 4.2.y and 4.1.1y.
>
> I prefer to wait for stuff like this to hit Linus's tree to keep in
> sync, bugs at all at times.

Wait, what?  You're going to release a stable kernel with a patch that
is known to be buggy just to keep it in sync with a buggy upstream
Linus tree?  That doesn't make sense to me.  I would maybe understand
if the upstream solution wasn't "revert this" and instead had a follow
on patch, but knowing upstream is going to revert and still including
it is confusing.

At any rate, distros may wish to queue up the revert on top of 4.1.9 and 4.2.2.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1235072 — Re: [PATCH 4.1 026/159] Input: synaptics - fix handling of disabling gesture mode

On Tue, Sep 29, 2015 at 09:36:15AM -0400, Josh Boyer wrote:
> On Tue, Sep 29, 2015 at 8:53 AM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Tue, Sep 29, 2015 at 08:27:14AM -0400, Josh Boyer wrote:
> >> On Sat, Sep 26, 2015 at 4:54 PM, Greg Kroah-Hartman
> >> <gregkh@linuxfoundation.org> wrote:
> >> > 4.1-stable review patch.  If anyone has any objections, please let me know.
> >> >
> >> > ------------------
> >> >
> >> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >> >
> >> > commit e51e38494a8ecc18650efb0c840600637891de2c upstream.
> >> >
> >> > Bit 2 of the mode byte has dual meaning: it can disable reporting of
> >> > gestures when touchpad works in Relative mode or normal Absolute mode,
> >> > or it can enable so called Extended W-Mode when touchpad uses enhanced
> >> > Absolute mode (W-mode). The extended W-Mode confuses our driver and
> >> > causes missing button presses on some Thinkpads (x250, T450s), so let's
> >> > make sure we do not enable it.
> >> >
> >> > Also, according to the spec W mode "... bit is defined only in Absolute
> >> > mode on pads whose capExtended capability bit is set. In Relative mode and
> >> > in TouchPads without this capability, the bit is reserved and should be
> >> > left at 0.", so let's make sure we respect this requirement as well.
> >> >
> >> > Reported-by: Nick Bowler <nbowler@draconx.ca>
> >> > Suggested-by: Gabor Balla <gaborwho@gmail.com>
> >> > Tested-by: Gabor Balla <gaborwho@gmail.com>
> >> > Tested-by: Nick Bowler <nbowler@draconx.ca>
> >> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>
> >> I believe Dmitry is going to revert this commit very shortly.  See
> >>
> >> http://www.spinics.net/lists/linux-input/msg41176.html
> >>
> >> You might want to leave this one out of both 4.2.y and 4.1.1y.
> >
> > I prefer to wait for stuff like this to hit Linus's tree to keep in
> > sync, bugs at all at times.
> 
> Wait, what?  You're going to release a stable kernel with a patch that
> is known to be buggy just to keep it in sync with a buggy upstream
> Linus tree?  That doesn't make sense to me.  I would maybe understand
> if the upstream solution wasn't "revert this" and instead had a follow
> on patch, but knowing upstream is going to revert and still including
> it is confusing.

We do this all the time, as the patch usually takes a while to get
reverted in Linus's tree, and there doesn't seem to be any "rush" at the
moment to get it reverted, I usually just leave things as-is if for no
other reason than to wake the maintainer up :)

Unless the maintainer asks me not to include it, then I'll reconsider,
otherwise I have to trust that a random person says that the patch will
be reverted some unknown time in the future by some other person, and
that's nothing I can really count on.

Again, keeping the trees in sync, even for bugs, makes things easier
overall.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1235115

On September 29, 2015 6:44:52 AM PDT, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>On Tue, Sep 29, 2015 at 09:36:15AM -0400, Josh Boyer wrote:
>> On Tue, Sep 29, 2015 at 8:53 AM, Greg Kroah-Hartman
>> <gregkh@linuxfoundation.org> wrote:
>> > On Tue, Sep 29, 2015 at 08:27:14AM -0400, Josh Boyer wrote:
>> >> On Sat, Sep 26, 2015 at 4:54 PM, Greg Kroah-Hartman
>> >> <gregkh@linuxfoundation.org> wrote:
>> >> > 4.1-stable review patch.  If anyone has any objections, please
>let me know.
>> >> >
>> >> > ------------------
>> >> >
>> >> > From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> >> >
>> >> > commit e51e38494a8ecc18650efb0c840600637891de2c upstream.
>> >> >
>> >> > Bit 2 of the mode byte has dual meaning: it can disable
>reporting of
>> >> > gestures when touchpad works in Relative mode or normal Absolute
>mode,
>> >> > or it can enable so called Extended W-Mode when touchpad uses
>enhanced
>> >> > Absolute mode (W-mode). The extended W-Mode confuses our driver
>and
>> >> > causes missing button presses on some Thinkpads (x250, T450s),
>so let's
>> >> > make sure we do not enable it.
>> >> >
>> >> > Also, according to the spec W mode "... bit is defined only in
>Absolute
>> >> > mode on pads whose capExtended capability bit is set. In
>Relative mode and
>> >> > in TouchPads without this capability, the bit is reserved and
>should be
>> >> > left at 0.", so let's make sure we respect this requirement as
>well.
>> >> >
>> >> > Reported-by: Nick Bowler <nbowler@draconx.ca>
>> >> > Suggested-by: Gabor Balla <gaborwho@gmail.com>
>> >> > Tested-by: Gabor Balla <gaborwho@gmail.com>
>> >> > Tested-by: Nick Bowler <nbowler@draconx.ca>
>> >> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>> >> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> >>
>> >> I believe Dmitry is going to revert this commit very shortly.  See
>> >>
>> >> http://www.spinics.net/lists/linux-input/msg41176.html
>> >>
>> >> You might want to leave this one out of both 4.2.y and 4.1.1y.
>> >
>> > I prefer to wait for stuff like this to hit Linus's tree to keep in
>> > sync, bugs at all at times.
>> 
>> Wait, what?  You're going to release a stable kernel with a patch
>that
>> is known to be buggy just to keep it in sync with a buggy upstream
>> Linus tree?  That doesn't make sense to me.  I would maybe understand
>> if the upstream solution wasn't "revert this" and instead had a
>follow
>> on patch, but knowing upstream is going to revert and still including
>> it is confusing.
>
>We do this all the time, as the patch usually takes a while to get
>reverted in Linus's tree, and there doesn't seem to be any "rush" at
>the
>moment to get it reverted, I usually just leave things as-is if for no
>other reason than to wake the maintainer up :)
>
>Unless the maintainer asks me not to include it, then I'll reconsider,
>otherwise I have to trust that a random person says that the patch will
>be reverted some unknown time in the future by some other person, and
>that's nothing I can really count on.
>
>Again, keeping the trees in sync, even for bugs, makes things easier
>overall.

Greg,

I'd rather we did not merge this path into stable just yet. I'm not sure if I'll revert it outright or if there will be a fixup, but as is it messes up touchpad behavior for many people :(


Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web