Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234774 > unrolled thread
| Started by | Baoquan He <bhe@redhat.com> |
|---|---|
| First post | 2015-09-29 09:30 +0200 |
| Last post | 2015-09-29 17:10 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Baoquan He <bhe@redhat.com> - 2015-09-29 09:30 +0200
Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Joerg Roedel <joro@8bytes.org> - 2015-09-29 16:00 +0200
Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found Baoquan He <bhe@redhat.com> - 2015-09-29 17:10 +0200
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2015-09-29 09:30 +0200 |
| Subject | [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found |
| Message-ID | <qdXwl-878-11@gated-at.bofh.it> |
No need to continue the loop after it has been found.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
drivers/iommu/intel_irq_remapping.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index 9ec4e0d..37b93f5 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope,
if (ir_ioapic[count].iommu == iommu &&
ir_ioapic[count].id == scope->enumeration_id)
return 0;
- else if (ir_ioapic[count].iommu == NULL && free == -1)
+ else if (ir_ioapic[count].iommu == NULL && free == -1) {
free = count;
+ break;
+ }
}
if (free == -1) {
pr_warn("Exceeded Max IO APICS\n");
--
2.1.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Joerg Roedel <joro@8bytes.org> |
|---|---|
| Date | 2015-09-29 16:00 +0200 |
| Subject | Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found |
| Message-ID | <qe3BO-8he-57@gated-at.bofh.it> |
| In reply to | #1234774 |
On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote:
> No need to continue the loop after it has been found.
>
> Signed-off-by: Baoquan He <bhe@redhat.com>
> ---
> drivers/iommu/intel_irq_remapping.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 9ec4e0d..37b93f5 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope,
> if (ir_ioapic[count].iommu == iommu &&
> ir_ioapic[count].id == scope->enumeration_id)
> return 0;
> - else if (ir_ioapic[count].iommu == NULL && free == -1)
> + else if (ir_ioapic[count].iommu == NULL && free == -1) {
> free = count;
> + break;
> + }
> }
The purpose of the loop is also to avoid duplicate entries, so we need
to search it till the end, no?
Joerg
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Baoquan He <bhe@redhat.com> |
|---|---|
| Date | 2015-09-29 17:10 +0200 |
| Subject | Re: [PATCH 1/2] iommu/vt-d: break the for loop if an empty ir_ioapic entry found |
| Message-ID | <qe4Hv-1BQ-3@gated-at.bofh.it> |
| In reply to | #1235104 |
On 09/29/15 at 03:50pm, Joerg Roedel wrote:
> On Tue, Sep 29, 2015 at 03:26:08PM +0800, Baoquan He wrote:
> > No need to continue the loop after it has been found.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > drivers/iommu/intel_irq_remapping.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> > index 9ec4e0d..37b93f5 100644
> > --- a/drivers/iommu/intel_irq_remapping.c
> > +++ b/drivers/iommu/intel_irq_remapping.c
> > @@ -841,8 +841,10 @@ static int ir_parse_one_ioapic_scope(struct acpi_dmar_device_scope *scope, > > if (ir_ioapic[count].iommu == iommu &&
> > ir_ioapic[count].id == scope->enumeration_id)
> > return 0;
> > - else if (ir_ioapic[count].iommu == NULL && free == -1)
> > + else if (ir_ioapic[count].iommu == NULL && free == -1) {
> > free = count;
> > + break;
> > + }
> > }
>
> The purpose of the loop is also to avoid duplicate entries, so we need
> to search it till the end, no?
Ah, yes, you are right, it's on purpose. So I will drop this one
and update the 2/2 only with your suggestion.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web