Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1234770 > unrolled thread

[PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir Baoquan He <bhe@redhat.com> - 2015-09-29 09:30 +0200
    Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the  parse_ioapics_under_ir Joerg Roedel <joro@8bytes.org> - 2015-09-29 16:00 +0200

#1234770 — [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir

Adjust the return value of parse_ioapics_under_ir as "-1" representing
failure and "0" representing succcess. Just make it consistent with other
function implementation, and we can judge if calling is successfull by
if (!parse_ioapics_under_ir()) style.

Signed-off-by: Baoquan He <bhe@redhat.com>
---
 drivers/iommu/intel_irq_remapping.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
index 37b93f5..0f441b7 100644
--- a/drivers/iommu/intel_irq_remapping.c
+++ b/drivers/iommu/intel_irq_remapping.c
@@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void)
 	if (!dmar_ir_support())
 		return -ENODEV;
 
-	if (parse_ioapics_under_ir() != 1) {
+	if (!parse_ioapics_under_ir()) {
 		pr_info("Not enabling interrupt remapping\n");
 		goto error;
 	}
@@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void)
 		}
 
 	if (!ir_supported)
-		return 0;
+		return -1;
 
 	for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
 		int ioapic_id = mpc_ioapic_id(ioapic_idx);
@@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void)
 		}
 	}
 
-	return 1;
+	return 0;
 }
 
 static int __init ir_dev_scope_init(void)
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1235108 — Re: [PATCH 2/2] iommu/vt-d: Adjsut the return value of the parse_ioapics_under_ir

On Tue, Sep 29, 2015 at 03:26:09PM +0800, Baoquan He wrote:
> diff --git a/drivers/iommu/intel_irq_remapping.c b/drivers/iommu/intel_irq_remapping.c
> index 37b93f5..0f441b7 100644
> --- a/drivers/iommu/intel_irq_remapping.c
> +++ b/drivers/iommu/intel_irq_remapping.c
> @@ -672,7 +672,7 @@ static int __init intel_prepare_irq_remapping(void)
>  	if (!dmar_ir_support())
>  		return -ENODEV;
>  
> -	if (parse_ioapics_under_ir() != 1) {
> +	if (!parse_ioapics_under_ir()) {
>  		pr_info("Not enabling interrupt remapping\n");
>  		goto error;
>  	}
> @@ -918,7 +918,7 @@ static int __init parse_ioapics_under_ir(void)
>  		}
>  
>  	if (!ir_supported)
> -		return 0;
> +		return -1;
>  
>  	for (ioapic_idx = 0; ioapic_idx < nr_ioapics; ioapic_idx++) {
>  		int ioapic_id = mpc_ioapic_id(ioapic_idx);
> @@ -930,7 +930,7 @@ static int __init parse_ioapics_under_ir(void)
>  		}
>  	}
>  
> -	return 1;
> +	return 0;

Looks good, but -ENODEV is probably a better return value than -1.


	Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web