Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234745 > unrolled thread
| Started by | Martin Kepplinger <martink@posteo.de> |
|---|---|
| First post | 2015-09-29 08:50 +0200 |
| Last post | 2015-10-05 12:40 +0200 |
| Articles | 6 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] platform: acer-wmi: update notice about deprecated user interface Martin Kepplinger <martink@posteo.de> - 2015-09-29 08:50 +0200
Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface joeyli <jlee@suse.com> - 2015-09-29 12:00 +0200
Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface Darren Hart <dvhart@infradead.org> - 2015-10-03 19:30 +0200
Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface Martin Kepplinger <martink@posteo.de> - 2015-10-05 12:40 +0200
Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface joeyli <jlee@suse.com> - 2015-10-05 15:10 +0200
Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface joeyli <jlee@suse.com> - 2015-10-05 12:40 +0200
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2015-09-29 08:50 +0200 |
| Subject | [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qdWTE-792-1@gated-at.bofh.it> |
Signed-off-by: Martin Kepplinger <martink@posteo.de>
---
This just looks odd in the logs. Feel free to ignore it or act on it
differently ;)
drivers/platform/x86/acer-wmi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index d773b9d..43d992e 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -1671,7 +1671,7 @@ static ssize_t show_bool_threeg(struct device *dev,
u32 result; \
acpi_status status;
- pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
+ pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
current->comm);
status = get_u32(&result, ACER_CAP_THREEG);
if (ACPI_SUCCESS(status))
@@ -1684,7 +1684,7 @@ static ssize_t set_bool_threeg(struct device *dev,
{
u32 tmp = simple_strtoul(buf, NULL, 10);
acpi_status status = set_u32(tmp, ACER_CAP_THREEG);
- pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
+ pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
current->comm);
if (ACPI_FAILURE(status))
return -EINVAL;
@@ -1696,7 +1696,7 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
char *buf)
{
- pr_info("This interface sysfs will be removed in 2014 - used by: %s\n",
+ pr_info("This interface sysfs will be removed in 2016 - used by: %s\n",
current->comm);
switch (interface->type) {
case ACER_AMW0:
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | joeyli <jlee@suse.com> |
|---|---|
| Date | 2015-09-29 12:00 +0200 |
| Subject | Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qdZRw-2U9-3@gated-at.bofh.it> |
| In reply to | #1234745 |
Hi Martin,
On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote:
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> This just looks odd in the logs. Feel free to ignore it or act on it
> differently ;)
>
>
Thanks for your patch and it reminds me to remove those interfaces in acer-wmi.
Please let me check and I am thinking direct remove those interfaces.
Thanks a lot!
Joey Lee
> drivers/platform/x86/acer-wmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index d773b9d..43d992e 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1671,7 +1671,7 @@ static ssize_t show_bool_threeg(struct device *dev,
> u32 result; \
> acpi_status status;
>
> - pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> status = get_u32(&result, ACER_CAP_THREEG);
> if (ACPI_SUCCESS(status))
> @@ -1684,7 +1684,7 @@ static ssize_t set_bool_threeg(struct device *dev,
> {
> u32 tmp = simple_strtoul(buf, NULL, 10);
> acpi_status status = set_u32(tmp, ACER_CAP_THREEG);
> - pr_info("This threeg sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This threeg sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> if (ACPI_FAILURE(status))
> return -EINVAL;
> @@ -1696,7 +1696,7 @@ static DEVICE_ATTR(threeg, S_IRUGO | S_IWUSR, show_bool_threeg,
> static ssize_t show_interface(struct device *dev, struct device_attribute *attr,
> char *buf)
> {
> - pr_info("This interface sysfs will be removed in 2014 - used by: %s\n",
> + pr_info("This interface sysfs will be removed in 2016 - used by: %s\n",
> current->comm);
> switch (interface->type) {
> case ACER_AMW0:
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2015-10-03 19:30 +0200 |
| Subject | Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qfyNc-8t1-11@gated-at.bofh.it> |
| In reply to | #1234933 |
On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > Hi Martin, > > On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > > Signed-off-by: Martin Kepplinger <martink@posteo.de> > > --- > > This just looks odd in the logs. Feel free to ignore it or act on it > > differently ;) > > > > > > Thanks for your patch and it reminds me to remove those interfaces in acer-wmi. > Please let me check and I am thinking direct remove those interfaces. Joey, I will wait to hear from you on this patch (or a replacement). Thanks, -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Martin Kepplinger <martink@posteo.de> |
|---|---|
| Date | 2015-10-05 12:40 +0200 |
| Subject | Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qgblv-4JR-17@gated-at.bofh.it> |
| In reply to | #1238966 |
Am 2015-10-05 um 12:30 schrieb joeyli:
> Hi Darren,
>
> On Sat, Oct 03, 2015 at 10:20:52AM -0700, Darren Hart wrote:
>> On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote:
>>> Hi Martin,
>>>
>>> On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote:
>>>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>>>> ---
>>>> This just looks odd in the logs. Feel free to ignore it or act on it
>>>> differently ;)
>>>>
>>>>
>>>
>>> Thanks for your patch and it reminds me to remove those interfaces in acer-wmi.
>>> Please let me check and I am thinking direct remove those interfaces.
>>
>> Joey, I will wait to hear from you on this patch (or a replacement).
>>
>> Thanks,
>>
>
> Thanks for your reminding. I just sent patch to remove sysfs interface of acer-wmi.
>
> Joey Lee
>
I have to leave the estimation whether this old interface won't have
users to you and others, but if it's ok, it's nice to see dead code
removed! thanks,
martin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | joeyli <jlee@suse.com> |
|---|---|
| Date | 2015-10-05 15:10 +0200 |
| Subject | Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qgdGG-8dn-15@gated-at.bofh.it> |
| In reply to | #1239431 |
On Mon, Oct 05, 2015 at 12:34:47PM +0200, Martin Kepplinger wrote: > Am 2015-10-05 um 12:30 schrieb joeyli: > > Hi Darren, > > > > On Sat, Oct 03, 2015 at 10:20:52AM -0700, Darren Hart wrote: > >> On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > >>> Hi Martin, > >>> > >>> On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > >>>> Signed-off-by: Martin Kepplinger <martink@posteo.de> > >>>> --- > >>>> This just looks odd in the logs. Feel free to ignore it or act on it > >>>> differently ;) > >>>> > >>>> > >>> > >>> Thanks for your patch and it reminds me to remove those interfaces in acer-wmi. > >>> Please let me check and I am thinking direct remove those interfaces. > >> > >> Joey, I will wait to hear from you on this patch (or a replacement). > >> > >> Thanks, > >> > > > > Thanks for your reminding. I just sent patch to remove sysfs interface of acer-wmi. > > > > Joey Lee > > > > I have to leave the estimation whether this old interface won't have > users to you and others, but if it's ok, it's nice to see dead code > removed! thanks, > > martin User space should uses rfkill interface instead of sysfs. The original date of removal is 2012, then we extended the deadline to 2014. I think 3 years is enough to user space application for changing to rfkill. Still very thanks for your help on acer-wmi driver. Regards Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | joeyli <jlee@suse.com> |
|---|---|
| Date | 2015-10-05 12:40 +0200 |
| Subject | Re: [PATCH] platform: acer-wmi: update notice about deprecated user interface |
| Message-ID | <qgblv-4JR-19@gated-at.bofh.it> |
| In reply to | #1238966 |
Hi Darren, On Sat, Oct 03, 2015 at 10:20:52AM -0700, Darren Hart wrote: > On Tue, Sep 29, 2015 at 05:50:32PM +0800, joeyli wrote: > > Hi Martin, > > > > On Tue, Sep 29, 2015 at 08:46:38AM +0200, Martin Kepplinger wrote: > > > Signed-off-by: Martin Kepplinger <martink@posteo.de> > > > --- > > > This just looks odd in the logs. Feel free to ignore it or act on it > > > differently ;) > > > > > > > > > > Thanks for your patch and it reminds me to remove those interfaces in acer-wmi. > > Please let me check and I am thinking direct remove those interfaces. > > Joey, I will wait to hear from you on this patch (or a replacement). > > Thanks, > Thanks for your reminding. I just sent patch to remove sysfs interface of acer-wmi. Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web