Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1234538 > unrolled thread

[PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight

Started byPetr Cvek <petr.cvek@tul.cz>
First post2015-09-28 23:50 +0200
Last post2015-10-03 15:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM  backlight Petr Cvek <petr.cvek@tul.cz> - 2015-09-28 23:50 +0200
    Re: [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for  PWM backlight Philipp Zabel <philipp.zabel@gmail.com> - 2015-10-03 15:10 +0200

#1234538 — [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight

FromPetr Cvek <petr.cvek@tul.cz>
Date2015-09-28 23:50 +0200
Subject[PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight
Message-ID<qdOt5-3rn-13@gated-at.bofh.it>
Add a fake regulator, which is required for the correct initialization
of the PWM backlight driver.

Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
---
 arch/arm/mach-pxa/magician.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c
index 5de33c6..8d3946d 100644
--- a/arch/arm/mach-pxa/magician.c
+++ b/arch/arm/mach-pxa/magician.c
@@ -425,6 +425,15 @@ static struct pxafb_mach_info samsung_info = {
  * Backlight
  */
 
+ /*
+ * fixed regulator for pwm_backlight
+ */
+
+static struct regulator_consumer_supply pwm_backlight_supply[] = {
+	REGULATOR_SUPPLY("power", "pwm_backlight"),
+};
+
+
 static struct gpio magician_bl_gpios[] = {
 	{ EGPIO_MAGICIAN_BL_POWER,	GPIOF_DIR_OUT, "Backlight power" },
 	{ EGPIO_MAGICIAN_BL_POWER2,	GPIOF_DIR_OUT, "Backlight power 2" },
@@ -1125,6 +1134,9 @@ static void __init magician_init(void)
 	spi_register_board_info(ARRAY_AND_SIZE(ads7846_spi_board_info));
 
 	pxa_set_camera_info(&magician_pxacamera_pdata);
+
+	regulator_register_always_on(0, "power", pwm_backlight_supply,
+		ARRAY_SIZE(pwm_backlight_supply), 5000000);
 }
 
 MACHINE_START(MAGICIAN, "HTC Magician")
-- 
1.7.12.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1238858 — Re: [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight

FromPhilipp Zabel <philipp.zabel@gmail.com>
Date2015-10-03 15:10 +0200
SubjectRe: [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight
Message-ID<qfuJA-2GX-9@gated-at.bofh.it>
In reply to#1234538
Am Montag, den 28.09.2015, 23:40 +0200 schrieb Petr Cvek:
> Add a fake regulator, which is required for the correct
> initialization
> of the PWM backlight driver.

Fixed, not fake. Even though we can't control it, the backlight does
have a supply.

> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>

Acked-by: Philipp Zabel <philipp.zabel@gmail.com>

regards
Philipp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web