Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233108 > unrolled thread

Re: [PATCH v2 0/5] ACPI probing infrastructure

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 0/5] ACPI probing infrastructure "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-26 01:20 +0200
    Re: [PATCH v2 0/5] ACPI probing infrastructure Marc Zyngier <marc.zyngier@arm.com> - 2015-09-28 15:00 +0200
      Re: [PATCH v2 0/5] ACPI probing infrastructure "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-28 15:40 +0200
        Re: [PATCH v2 0/5] ACPI probing infrastructure Marc Zyngier <marc.zyngier@arm.com> - 2015-09-28 16:00 +0200
          Re: [Linaro-acpi] [PATCH v2 0/5] ACPI probing infrastructure Al Stone <al.stone@linaro.org> - 2015-09-28 21:50 +0200
            Re: [Linaro-acpi] [PATCH v2 0/5] ACPI probing infrastructure "Rafael J. Wysocki" <rafael@kernel.org> - 2015-09-28 21:50 +0200

#1233108 — Re: [PATCH v2 0/5] ACPI probing infrastructure

On Sunday, September 13, 2015 03:02:18 PM Marc Zyngier wrote:
> IRQ controllers and timers are the two types of device the kernel
> requires before being able to use the device driver model.
> 
> The Device Tree infrastructure makes it very easy to make these
> discoverable by the rest of the kernel. For example, each interrupt
> controller driver has at least one entry like this:
> 
> IRQCHIP_DECLARE(gic_400, "arm,gic-400", gic_of_init);
> 
> which says: if you find a node having "arm,gic-400" as a compatible
> string in the device tree, then call gic_of_init with this node as a
> parameter. The probing itself is done by the OF layer when the
> architecture code calls of_irq_init() (usually via irqchip_init).
> 
> This has a number of benefits:
> 
> - The irqchip code is self-contained. No architecture specific entry
> point, no exposed symbols. Just a standard interface.
> 
> - The low-level architecture code doesn't have to know about which
> interrupt controller is present. It just calls into the firmware
> interface (of_irq_init) which is going to sort things out.
> 
> Similar infrastructure is provided for the timers/clock sources. Note
> that this is not a replacement for the device model, but acts as a
> probing infrastructure for things that are required too early for the
> device infrastructure to be available.
> 
> What I'm aiming for is to introduce the same level of abstraction for
> ACPI, or at least for the few bits that are required before a full blown
> ACPI/device model can be used. For this, I introduce something vaguely
> similar:
> 
> IRQCHIP_ACPI_DECLARE(gic_v2, ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR,
> 		     gic_validate_dist, ACPI_MADT_GIC_VERSION_V2,
> 		     gic_v2_acpi_init);
> 
> which says: if you find a ACPI_MADT_TYPE_GENERIC_DISTRIBUTOR entry in
> MADT (implied by the macro), and that entry is of type
> ACPI_MADT_GIC_VERSION_V2 (as checked by gic_validate_dist), then call
> gic_v2_acpi_init with the entry as a parameter. A bit more convoluted,
> but still without any special entry point.
> 
> The various interrupt controller drivers can then implement the above,
> and the arch code can use a firmware-specific call to get the probing
> done, still oblivious to what interrupt controller is being used. It
> also makes the adaptation of a DT driver to ACPI easier.
> 
> It turns out that providing such a probing infrastructure is rather
> easy, and provides a much deserved cleanup in both the arch code, the
> GIC driver, and the architected timer driver.
> 
> I'm sure there is some more code to be deleted, and one can only
> wonder why this wasn't done before the arm64 code was initially merged
> (the diffstat says it all...).
> 
> Patches are against v4.3-rc1, and a branch is available at
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git acpi/device-probing-v2
> 
> * From the initial version:
>   - Make the infrastructure more DT like by providing an
>     acpi_probe_entry array per "device type" (one for irqchips, one
>     for clocksources). This means that entries can depend on any ACPI
>     static table.
>   - Use some cpp magic to reduce the amount of code added to an
>     absolute minimum.
>   - Rebased on v4.3-rc1
> 
> Marc Zyngier (5):
>   acpi: Add basic device probing infrastructure
>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>   irqchip/gic: Convert the GIC driver to ACPI probing
>   clocksource/acpi: Add probing infrastructure for ACPI-based
>     clocksources
>   clocksource/arm_arch_timer: Convert to ACPI probing

I'm generally fine with this (modulo a couple of super-minor nits in the
first patch), but it needs ACKs from Thomas for the irqchip-related and
clocksource-related patches.

Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
(currently in my bleeding-edge branch).

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1234115

Hi Rafael,

On 26/09/15 00:45, Rafael J. Wysocki wrote:

>> Marc Zyngier (5):
>>   acpi: Add basic device probing infrastructure
>>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>>   irqchip/gic: Convert the GIC driver to ACPI probing
>>   clocksource/acpi: Add probing infrastructure for ACPI-based
>>     clocksources
>>   clocksource/arm_arch_timer: Convert to ACPI probing
> 
> I'm generally fine with this (modulo a couple of super-minor nits in the
> first patch), but it needs ACKs from Thomas for the irqchip-related and
> clocksource-related patches.

Sure. I've now addressed your comments, and I'll post the updated series
later today.

> Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
> (currently in my bleeding-edge branch).

Al's patches were there on Friday, but vanished over the weekend. Do you
have another (stable?) branch with these patches in (assuming they are
still aimed at 4.4)?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234153

On Monday, September 28, 2015 01:59:19 PM Marc Zyngier wrote:
> Hi Rafael,
> 
> On 26/09/15 00:45, Rafael J. Wysocki wrote:
> 
> >> Marc Zyngier (5):
> >>   acpi: Add basic device probing infrastructure
> >>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
> >>   irqchip/gic: Convert the GIC driver to ACPI probing
> >>   clocksource/acpi: Add probing infrastructure for ACPI-based
> >>     clocksources
> >>   clocksource/arm_arch_timer: Convert to ACPI probing
> > 
> > I'm generally fine with this (modulo a couple of super-minor nits in the
> > first patch), but it needs ACKs from Thomas for the irqchip-related and
> > clocksource-related patches.
> 
> Sure. I've now addressed your comments, and I'll post the updated series
> later today.
> 
> > Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
> > (currently in my bleeding-edge branch).
> 
> Al's patches were there on Friday, but vanished over the weekend. Do you
> have another (stable?) branch with these patches in (assuming they are
> still aimed at 4.4)?

The Al's patches are gone for now, because they introduced a 0-day testing
regression.

I guess this means I can apply your patches first and ask Al to rebase his
next version on them.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234176

On 28/09/15 14:53, Rafael J. Wysocki wrote:
> On Monday, September 28, 2015 01:59:19 PM Marc Zyngier wrote:
>> Hi Rafael,
>>
>> On 26/09/15 00:45, Rafael J. Wysocki wrote:
>>
>>>> Marc Zyngier (5):
>>>>   acpi: Add basic device probing infrastructure
>>>>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>>>>   irqchip/gic: Convert the GIC driver to ACPI probing
>>>>   clocksource/acpi: Add probing infrastructure for ACPI-based
>>>>     clocksources
>>>>   clocksource/arm_arch_timer: Convert to ACPI probing
>>>
>>> I'm generally fine with this (modulo a couple of super-minor nits in the
>>> first patch), but it needs ACKs from Thomas for the irqchip-related and
>>> clocksource-related patches.
>>
>> Sure. I've now addressed your comments, and I'll post the updated series
>> later today.
>>
>>> Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
>>> (currently in my bleeding-edge branch).
>>
>> Al's patches were there on Friday, but vanished over the weekend. Do you
>> have another (stable?) branch with these patches in (assuming they are
>> still aimed at 4.4)?
> 
> The Al's patches are gone for now, because they introduced a 0-day testing
> regression.
> 
> I guess this means I can apply your patches first and ask Al to rebase his
> next version on them.

OK. I'll rebase them on the current bleeding-edge, and post that.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234389 — Re: [Linaro-acpi] [PATCH v2 0/5] ACPI probing infrastructure

On 09/28/2015 07:50 AM, Marc Zyngier wrote:
> On 28/09/15 14:53, Rafael J. Wysocki wrote:
>> On Monday, September 28, 2015 01:59:19 PM Marc Zyngier wrote:
>>> Hi Rafael,
>>>
>>> On 26/09/15 00:45, Rafael J. Wysocki wrote:
>>>
>>>>> Marc Zyngier (5):
>>>>>   acpi: Add basic device probing infrastructure
>>>>>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>>>>>   irqchip/gic: Convert the GIC driver to ACPI probing
>>>>>   clocksource/acpi: Add probing infrastructure for ACPI-based
>>>>>     clocksources
>>>>>   clocksource/arm_arch_timer: Convert to ACPI probing
>>>>
>>>> I'm generally fine with this (modulo a couple of super-minor nits in the
>>>> first patch), but it needs ACKs from Thomas for the irqchip-related and
>>>> clocksource-related patches.
>>>
>>> Sure. I've now addressed your comments, and I'll post the updated series
>>> later today.
>>>
>>>> Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
>>>> (currently in my bleeding-edge branch).
>>>
>>> Al's patches were there on Friday, but vanished over the weekend. Do you
>>> have another (stable?) branch with these patches in (assuming they are
>>> still aimed at 4.4)?
>>
>> The Al's patches are gone for now, because they introduced a 0-day testing
>> regression.
>>
>> I guess this means I can apply your patches first and ask Al to rebase his
>> next version on them.
> 
> OK. I'll rebase them on the current bleeding-edge, and post that.
> 
> Thanks,
> 
> 	M.
> 

Yeah, sorry about that; I had some bad info from the 1.0 version of the ACPI
spec.  And I was busy with family stuff all weekend.

Rafael, I'll look for Marc's patches to show up in bleeding-edge and rebase on
top of that.

-- 
ciao,
al
-----------------------------------
Al Stone
Software Engineer
Linaro Enterprise Group
al.stone@linaro.org
-----------------------------------
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1234391 — Re: [Linaro-acpi] [PATCH v2 0/5] ACPI probing infrastructure

Hi,

On Mon, Sep 28, 2015 at 9:43 PM, Al Stone <al.stone@linaro.org> wrote:
> On 09/28/2015 07:50 AM, Marc Zyngier wrote:
>> On 28/09/15 14:53, Rafael J. Wysocki wrote:
>>> On Monday, September 28, 2015 01:59:19 PM Marc Zyngier wrote:
>>>> Hi Rafael,
>>>>
>>>> On 26/09/15 00:45, Rafael J. Wysocki wrote:
>>>>
>>>>>> Marc Zyngier (5):
>>>>>>   acpi: Add basic device probing infrastructure
>>>>>>   irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>>>>>>   irqchip/gic: Convert the GIC driver to ACPI probing
>>>>>>   clocksource/acpi: Add probing infrastructure for ACPI-based
>>>>>>     clocksources
>>>>>>   clocksource/arm_arch_timer: Convert to ACPI probing
>>>>>
>>>>> I'm generally fine with this (modulo a couple of super-minor nits in the
>>>>> first patch), but it needs ACKs from Thomas for the irqchip-related and
>>>>> clocksource-related patches.
>>>>
>>>> Sure. I've now addressed your comments, and I'll post the updated series
>>>> later today.
>>>>
>>>>> Plus [3/5] needs to be rebased on top of the Al's patches removing BAD_MADT_ENTRY
>>>>> (currently in my bleeding-edge branch).
>>>>
>>>> Al's patches were there on Friday, but vanished over the weekend. Do you
>>>> have another (stable?) branch with these patches in (assuming they are
>>>> still aimed at 4.4)?
>>>
>>> The Al's patches are gone for now, because they introduced a 0-day testing
>>> regression.
>>>
>>> I guess this means I can apply your patches first and ask Al to rebase his
>>> next version on them.
>>
>> OK. I'll rebase them on the current bleeding-edge, and post that.
>>
>> Thanks,
>>
>>       M.
>>
>
> Yeah, sorry about that; I had some bad info from the 1.0 version of the ACPI
> spec.  And I was busy with family stuff all weekend.
>
> Rafael, I'll look for Marc's patches to show up in bleeding-edge and rebase on
> top of that.

Sounds good, thanks!

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web