Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1234267 > unrolled thread
| Started by | Dave Hansen <dave@sr71.net> |
|---|---|
| First post | 2015-09-28 18:00 +0200 |
| Last post | 2015-09-28 18:00 +0200 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] e1000: fix e1000e_disable_aspm_locked() warning Dave Hansen <dave@sr71.net> - 2015-09-28 18:00 +0200
| From | Dave Hansen <dave@sr71.net> |
|---|---|
| Date | 2015-09-28 18:00 +0200 |
| Subject | Re: [PATCH] e1000: fix e1000e_disable_aspm_locked() warning |
| Message-ID | <qdJ0l-3Un-7@gated-at.bofh.it> |
On 08/31/2015 02:26 PM, Dave Hansen wrote: > From: Dave Hansen <dave.hansen@linux.intel.com> > > I have a .config with CONFIG_PM disabled. I get the following whenever > compiling the e1000 driver: > > ...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: 'e1000e_disable_aspm_locked' defined but not used [-Wunused-function] > static void e1000e_disable_aspm_locked(struct pci_dev *pdev, u16 state) > > Looks like we just need to move e1000e_disable_aspm_locked() to > be underneath the CONFIG_PM #ifdef. This patch: [2758f9edb]: e1000e: Fix incorrect ASPM locking established a new caller for e1000e_disable_aspm_locked() which makes my patch useless and wrong (it breaks the compile). I believe we should just revert my patch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to top | Article view | linux.kernel
csiph-web