Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233805 > unrolled thread
| Started by | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| First post | 2015-09-28 02:40 +0200 |
| Last post | 2015-09-28 13:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Ben Hutchings <ben@decadent.org.uk> - 2015-09-28 02:40 +0200
Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Lee Jones <lee.jones@linaro.org> - 2015-09-28 12:40 +0200
Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Ben Hutchings <ben@decadent.org.uk> - 2015-09-28 13:20 +0200
Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop Lee Jones <lee.jones@linaro.org> - 2015-09-28 13:30 +0200
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2015-09-28 02:40 +0200 |
| Subject | [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop |
| Message-ID | <qduE2-6ua-11@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. A better fix might be to replace this loop with a delayed work item. References: https://bugs.debian.org/765717 Signed-off-by: Ben Hutchings <ben@decadent.org.uk> --- --- a/drivers/memstick/host/rtsx_usb_ms.c +++ b/drivers/memstick/host/rtsx_usb_ms.c @@ -706,7 +706,8 @@ poll_again: if (host->eject) break; - msleep(1000); + if (msleep_interruptible(1000)) + flush_signals(current); } complete(&host->detect_ms_exit); -- Ben Hutchings All extremists should be taken out and shot.
[toc] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-09-28 12:40 +0200 |
| Subject | Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop |
| Message-ID | <qdE0G-37c-25@gated-at.bofh.it> |
| In reply to | #1233805 |
The subsystem is missing from the subject line. On Mon, 28 Sep 2015, Ben Hutchings wrote: > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > uninterruptible sleep still contribute to the load average (for > bug-compatibility with Unix). A load average of ~1 on a system that > should be idle is somewhat alarming. > > Change the sleep to be interruptible, but still ignore signals. > > A better fix might be to replace this loop with a delayed work item. > > References: https://bugs.debian.org/765717 > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> How was this patch made? Where's the diff etc? Why was this patch sent to me? > --- > --- a/drivers/memstick/host/rtsx_usb_ms.c > +++ b/drivers/memstick/host/rtsx_usb_ms.c > @@ -706,7 +706,8 @@ poll_again: > if (host->eject) > break; > > - msleep(1000); > + if (msleep_interruptible(1000)) > + flush_signals(current); > } > > complete(&host->detect_ms_exit); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Ben Hutchings <ben@decadent.org.uk> |
|---|---|
| Date | 2015-09-28 13:20 +0200 |
| Subject | Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop |
| Message-ID | <qdEDo-45O-13@gated-at.bofh.it> |
| In reply to | #1234028 |
[Multipart message — attachments visible in raw view] — view raw
On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > The subsystem is missing from the subject line. > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > uninterruptible sleep still contribute to the load average (for > > bug-compatibility with Unix). A load average of ~1 on a system > > that > > should be idle is somewhat alarming. > > > > Change the sleep to be interruptible, but still ignore signals. > > > > A better fix might be to replace this loop with a delayed work > > item. > > > > References: https://bugs.debian.org/765717 > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > > How was this patch made? Where's the diff etc? With quilt. > Why was this patch sent to me? I think I must have added you previously as MFD maintainer, but as this doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry to bother you. Ben. > > --- > > --- a/drivers/memstick/host/rtsx_usb_ms.c > > +++ b/drivers/memstick/host/rtsx_usb_ms.c > > @@ -706,7 +706,8 @@ poll_again: > > if (host->eject) > > break; > > > > - msleep(1000); > > + if (msleep_interruptible(1000)) > > + flush_signals(current); > > } > > > > complete(&host->detect_ms_exit); > -- Ben Hutchings All extremists should be taken out and shot.
[toc] | [prev] | [next] | [standalone]
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-09-28 13:30 +0200 |
| Subject | Re: [PATCH RESEND] rtsx_usb_ms: Use msleep_interruptible() in polling loop |
| Message-ID | <qdEN4-4h4-9@gated-at.bofh.it> |
| In reply to | #1234055 |
On Mon, 28 Sep 2015, Ben Hutchings wrote: > On Mon, 2015-09-28 at 11:34 +0100, Lee Jones wrote: > > The subsystem is missing from the subject line. > > > > On Mon, 28 Sep 2015, Ben Hutchings wrote: > > > rtsx_usb_ms creates a task that mostly sleeps, but tasks in > > > uninterruptible sleep still contribute to the load average (for > > > bug-compatibility with Unix). A load average of ~1 on a system > > > that > > > should be idle is somewhat alarming. > > > > > > Change the sleep to be interruptible, but still ignore signals. > > > > > > A better fix might be to replace this loop with a delayed work > > > item. > > > > > > References: https://bugs.debian.org/765717 > > > Signed-off-by: Ben Hutchings <ben@decadent.org.uk> > > > > How was this patch made? Where's the diff etc? > > With quilt. Old Skool! ;) > > Why was this patch sent to me? > > I think I must have added you previously as MFD maintainer, but as this > doesn't touch rtsx_pcr or rtsx_usb it's not really in your area. Sorry > to bother you. No worries. > > > --- > > > --- a/drivers/memstick/host/rtsx_usb_ms.c > > > +++ b/drivers/memstick/host/rtsx_usb_ms.c > > > @@ -706,7 +706,8 @@ poll_again: > > > if (host->eject) > > > break; > > > > > > - msleep(1000); > > > + if (msleep_interruptible(1000)) > > > + flush_signals(current); > > > } > > > > > > complete(&host->detect_ms_exit); > > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web