Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233978 > unrolled thread

[PATCH 0/2] Fixes for next

Started byLudovic Desroches <ludovic.desroches@atmel.com>
First post2015-09-28 11:50 +0200
Last post2015-09-28 11:50 +0200
Articles 6 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] Fixes for next Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-09-28 11:50 +0200
    [PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-09-28 11:50 +0200
      Re: [PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked Linus Walleij <linus.walleij@linaro.org> - 2015-10-03 00:00 +0200
    [PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-09-28 11:50 +0200
      Re: [PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from  irq flow handlers Linus Walleij <linus.walleij@linaro.org> - 2015-10-03 00:00 +0200
    Re: [PATCH 0/2] Fixes for next Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-09-28 11:50 +0200

#1233978 — [PATCH 0/2] Fixes for next

FromLudovic Desroches <ludovic.desroches@atmel.com>
Date2015-09-28 11:50 +0200
Subject[PATCH 0/2] Fixes for next
Message-ID<qdDei-1XB-9@gated-at.bofh.it>
Hi Stephen, Linus,

Here are fixes for next. I did the at91-pio4 patches on top of next-20150916
which doesn't contain some tglx's updates about irqs.

Ludovic Desroches (2):
  pinctrl: at91-pio4: use irq_set_handler_locked
  pinctrl: at91-pio4: irq argument as been removed from irq flow
    handlers

 drivers/pinctrl/pinctrl-at91-pio4.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1233983 — [PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked

FromLudovic Desroches <ludovic.desroches@atmel.com>
Date2015-09-28 11:50 +0200
Subject[PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked
Message-ID<qdDei-1XB-17@gated-at.bofh.it>
In reply to#1233978
Use irq_set_handler_locked() as it avoids a redundant lookup of the
irq descriptor.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/pinctrl/pinctrl-at91-pio4.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
index 6aff632..041df59 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -167,23 +167,23 @@ static int atmel_gpio_irq_set_type(struct irq_data *d, unsigned type)
 
 	switch (type) {
 	case IRQ_TYPE_EDGE_RISING:
-		__irq_set_handler_locked(d->irq, handle_edge_irq);
+		irq_set_handler_locked(d, handle_edge_irq);
 		reg |= ATMEL_PIO_CFGR_EVTSEL_RISING;
 		break;
 	case IRQ_TYPE_EDGE_FALLING:
-		__irq_set_handler_locked(d->irq, handle_edge_irq);
+		irq_set_handler_locked(d, handle_edge_irq);
 		reg |= ATMEL_PIO_CFGR_EVTSEL_FALLING;
 		break;
 	case IRQ_TYPE_EDGE_BOTH:
-		__irq_set_handler_locked(d->irq, handle_edge_irq);
+		irq_set_handler_locked(d, handle_edge_irq);
 		reg |= ATMEL_PIO_CFGR_EVTSEL_BOTH;
 		break;
 	case IRQ_TYPE_LEVEL_LOW:
-		__irq_set_handler_locked(d->irq, handle_level_irq);
+		irq_set_handler_locked(d, handle_level_irq);
 		reg |= ATMEL_PIO_CFGR_EVTSEL_LOW;
 		break;
 	case IRQ_TYPE_LEVEL_HIGH:
-		__irq_set_handler_locked(d->irq, handle_level_irq);
+		irq_set_handler_locked(d, handle_level_irq);
 		reg |= ATMEL_PIO_CFGR_EVTSEL_HIGH;
 		break;
 	case IRQ_TYPE_NONE:
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1238643 — Re: [PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-10-03 00:00 +0200
SubjectRe: [PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked
Message-ID<qfgwX-7vm-27@gated-at.bofh.it>
In reply to#1233983
On Mon, Sep 28, 2015 at 2:41 AM, Ludovic Desroches
<ludovic.desroches@atmel.com> wrote:

> Use irq_set_handler_locked() as it avoids a redundant lookup of the
> irq descriptor.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233985 — [PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers

FromLudovic Desroches <ludovic.desroches@atmel.com>
Date2015-09-28 11:50 +0200
Subject[PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers
Message-ID<qdDei-1XB-23@gated-at.bofh.it>
In reply to#1233978
Irq argument as been removed from irq flow handlers so use the irq
descriptor to retrieve data we need.

Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
---
 drivers/pinctrl/pinctrl-at91-pio4.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl/pinctrl-at91-pio4.c
index 041df59..4aa6be0 100644
--- a/drivers/pinctrl/pinctrl-at91-pio4.c
+++ b/drivers/pinctrl/pinctrl-at91-pio4.c
@@ -222,9 +222,10 @@ static struct irq_chip atmel_gpio_irq_chip = {
 	.irq_set_type	= atmel_gpio_irq_set_type,
 };
 
-static void atmel_gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
+static void atmel_gpio_irq_handler(struct irq_desc *desc)
 {
-	struct atmel_pioctrl *atmel_pioctrl = irq_get_handler_data(irq);
+	unsigned int irq = irq_desc_get_irq(desc);
+	struct atmel_pioctrl *atmel_pioctrl = irq_desc_get_handler_data(desc);
 	struct irq_chip *chip = irq_desc_get_chip(desc);
 	unsigned long isr;
 	int n, bank = -1;
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1238635 — Re: [PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers

FromLinus Walleij <linus.walleij@linaro.org>
Date2015-10-03 00:00 +0200
SubjectRe: [PATCH 2/2] pinctrl: at91-pio4: irq argument as been removed from irq flow handlers
Message-ID<qfgwW-7vm-1@gated-at.bofh.it>
In reply to#1233985
On Mon, Sep 28, 2015 at 2:41 AM, Ludovic Desroches
<ludovic.desroches@atmel.com> wrote:

> Irq argument as been removed from irq flow handlers so use the irq
> descriptor to retrieve data we need.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233990

FromLudovic Desroches <ludovic.desroches@atmel.com>
Date2015-09-28 11:50 +0200
Message-ID<qdDej-1XB-45@gated-at.bofh.it>
In reply to#1233978
Sorry I have forgotten:
--in-reply-to=20150925133410.3c9e2b03@canb.auug.org.au

(linux-next: build failure after merge of the pinctrl tree)

On Mon, Sep 28, 2015 at 11:41:11AM +0200, Ludovic Desroches wrote:
> Hi Stephen, Linus,
> 
> Here are fixes for next. I did the at91-pio4 patches on top of next-20150916
> which doesn't contain some tglx's updates about irqs.
> 
> Ludovic Desroches (2):
>   pinctrl: at91-pio4: use irq_set_handler_locked
>   pinctrl: at91-pio4: irq argument as been removed from irq flow
>     handlers
> 
>  drivers/pinctrl/pinctrl-at91-pio4.c | 15 ++++++++-------
>  1 file changed, 8 insertions(+), 7 deletions(-)
> 
> -- 
> 2.5.0
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web