Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1233693 > unrolled thread

[PATCH 2/2] x86/cpu/cacheinfo: amd_get/set_l3_disable_slot should be static

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] x86/cpu/cacheinfo: amd_get/set_l3_disable_slot should be static Geliang Tang <geliangtang@163.com> - 2015-09-27 17:50 +0200
    Re: [PATCH 2/2] x86/cpu/cacheinfo: amd_get/set_l3_disable_slot  should be static Borislav Petkov <bp@suse.de> - 2015-09-28 09:30 +0200

#1233693 — [PATCH 2/2] x86/cpu/cacheinfo: amd_get/set_l3_disable_slot should be static

Fixes the following sparse warnings:

 arch/x86/kernel/cpu/intel_cacheinfo.c:329:5: warning: symbol
 'amd_get_l3_disable_slot' was not declared. Should it be static?

 arch/x86/kernel/cpu/intel_cacheinfo.c:406:5: warning: symbol
 'amd_set_l3_disable_slot' was not declared. Should it be static?

Signed-off-by: Geliang Tang <geliangtang@163.com>
---
 arch/x86/kernel/cpu/intel_cacheinfo.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel_cacheinfo.c b/arch/x86/kernel/cpu/intel_cacheinfo.c
index 6245a3c..e38d338 100644
--- a/arch/x86/kernel/cpu/intel_cacheinfo.c
+++ b/arch/x86/kernel/cpu/intel_cacheinfo.c
@@ -326,7 +326,7 @@ static void amd_calc_l3_indices(struct amd_northbridge *nb)
  *
  * @returns: the disabled index if used or negative value if slot free.
  */
-int amd_get_l3_disable_slot(struct amd_northbridge *nb, unsigned slot)
+static int amd_get_l3_disable_slot(struct amd_northbridge *nb, unsigned slot)
 {
 	unsigned int reg = 0;
 
@@ -403,8 +403,8 @@ static void amd_l3_disable_index(struct amd_northbridge *nb, int cpu,
  *
  * @return: 0 on success, error status on failure
  */
-int amd_set_l3_disable_slot(struct amd_northbridge *nb, int cpu, unsigned slot,
-			    unsigned long index)
+static int amd_set_l3_disable_slot(struct amd_northbridge *nb, int cpu,
+			    unsigned slot, unsigned long index)
 {
 	int ret = 0;
 
-- 
2.5.0


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1233911 — Re: [PATCH 2/2] x86/cpu/cacheinfo: amd_get/set_l3_disable_slot should be static

On Sun, Sep 27, 2015 at 11:40:46PM +0800, Geliang Tang wrote:
> Fixes the following sparse warnings:
> 
>  arch/x86/kernel/cpu/intel_cacheinfo.c:329:5: warning: symbol
>  'amd_get_l3_disable_slot' was not declared. Should it be static?
> 
>  arch/x86/kernel/cpu/intel_cacheinfo.c:406:5: warning: symbol
>  'amd_set_l3_disable_slot' was not declared. Should it be static?
> 
> Signed-off-by: Geliang Tang <geliangtang@163.com>
> ---
>  arch/x86/kernel/cpu/intel_cacheinfo.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Both applied,
thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web