Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233904 > unrolled thread
| Started by | Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> |
|---|---|
| First post | 2015-09-28 09:10 +0200 |
| Last post | 2015-09-28 11:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 2/9] drivers:mtd:ubi:add definition for UBI bakvol operation Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> - 2015-09-28 09:10 +0200
Re: [PATCH 2/9] drivers:mtd:ubi:add definition for UBI bakvol operation Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-28 11:50 +0200
| From | Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> |
|---|---|
| Date | 2015-09-28 09:10 +0200 |
| Subject | [PATCH 2/9] drivers:mtd:ubi:add definition for UBI bakvol operation |
| Message-ID | <qdAJs-6Z2-31@gated-at.bofh.it> |
QWRkIG1hY3JvIGRlZmluaXRpb24gZm9yIFVCSSBiYWt2b2wgb3BlcmF0aW9uLg0KDQpTaWduZWQt b2ZmLWJ5OiBCZWFuIEh1byA8YmVhbmh1b0BtaWNyb24uY29tPg0KLS0tDQogZHJpdmVycy9tdGQv dWJpL3ViaS5oIHwgMTcgKysrKysrKysrKysrKysrKysNCiAxIGZpbGUgY2hhbmdlZCwgMTcgaW5z ZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvdWJpL3ViaS5oIGIvZHJpdmVy cy9tdGQvdWJpL3ViaS5oDQppbmRleCAyOTc0YjY3Li43NDZkZmJlIDEwMDY0NA0KLS0tIGEvZHJp dmVycy9tdGQvdWJpL3ViaS5oDQorKysgYi9kcml2ZXJzL210ZC91YmkvdWJpLmgNCkBAIC00Mzgs NiArNDM4LDcgQEAgc3RydWN0IHViaV9kZWJ1Z19pbmZvIHsNCiAgKiBAdnRibF9zbG90czogaG93 IG1hbnkgc2xvdHMgYXJlIGF2YWlsYWJsZSBpbiB0aGUgdm9sdW1lIHRhYmxlDQogICogQHZ0Ymxf c2l6ZTogc2l6ZSBvZiB0aGUgdm9sdW1lIHRhYmxlIGluIGJ5dGVzDQogICogQHZ0Ymw6IGluLVJB TSB2b2x1bWUgdGFibGUgY29weQ0KKyAqIEBia2Jsa190Ymw6IGJhY2t1cCBibG9jayB0YWJsZQ0K ICAqIEBkZXZpY2VfbXV0ZXg6IHByb3RlY3RzIG9uLWZsYXNoIHZvbHVtZSB0YWJsZSBhbmQgc2Vy aWFsaXplcyB2b2x1bWUNCiAgKiAgICAgICAgICAgICAgICBjcmVhdGlvbiwgZGVsZXRpb24sIHVw ZGF0ZSwgcmUtc2l6ZSwgcmUtbmFtZSBhbmQgc2V0DQogICogICAgICAgICAgICAgICAgcHJvcGVy dHkNCkBAIC01NDcsNiArNTQ4LDcgQEAgc3RydWN0IHViaV9kZXZpY2Ugew0KIAlpbnQgdnRibF9z bG90czsNCiAJaW50IHZ0Ymxfc2l6ZTsNCiAJc3RydWN0IHViaV92dGJsX3JlY29yZCAqdnRibDsN CisJc3RydWN0IHViaV9ia2Jsa190YmwgKmJrYmxrX3RibDsNCiAJc3RydWN0IG11dGV4IGRldmlj ZV9tdXRleDsNCiANCiAJaW50IG1heF9lYzsNCkBAIC03OTcsNiArNzk5LDIwIEBAIGludCB1Ymlf dnRibF9yZW5hbWVfdm9sdW1lcyhzdHJ1Y3QgdWJpX2RldmljZSAqdWJpLA0KIAkJCSAgICBzdHJ1 Y3QgbGlzdF9oZWFkICpyZW5hbWVfbGlzdCk7DQogaW50IHViaV9yZWFkX3ZvbHVtZV90YWJsZShz dHJ1Y3QgdWJpX2RldmljZSAqdWJpLCBzdHJ1Y3QgdWJpX2F0dGFjaF9pbmZvICphaSk7DQogDQor LyogYmFrdm9sLmMqLw0KK2ludCB1YmlfY2hlY2tfYmFja3VwX3ZvbHVtZShzdHJ1Y3QgdWJpX2Rl dmljZSAqdWJpKTsNCitpbnQgdWJpX2JhY2t1cF9kYXRhX3RvX2JhY2t1cF92b2x1bWUoc3RydWN0 IHViaV9kZXZpY2UgKnViaSwgbG9mZl90IGFkZHIsDQorCQlzaXplX3QgbGVuLCBzaXplX3QgKnJl dGxlbiwgY29uc3Qgdm9pZCAqYnVmKTsNCitpbnQgdWJpX2JhY2t1cF92b2x1bWVfaW5pdChzdHJ1 Y3QgdWJpX2RldmljZSAqdWJpKTsNCitpbnQgdWJpX2JhY2t1cF92b2x1bWVfc2NhbihzdHJ1Y3Qg dWJpX2RldmljZSAqdWJpLA0KKwkJCXN0cnVjdCB1YmlfdmlkX2hkciAqdmlkaCwgaW50IHBudW0p Ow0KK2ludCB1YmlfYmFja3VwX3ZvbHVtZV9pbml0X3RhaWwoc3RydWN0IHViaV9kZXZpY2UgKnVi aSwNCisJCQkJc3RydWN0IHViaV9hdHRhY2hfaW5mbyAqc2kpOw0KK2ludCB1YmlfYmFkX2RhdGFf cmVjb3Zlcnkoc3RydWN0IHViaV9kZXZpY2UgKnViaSk7DQoraW50IGlzX2JhY2t1cF9uZWVkKHN0 cnVjdCB1YmlfZGV2aWNlICp1YmksIGxvZmZfdCBhZGRyKTsNCit2b2lkIGluaXRfYmFrdm9sKHN0 cnVjdCB1Ymlfdm9sdW1lX2Rlc2MgKmRlc2MsIHVpbnQ4X3QgY2hvaWNlKTsNCit2b2lkIGNsZWFy X2Jha3ZvbChzdHJ1Y3QgdWJpX2RldmljZSAqdWJpKTsNCisNCiAvKiB2bXQuYyAqLw0KIGludCB1 YmlfY3JlYXRlX3ZvbHVtZShzdHJ1Y3QgdWJpX2RldmljZSAqdWJpLCBzdHJ1Y3QgdWJpX21rdm9s X3JlcSAqcmVxKTsNCiBpbnQgdWJpX3JlbW92ZV92b2x1bWUoc3RydWN0IHViaV92b2x1bWVfZGVz YyAqZGVzYywgaW50IG5vX3Z0YmwpOw0KQEAgLTg0Niw2ICs4NjIsNyBAQCBpbnQgc2VsZl9jaGVj a19lYmEoc3RydWN0IHViaV9kZXZpY2UgKnViaSwgc3RydWN0IHViaV9hdHRhY2hfaW5mbyAqYWlf ZmFzdG1hcCwNCiANCiAvKiB3bC5jICovDQogaW50IHViaV93bF9nZXRfcGViKHN0cnVjdCB1Ymlf ZGV2aWNlICp1YmkpOw0KK2ludCB1Ymlfd2xfZ2V0X3BsYW5lX3BlYihzdHJ1Y3QgdWJpX2Rldmlj ZSAqdWJpLCBpbnQgcGxhbmUpOw0KIGludCB1Ymlfd2xfcHV0X3BlYihzdHJ1Y3QgdWJpX2Rldmlj ZSAqdWJpLCBpbnQgdm9sX2lkLCBpbnQgbG51bSwNCiAJCSAgIGludCBwbnVtLCBpbnQgdG9ydHVy ZSk7DQogaW50IHViaV93bF9mbHVzaChzdHJ1Y3QgdWJpX2RldmljZSAqdWJpLCBpbnQgdm9sX2lk LCBpbnQgbG51bSk7DQotLSANCjEuOS4xDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2015-09-28 11:50 +0200 |
| Subject | Re: [PATCH 2/9] drivers:mtd:ubi:add definition for UBI bakvol operation |
| Message-ID | <qdDei-1XB-25@gated-at.bofh.it> |
| In reply to | #1233904 |
On Mon, 28 Sep 2015 07:02:40 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> wrote:
> Add macro definition for UBI bakvol operation.
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> drivers/mtd/ubi/ubi.h | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/mtd/ubi/ubi.h b/drivers/mtd/ubi/ubi.h
> index 2974b67..746dfbe 100644
> --- a/drivers/mtd/ubi/ubi.h
> +++ b/drivers/mtd/ubi/ubi.h
> @@ -438,6 +438,7 @@ struct ubi_debug_info {
> * @vtbl_slots: how many slots are available in the volume table
> * @vtbl_size: size of the volume table in bytes
> * @vtbl: in-RAM volume table copy
> + * @bkblk_tbl: backup block table
> * @device_mutex: protects on-flash volume table and serializes volume
> * creation, deletion, update, re-size, re-name and set
> * property
> @@ -547,6 +548,7 @@ struct ubi_device {
> int vtbl_slots;
> int vtbl_size;
> struct ubi_vtbl_record *vtbl;
> + struct ubi_bkblk_tbl *bkblk_tbl;
Where is struct ubi_bkblk_tbl defined (actually I found it in patch
2).
> struct mutex device_mutex;
>
> int max_ec;
> @@ -797,6 +799,20 @@ int ubi_vtbl_rename_volumes(struct ubi_device *ubi,
> struct list_head *rename_list);
> int ubi_read_volume_table(struct ubi_device *ubi, struct ubi_attach_info *ai);
>
> +/* bakvol.c*/
> +int ubi_check_backup_volume(struct ubi_device *ubi);
> +int ubi_backup_data_to_backup_volume(struct ubi_device *ubi, loff_t addr,
> + size_t len, size_t *retlen, const void *buf);
> +int ubi_backup_volume_init(struct ubi_device *ubi);
> +int ubi_backup_volume_scan(struct ubi_device *ubi,
> + struct ubi_vid_hdr *vidh, int pnum);
> +int ubi_backup_volume_init_tail(struct ubi_device *ubi,
> + struct ubi_attach_info *si);
> +int ubi_bad_data_recovery(struct ubi_device *ubi);
> +int is_backup_need(struct ubi_device *ubi, loff_t addr);
> +void init_bakvol(struct ubi_volume_desc *desc, uint8_t choice);
> +void clear_bakvol(struct ubi_device *ubi);
> +
> /* vmt.c */
> int ubi_create_volume(struct ubi_device *ubi, struct ubi_mkvol_req *req);
> int ubi_remove_volume(struct ubi_volume_desc *desc, int no_vtbl);
> @@ -846,6 +862,7 @@ int self_check_eba(struct ubi_device *ubi, struct ubi_attach_info *ai_fastmap,
>
> /* wl.c */
> int ubi_wl_get_peb(struct ubi_device *ubi);
> +int ubi_wl_get_plane_peb(struct ubi_device *ubi, int plane);
The same goes for those functions. You only define their protypes here,
and implement them in patch 4.
Please split your changes in a consistent way.
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web