Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1233896 > unrolled thread
| Started by | Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> |
|---|---|
| First post | 2015-09-28 09:10 +0200 |
| Last post | 2015-09-28 12:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 3/9] drivers:mtd:ubi:add metadata struct for UBI bakvol Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> - 2015-09-28 09:10 +0200
Re: [PATCH 3/9] drivers:mtd:ubi:add metadata struct for UBI bakvol Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-28 12:10 +0200
| From | Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> |
|---|---|
| Date | 2015-09-28 09:10 +0200 |
| Subject | [PATCH 3/9] drivers:mtd:ubi:add metadata struct for UBI bakvol |
| Message-ID | <qdAJs-6Z2-15@gated-at.bofh.it> |
QWRkIG1ldGFkYXRhIHN0cnVjdCBmb3IgVUJJIGJha3ZvbC4NCkN1cnJlbnRseSAsIGJha3ZvbCBy ZXNlcnZlcyAyMCBQRUJzIGZvciBpbnRlcm5hbCBsb2cgdm9sdW1lLg0KU2hhcmVzIHdlYXItbGV2 ZWxpbmcgb3BlcmF0aW9uIHdpdGggdWJpLiANCg0KDQpTaWduZWQtb2ZmLWJ5OiBCZWFuIEh1byA8 YmVhbmh1b0BtaWNyb24uY29tPg0KLS0tDQogZHJpdmVycy9tdGQvdWJpL3ViaS1tZWRpYS5oIHwg NDAgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKw0KIDEgZmlsZSBjaGFu Z2VkLCA0MCBpbnNlcnRpb25zKCspDQoNCmRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC91YmkvdWJp LW1lZGlhLmggYi9kcml2ZXJzL210ZC91YmkvdWJpLW1lZGlhLmgNCmluZGV4IGQwZDA3MmUuLjMz MTVkNWIgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL210ZC91YmkvdWJpLW1lZGlhLmgNCisrKyBiL2Ry aXZlcnMvbXRkL3ViaS91YmktbWVkaWEuaA0KQEAgLTMxLDYgKzMxLDcgQEANCiAjZGVmaW5lIF9f VUJJX01FRElBX0hfXw0KIA0KICNpbmNsdWRlIDxhc20vYnl0ZW9yZGVyLmg+DQorI2luY2x1ZGUg PGxpbnV4L2xpc3QuaD4NCiANCiAvKiBUaGUgdmVyc2lvbiBvZiBVQkkgaW1hZ2VzIHN1cHBvcnRl ZCBieSB0aGlzIGltcGxlbWVudGF0aW9uICovDQogI2RlZmluZSBVQklfVkVSU0lPTiAxDQpAQCAt Mjk1LDcgKzI5NiwxMSBAQCBzdHJ1Y3QgdWJpX3ZpZF9oZHIgew0KIH0gX19wYWNrZWQ7DQogDQog LyogSW50ZXJuYWwgVUJJIHZvbHVtZXMgY291bnQgKi8NCisjaWZkZWYgQ09ORklHX01URF9VQklf TUxDX05BTkRfQkFLVk9MDQorI2RlZmluZSBVQklfSU5UX1ZPTF9DT1VOVCAyDQorI2Vsc2UNCiAj ZGVmaW5lIFVCSV9JTlRfVk9MX0NPVU5UIDENCisjZW5kaWYNCiANCiAvKg0KICAqIFN0YXJ0aW5n IElEIG9mIGludGVybmFsIHZvbHVtZXM6IDB4N2ZmZmVmZmYuDQpAQCAtMzEyLDYgKzMxNywxNSBA QCBzdHJ1Y3QgdWJpX3ZpZF9oZHIgew0KICNkZWZpbmUgVUJJX0xBWU9VVF9WT0xVTUVfTkFNRSAg ICJsYXlvdXQgdm9sdW1lIg0KICNkZWZpbmUgVUJJX0xBWU9VVF9WT0xVTUVfQ09NUEFUIFVCSV9D T01QQVRfUkVKRUNUDQogDQorLyogVGhlIGJhY2t1cCBsb2cgdm9sdW1lICovDQorDQorI2RlZmlu ZSBVQklfQkFDS1VQX1ZPTFVNRV9JRCAgICAgKFVCSV9JTlRFUk5BTF9WT0xfU1RBUlQgKyAxKQ0K KyNkZWZpbmUgVUJJX0JBQ0tVUF9WT0xVTUVfVFlQRSAgIFVCSV9WSURfRFlOQU1JQw0KKyNkZWZp bmUgVUJJX0JBQ0tVUF9WT0xVTUVfQUxJR04gIDENCisjZGVmaW5lIFVCSV9CQUNLVVBfVk9MVU1F X0VCUyAgICAyMA0KKyNkZWZpbmUgVUJJX0JBQ0tVUF9WT0xVTUVfTkFNRSAgICJsb2cgdm9sdW1l Ig0KKyNkZWZpbmUgVUJJX0JBQ0tVUF9WT0xVTUVfQ09NUEFUIFVCSV9DT01QQVRfUkVKRUNUDQor DQogLyogVGhlIG1heGltdW0gbnVtYmVyIG9mIHZvbHVtZXMgcGVyIG9uZSBVQkkgZGV2aWNlICov DQogI2RlZmluZSBVQklfTUFYX1ZPTFVNRVMgMTI4DQogDQpAQCAtMzI1LDYgKzMzOSwzMiBAQCBz dHJ1Y3QgdWJpX3ZpZF9oZHIgew0KICNkZWZpbmUgVUJJX1ZUQkxfUkVDT1JEX1NJWkVfQ1JDIChV QklfVlRCTF9SRUNPUkRfU0laRSAtIHNpemVvZihfX2JlMzIpKQ0KIA0KIC8qKg0KKyAqIHN0cnVj dCB1YmlfYmtibGtfaW5mbyAtIHRoZSBpbmZvcm1hdGlvbiBmb3Igb25lIGJhY2t1cCBibG9jayAu DQorICogQHBibjogcGh5c2ljYWwgYmxvY2sgbnVtYmVyDQorICogQGxibjogIGxvZ2ljIGJsb2Nr IG51bWJlcg0KKyAqIEBwbGFuZTogdGhpcyBibG9jayBiZWxvbmdzIHRvIHdoaWNoIHBsYW5lDQor ICogQHBnbnVtOiB0aGUgcGFnZSBudW1iZXIgKGxvd2VyIHBhZ2UpIHRoYXQgY2FuIGJlIHByb2dy YW1tZWQgbGFzdCB0aW1lDQorICovDQorc3RydWN0IHViaV9ia2Jsa19pbmZvIHsNCisJX19iZTMy ICBwYm47DQorCV9fYmUzMiAgbGJuOw0KKwlfX3U4ICAgIHBsYW5lOw0KKwlfX2JlMzIgIHBnbnVt Ow0KKwlzdHJ1Y3QgIGxpc3RfaGVhZCBub2RlOw0KK307DQorDQorLyoqDQorICogc3RydWN0IHVi aV9ia2Jsa190YmwgLSBhIHRhYmxlIGZvciBiYWNrdXAgYmxvY2tzLg0KKyAqIEB2b2x1bWVfYnVp bHQ6IGluZGljYXRlIGlmIGJhY2t1cCB2b2x1bWUgYmUgaW5pdHRlZA0KKyAqIEBiY291bnRfb2Zf cGxhbmU6ICBibG9jayBjb3VudCB0aGF0IGhhcyBiZWUgYXBwbGllZCBmb3IgY29ycmVzcG9uZGlu ZyBwbGFuZQ0KKyAqLw0KK3N0cnVjdCB1YmlfYmtibGtfdGJsIHsNCisJX191OCAgICB2b2x1bWVf YnVpbHQ7DQorCV9fYmUzMiAgYmNvdW50X29mX3BsYW5lWzJdOw0KKwlzdHJ1Y3QgIGxpc3RfaGVh ZCBoZWFkOw0KK307DQorDQorLyoqDQogICogc3RydWN0IHViaV92dGJsX3JlY29yZCAtIGEgcmVj b3JkIGluIHRoZSB2b2x1bWUgdGFibGUuDQogICogQHJlc2VydmVkX3BlYnM6IGhvdyBtYW55IHBo eXNpY2FsIGVyYXNlYmxvY2tzIGFyZSByZXNlcnZlZCBmb3IgdGhpcyB2b2x1bWUNCiAgKiBAYWxp Z25tZW50OiB2b2x1bWUgYWxpZ25tZW50DQotLSANCjEuOS4xDQo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2015-09-28 12:10 +0200 |
| Message-ID | <qdDxE-2zm-15@gated-at.bofh.it> |
| In reply to | #1233896 |
On Mon, 28 Sep 2015 07:02:42 +0000
Bean Huo 霍斌斌 (beanhuo) <beanhuo@micron.com> wrote:
> Add metadata struct for UBI bakvol.
> Currently , bakvol reserves 20 PEBs for internal log volume.
> Shares wear-leveling operation with ubi.
>
>
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
> drivers/mtd/ubi/ubi-media.h | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
[...]
>
> @@ -325,6 +339,32 @@ struct ubi_vid_hdr {
> #define UBI_VTBL_RECORD_SIZE_CRC (UBI_VTBL_RECORD_SIZE - sizeof(__be32))
>
> /**
> + * struct ubi_bkblk_info - the information for one backup block .
> + * @pbn: physical block number
> + * @lbn: logic block number
> + * @plane: this block belongs to which plane
> + * @pgnum: the page number (lower page) that can be programmed last time
> + */
I'm not sure to understand what those fields are used for, but I guess
I'll understand it while reviewing the following patches.
> +struct ubi_bkblk_info {
> + __be32 pbn;
> + __be32 lbn;
> + __u8 plane;
> + __be32 pgnum;
> + struct list_head node;
> +};
You're mixing runtime and storage representation: node has nothing to
do here.
> +
> +/**
> + * struct ubi_bkblk_tbl - a table for backup blocks.
> + * @volume_built: indicate if backup volume be initted
> + * @bcount_of_plane: block count that has bee applied for corresponding plane
> + */
> +struct ubi_bkblk_tbl {
> + __u8 volume_built;
> + __be32 bcount_of_plane[2];
> + struct list_head head;
> +};
Ditto.
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web