Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1232629 > unrolled thread

Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

Started byJean Delvare <jdelvare@suse.de>
First post2015-09-25 09:40 +0200
Last post2015-09-25 16:10 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: randconfig build error with next-20150812, in  drivers/i2c/busses/i2c-i801.c Jean Delvare <jdelvare@suse.de> - 2015-09-25 09:40 +0200
    Re: randconfig build error with next-20150812, in  drivers/i2c/busses/i2c-i801.c Matt Fleming <matt@codeblueprint.co.uk> - 2015-09-25 15:40 +0200
      Re: randconfig build error with next-20150812, in  drivers/i2c/busses/i2c-i801.c Jean Delvare <jdelvare@suse.de> - 2015-09-25 16:10 +0200

#1232629 — Re: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c

FromJean Delvare <jdelvare@suse.de>
Date2015-09-25 09:40 +0200
SubjectRe: randconfig build error with next-20150812, in drivers/i2c/busses/i2c-i801.c
Message-ID<qcvLQ-3dG-7@gated-at.bofh.it>
On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote:
> Building with the attached random configuration file,
> 
> drivers/built-in.o: In function `dmi_check_onboard_devices':
> i2c-i801.c:(.text+0x126b36): undefined reference to `i2c_new_device'
> drivers/built-in.o: In function `i801_remove':
> i2c-i801.c:(.text+0x126b86): undefined reference to `i2c_del_adapter'
> drivers/built-in.o: In function `i801_probe':
> i2c-i801.c:(.text+0x127d08): undefined reference to `i2c_add_adapter'
> i2c-i801.c:(.text+0x127d6e): undefined reference to `i2c_new_device'

Sorry for the late reply. The error is caused by the following
combination of options:

CONFIG_I2C=m
CONFIG_I2C_I801=y

I can reproduce it even with mainline now. This is caused by
CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting
its dependencies (CONFIG_I2C.)

Thanks for reporting, I'll post a fix shortly.

-- 
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1232827

FromMatt Fleming <matt@codeblueprint.co.uk>
Date2015-09-25 15:40 +0200
Message-ID<qcBoe-2Py-11@gated-at.bofh.it>
In reply to#1232629
On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote:
> On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote:
> > Building with the attached random configuration file,
> > 
> > drivers/built-in.o: In function `dmi_check_onboard_devices':
> > i2c-i801.c:(.text+0x126b36): undefined reference to `i2c_new_device'
> > drivers/built-in.o: In function `i801_remove':
> > i2c-i801.c:(.text+0x126b86): undefined reference to `i2c_del_adapter'
> > drivers/built-in.o: In function `i801_probe':
> > i2c-i801.c:(.text+0x127d08): undefined reference to `i2c_add_adapter'
> > i2c-i801.c:(.text+0x127d6e): undefined reference to `i2c_new_device'
> 
> Sorry for the late reply. The error is caused by the following
> combination of options:
> 
> CONFIG_I2C=m
> CONFIG_I2C_I801=y
> 
> I can reproduce it even with mainline now. This is caused by
> CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting
> its dependencies (CONFIG_I2C.)
> 
> Thanks for reporting, I'll post a fix shortly.

Sorry that you got caught up in this build error Jean.

Guenter (Cc'd) posted a fix here,

  https://lkml.kernel.org/r/1441978088-27288-1-git-send-email-linux@roeck-us.net

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1232840

FromJean Delvare <jdelvare@suse.de>
Date2015-09-25 16:10 +0200
Message-ID<qcBRg-3CV-9@gated-at.bofh.it>
In reply to#1232827
Le Friday 25 September 2015 à 14:37 +0100, Matt Fleming a écrit :
> On Fri, 25 Sep, at 09:36:10AM, Jean Delvare wrote:
> > On Wed, 12 Aug 2015 08:42:18 -0700, Jim Davis wrote:
> > > Building with the attached random configuration file,
> > > 
> > > drivers/built-in.o: In function `dmi_check_onboard_devices':
> > > i2c-i801.c:(.text+0x126b36): undefined reference to `i2c_new_device'
> > > drivers/built-in.o: In function `i801_remove':
> > > i2c-i801.c:(.text+0x126b86): undefined reference to `i2c_del_adapter'
> > > drivers/built-in.o: In function `i801_probe':
> > > i2c-i801.c:(.text+0x127d08): undefined reference to `i2c_add_adapter'
> > > i2c-i801.c:(.text+0x127d6e): undefined reference to `i2c_new_device'
> > 
> > Sorry for the late reply. The error is caused by the following
> > combination of options:
> > 
> > CONFIG_I2C=m
> > CONFIG_I2C_I801=y
> > 
> > I can reproduce it even with mainline now. This is caused by
> > CONFIG_ITCO_WDT=y, which selects CONFIG_I2C_I801=y without selecting
> > its dependencies (CONFIG_I2C.)
> > 
> > Thanks for reporting, I'll post a fix shortly.
> 
> Sorry that you got caught up in this build error Jean.

No big deal :)

> Guenter (Cc'd) posted a fix here,
> 
>   https://lkml.kernel.org/r/1441978088-27288-1-git-send-email-linux@roeck-us.net

Actually I prefer Guenter's approach. I am never comfortable with
drivers selecting subsystems. So you can add:

Acked-by: Jean Delvare <jdelvare@suse.de>

to Guenter's patch and drop mine.

Thanks,
-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web