Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1230121 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2015-09-22 14:30 +0200 |
| Last post | 2015-09-25 02:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[patch] ACPI / tables: test the correct variable Dan Carpenter <dan.carpenter@oracle.com> - 2015-09-22 14:30 +0200
Re: [patch] ACPI / tables: test the correct variable "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-09-25 02:00 +0200
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2015-09-22 14:30 +0200 |
| Subject | [patch] ACPI / tables: test the correct variable |
| Message-ID | <qbuRQ-5fA-41@gated-at.bofh.it> |
The intent was to test "proc[i].handler" instead of "proc->handler".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index c1ff58d..6c0f079 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -268,7 +268,8 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
for (i = 0; i < proc_num; i++) {
if (entry->type != proc[i].id)
continue;
- if (!proc->handler || proc[i].handler(entry, table_end))
+ if (!proc[i].handler ||
+ proc[i].handler(entry, table_end))
return -EINVAL;
proc->count++;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2015-09-25 02:00 +0200 |
| Message-ID | <qcoAG-1qR-3@gated-at.bofh.it> |
| In reply to | #1230121 |
On Tuesday, September 22, 2015 03:29:25 PM Dan Carpenter wrote:
> The intent was to test "proc[i].handler" instead of "proc->handler".
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index c1ff58d..6c0f079 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -268,7 +268,8 @@ acpi_parse_entries_array(char *id, unsigned long table_size,
> for (i = 0; i < proc_num; i++) {
> if (entry->type != proc[i].id)
> continue;
> - if (!proc->handler || proc[i].handler(entry, table_end))
> + if (!proc[i].handler ||
> + proc[i].handler(entry, table_end))
> return -EINVAL;
>
> proc->count++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web