Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232262 > unrolled thread

[PATCH 6/6] drm/sti: Do not export symbols

Started byThierry Reding <thierry.reding@gmail.com>
First post2015-09-24 19:10 +0200
Last post2015-10-05 10:30 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 6/6] drm/sti: Do not export symbols Thierry Reding <thierry.reding@gmail.com> - 2015-09-24 19:10 +0200
    Re: [PATCH 6/6] drm/sti: Do not export symbols Vincent ABRIOU <vincent.abriou@st.com> - 2015-10-05 10:30 +0200

#1232262 — [PATCH 6/6] drm/sti: Do not export symbols

FromThierry Reding <thierry.reding@gmail.com>
Date2015-09-24 19:10 +0200
Subject[PATCH 6/6] drm/sti: Do not export symbols
Message-ID<qcibT-Sv-13@gated-at.bofh.it>
From: Thierry Reding <treding@nvidia.com>

None of these exported symbols are used outside of the drm-sti driver,
so there is no reason to export them.

Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Vincent Abriou <vincent.abriou@st.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/sti/sti_crtc.c  | 3 ---
 drivers/gpu/drm/sti/sti_mixer.c | 1 -
 drivers/gpu/drm/sti/sti_plane.c | 3 ---
 drivers/gpu/drm/sti/sti_vtg.c   | 6 ------
 4 files changed, 13 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
index 87bb4096b9d7..342d8a617c6f 100644
--- a/drivers/gpu/drm/sti/sti_crtc.c
+++ b/drivers/gpu/drm/sti/sti_crtc.c
@@ -318,7 +318,6 @@ int sti_crtc_enable_vblank(struct drm_device *dev, unsigned int pipe)
 
 	return 0;
 }
-EXPORT_SYMBOL(sti_crtc_enable_vblank);
 
 void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe)
 {
@@ -339,7 +338,6 @@ void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe)
 		compo->mixer[pipe]->pending_event = NULL;
 	}
 }
-EXPORT_SYMBOL(sti_crtc_disable_vblank);
 
 static struct drm_crtc_funcs sti_crtc_funcs = {
 	.set_config = drm_atomic_helper_set_config,
@@ -360,7 +358,6 @@ bool sti_crtc_is_main(struct drm_crtc *crtc)
 
 	return false;
 }
-EXPORT_SYMBOL(sti_crtc_is_main);
 
 int sti_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer,
 		  struct drm_plane *primary, struct drm_plane *cursor)
diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
index 0182e9365004..4c18b50d71c5 100644
--- a/drivers/gpu/drm/sti/sti_mixer.c
+++ b/drivers/gpu/drm/sti/sti_mixer.c
@@ -58,7 +58,6 @@ const char *sti_mixer_to_str(struct sti_mixer *mixer)
 		return "<UNKNOWN MIXER>";
 	}
 }
-EXPORT_SYMBOL(sti_mixer_to_str);
 
 static inline u32 sti_mixer_reg_read(struct sti_mixer *mixer, u32 reg_id)
 {
diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c
index d5c5e91f2956..2e5c751910c5 100644
--- a/drivers/gpu/drm/sti/sti_plane.c
+++ b/drivers/gpu/drm/sti/sti_plane.c
@@ -42,7 +42,6 @@ const char *sti_plane_to_str(struct sti_plane *plane)
 		return "<UNKNOWN PLANE>";
 	}
 }
-EXPORT_SYMBOL(sti_plane_to_str);
 
 static void sti_plane_destroy(struct drm_plane *drm_plane)
 {
@@ -108,7 +107,6 @@ void sti_plane_init_property(struct sti_plane *plane,
 			 plane->drm_plane.base.id,
 			 sti_plane_to_str(plane), plane->zorder);
 }
-EXPORT_SYMBOL(sti_plane_init_property);
 
 struct drm_plane_funcs sti_plane_helpers_funcs = {
 	.update_plane = drm_atomic_helper_update_plane,
@@ -119,4 +117,3 @@ struct drm_plane_funcs sti_plane_helpers_funcs = {
 	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
 	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
 };
-EXPORT_SYMBOL(sti_plane_helpers_funcs);
diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
index d8bd8b76b1fa..d56630c60039 100644
--- a/drivers/gpu/drm/sti/sti_vtg.c
+++ b/drivers/gpu/drm/sti/sti_vtg.c
@@ -110,7 +110,6 @@ struct sti_vtg *of_vtg_find(struct device_node *np)
 	}
 	return NULL;
 }
-EXPORT_SYMBOL(of_vtg_find);
 
 static void vtg_reset(struct sti_vtg *vtg)
 {
@@ -242,7 +241,6 @@ void sti_vtg_set_config(struct sti_vtg *vtg,
 	else
 		vtg_enable_irq(vtg);
 }
-EXPORT_SYMBOL(sti_vtg_set_config);
 
 /**
  * sti_vtg_get_line_number
@@ -265,7 +263,6 @@ u32 sti_vtg_get_line_number(struct drm_display_mode mode, int y)
 
 	return start_line + y;
 }
-EXPORT_SYMBOL(sti_vtg_get_line_number);
 
 /**
  * sti_vtg_get_pixel_number
@@ -281,7 +278,6 @@ u32 sti_vtg_get_pixel_number(struct drm_display_mode mode, int x)
 {
 	return mode.htotal - mode.hsync_start + x;
 }
-EXPORT_SYMBOL(sti_vtg_get_pixel_number);
 
 int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb,
 			    struct drm_crtc *crtc)
@@ -292,7 +288,6 @@ int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb,
 	vtg->crtc = crtc;
 	return raw_notifier_chain_register(&vtg->notifier_list, nb);
 }
-EXPORT_SYMBOL(sti_vtg_register_client);
 
 int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
 {
@@ -301,7 +296,6 @@ int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
 
 	return raw_notifier_chain_unregister(&vtg->notifier_list, nb);
 }
-EXPORT_SYMBOL(sti_vtg_unregister_client);
 
 static irqreturn_t vtg_irq_thread(int irq, void *arg)
 {
-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1239353

FromVincent ABRIOU <vincent.abriou@st.com>
Date2015-10-05 10:30 +0200
Message-ID<qg9jJ-1RW-39@gated-at.bofh.it>
In reply to#1232262
Hi Thierry,

Ack-by: Vincent Abriou <vincent.abriou@st.com>

BR
Vincent

On 09/24/2015 07:02 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> None of these exported symbols are used outside of the drm-sti driver,
> so there is no reason to export them.
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>   drivers/gpu/drm/sti/sti_crtc.c  | 3 ---
>   drivers/gpu/drm/sti/sti_mixer.c | 1 -
>   drivers/gpu/drm/sti/sti_plane.c | 3 ---
>   drivers/gpu/drm/sti/sti_vtg.c   | 6 ------
>   4 files changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index 87bb4096b9d7..342d8a617c6f 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -318,7 +318,6 @@ int sti_crtc_enable_vblank(struct drm_device *dev, unsigned int pipe)
>
>   	return 0;
>   }
> -EXPORT_SYMBOL(sti_crtc_enable_vblank);
>
>   void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe)
>   {
> @@ -339,7 +338,6 @@ void sti_crtc_disable_vblank(struct drm_device *drm_dev, unsigned int pipe)
>   		compo->mixer[pipe]->pending_event = NULL;
>   	}
>   }
> -EXPORT_SYMBOL(sti_crtc_disable_vblank);
>
>   static struct drm_crtc_funcs sti_crtc_funcs = {
>   	.set_config = drm_atomic_helper_set_config,
> @@ -360,7 +358,6 @@ bool sti_crtc_is_main(struct drm_crtc *crtc)
>
>   	return false;
>   }
> -EXPORT_SYMBOL(sti_crtc_is_main);
>
>   int sti_crtc_init(struct drm_device *drm_dev, struct sti_mixer *mixer,
>   		  struct drm_plane *primary, struct drm_plane *cursor)
> diff --git a/drivers/gpu/drm/sti/sti_mixer.c b/drivers/gpu/drm/sti/sti_mixer.c
> index 0182e9365004..4c18b50d71c5 100644
> --- a/drivers/gpu/drm/sti/sti_mixer.c
> +++ b/drivers/gpu/drm/sti/sti_mixer.c
> @@ -58,7 +58,6 @@ const char *sti_mixer_to_str(struct sti_mixer *mixer)
>   		return "<UNKNOWN MIXER>";
>   	}
>   }
> -EXPORT_SYMBOL(sti_mixer_to_str);
>
>   static inline u32 sti_mixer_reg_read(struct sti_mixer *mixer, u32 reg_id)
>   {
> diff --git a/drivers/gpu/drm/sti/sti_plane.c b/drivers/gpu/drm/sti/sti_plane.c
> index d5c5e91f2956..2e5c751910c5 100644
> --- a/drivers/gpu/drm/sti/sti_plane.c
> +++ b/drivers/gpu/drm/sti/sti_plane.c
> @@ -42,7 +42,6 @@ const char *sti_plane_to_str(struct sti_plane *plane)
>   		return "<UNKNOWN PLANE>";
>   	}
>   }
> -EXPORT_SYMBOL(sti_plane_to_str);
>
>   static void sti_plane_destroy(struct drm_plane *drm_plane)
>   {
> @@ -108,7 +107,6 @@ void sti_plane_init_property(struct sti_plane *plane,
>   			 plane->drm_plane.base.id,
>   			 sti_plane_to_str(plane), plane->zorder);
>   }
> -EXPORT_SYMBOL(sti_plane_init_property);
>
>   struct drm_plane_funcs sti_plane_helpers_funcs = {
>   	.update_plane = drm_atomic_helper_update_plane,
> @@ -119,4 +117,3 @@ struct drm_plane_funcs sti_plane_helpers_funcs = {
>   	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
>   	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
>   };
> -EXPORT_SYMBOL(sti_plane_helpers_funcs);
> diff --git a/drivers/gpu/drm/sti/sti_vtg.c b/drivers/gpu/drm/sti/sti_vtg.c
> index d8bd8b76b1fa..d56630c60039 100644
> --- a/drivers/gpu/drm/sti/sti_vtg.c
> +++ b/drivers/gpu/drm/sti/sti_vtg.c
> @@ -110,7 +110,6 @@ struct sti_vtg *of_vtg_find(struct device_node *np)
>   	}
>   	return NULL;
>   }
> -EXPORT_SYMBOL(of_vtg_find);
>
>   static void vtg_reset(struct sti_vtg *vtg)
>   {
> @@ -242,7 +241,6 @@ void sti_vtg_set_config(struct sti_vtg *vtg,
>   	else
>   		vtg_enable_irq(vtg);
>   }
> -EXPORT_SYMBOL(sti_vtg_set_config);
>
>   /**
>    * sti_vtg_get_line_number
> @@ -265,7 +263,6 @@ u32 sti_vtg_get_line_number(struct drm_display_mode mode, int y)
>
>   	return start_line + y;
>   }
> -EXPORT_SYMBOL(sti_vtg_get_line_number);
>
>   /**
>    * sti_vtg_get_pixel_number
> @@ -281,7 +278,6 @@ u32 sti_vtg_get_pixel_number(struct drm_display_mode mode, int x)
>   {
>   	return mode.htotal - mode.hsync_start + x;
>   }
> -EXPORT_SYMBOL(sti_vtg_get_pixel_number);
>
>   int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb,
>   			    struct drm_crtc *crtc)
> @@ -292,7 +288,6 @@ int sti_vtg_register_client(struct sti_vtg *vtg, struct notifier_block *nb,
>   	vtg->crtc = crtc;
>   	return raw_notifier_chain_register(&vtg->notifier_list, nb);
>   }
> -EXPORT_SYMBOL(sti_vtg_register_client);
>
>   int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
>   {
> @@ -301,7 +296,6 @@ int sti_vtg_unregister_client(struct sti_vtg *vtg, struct notifier_block *nb)
>
>   	return raw_notifier_chain_unregister(&vtg->notifier_list, nb);
>   }
> -EXPORT_SYMBOL(sti_vtg_unregister_client);
>
>   static irqreturn_t vtg_irq_thread(int irq, void *arg)
>   {
>--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web