Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1231982 > unrolled thread

[PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation

Started byhuangdaode <huangdaode@hisilicon.com>
First post2015-09-24 11:50 +0200
Last post2015-09-24 20:00 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation huangdaode <huangdaode@hisilicon.com> - 2015-09-24 11:50 +0200
    Re: [PATCH net-next] net: Fix Hisilicon Network Subsystem Support  Compilation David Miller <davem@davemloft.net> - 2015-09-24 20:00 +0200

#1231982 — [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation

Fromhuangdaode <huangdaode@hisilicon.com>
Date2015-09-24 11:50 +0200
Subject[PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation
Message-ID<qcbk5-7Hr-1@gated-at.bofh.it>
This patch fixes the compilation error with arm allmodconfig, this error
generated due to unavailability of readq on 32-bit platform which was
found during net-next daily compilation

Signed-off-by: huangdaode <huangdaode@hisilicon.com>
Singed-off-by: yankejian <yankejian@huawei.com>
---
 drivers/net/ethernet/hisilicon/Kconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/hisilicon/Kconfig b/drivers/net/ethernet/hisilicon/Kconfig
index 165b5a8..04d5f8f 100644
--- a/drivers/net/ethernet/hisilicon/Kconfig
+++ b/drivers/net/ethernet/hisilicon/Kconfig
@@ -41,6 +41,7 @@ config HNS_MDIO
 
 config HNS
 	tristate "Hisilicon Network Subsystem Support (Framework)"
+	depends on ARM64
 	---help---
 	  This selects the framework support for Hisilicon Network Subsystem. It
 	  is needed by any driver which provides HNS acceleration engine or make
@@ -50,6 +51,7 @@ config HNS_DSAF
 	tristate "Hisilicon HNS DSAF device Support"
 	select HNS
 	select HNS_MDIO
+	depends on ARM64
 	---help---
 	  This selects the DSAF (Distributed System Area Frabric) network
 	  acceleration engine support. The engine is used in Hisilicon hip05,
@@ -59,6 +61,7 @@ config HNS_ENET
 	tristate "Hisilicon HNS Ethernet Device Support"
 	select PHYLIB
 	select HNS
+	depends on ARM64
 	---help---
 	  This selects the general ethernet driver for HNS.  This module make
 	  use of any HNS AE driver, such as HNS_DSAF
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1232310 — Re: [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation

FromDavid Miller <davem@davemloft.net>
Date2015-09-24 20:00 +0200
SubjectRe: [PATCH net-next] net: Fix Hisilicon Network Subsystem Support Compilation
Message-ID<qciYi-1MZ-1@gated-at.bofh.it>
In reply to#1231982
From: huangdaode <huangdaode@hisilicon.com>
Date: Thu, 24 Sep 2015 17:54:09 +0800

> This patch fixes the compilation error with arm allmodconfig, this error
> generated due to unavailability of readq on 32-bit platform which was
> found during net-next daily compilation
> 
> Signed-off-by: huangdaode <huangdaode@hisilicon.com>
> Singed-off-by: yankejian <yankejian@huawei.com>

This is not necessaily the right fix, sorry.

I'd rather this driver be available to compile on as many
configurations as possible, to increase build coverage.

There is a standard way to make readq available on 32-bit platforms
and I want you to do research into how that works and how you can thus
make your driver build even on 32-bit targets.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web