Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230495 > unrolled thread

Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX errata workarounds

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX  errata workarounds Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 19:00 +0200
    Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX  errata workarounds Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 20:10 +0200
      Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX  errata workarounds Will Deacon <will.deacon@arm.com> - 2015-09-22 20:30 +0200
        Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX  errata workarounds Marc Zyngier <marc.zyngier@arm.com> - 2015-09-22 21:50 +0200
          Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX  errata workarounds Catalin Marinas <catalin.marinas@arm.com> - 2015-09-24 19:00 +0200

#1230495 — Re: [PATCH v5 0/6] irqchip, gicv3: Updates and Cavium ThunderX errata workarounds

On Mon, 21 Sep 2015 22:58:33 +0200
Robert Richter <rric@kernel.org> wrote:

> From: Robert Richter <rrichter@cavium.com>
> 
> This patch series adds gicv3 updates and workarounds for HW errata in
> Cavium's ThunderX GICV3.
> 
> The patches has been rebased onto 4.3-rc1. Note that there are two
> important fixes. See below for all changes.
> 
> The first one is an unchanged resubmission of a patch from a gicv3
> series I sent a while ago.
> 
> The next patches implement the workarounds for ThunderX's gicv3. Patch
> #2 implements the cpu workaround for gicv3 on ThunderX. Patch #3 is a
> prerequisit for patch #5. Patch #4 adds generic code to parse the hw
> revision provided by an IIDR. This patch is used for the implementa-
> tion of the actual gicv3-its workaround in #5. Patch #6 updates to the
> new jump label API.
> 
> All current review comments addressed so far with v5

Catalin, Will: assuming you don't have any objection to this series,
how do you want to deal with patch 2?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1230622

On Tue, 22 Sep 2015 17:57:01 +0100
Marc Zyngier <marc.zyngier@arm.com> wrote:

[Duh. Now with Will and Catalin on CC]

> On Mon, 21 Sep 2015 22:58:33 +0200
> Robert Richter <rric@kernel.org> wrote:
> 
> > From: Robert Richter <rrichter@cavium.com>
> > 
> > This patch series adds gicv3 updates and workarounds for HW errata in
> > Cavium's ThunderX GICV3.
> > 
> > The patches has been rebased onto 4.3-rc1. Note that there are two
> > important fixes. See below for all changes.
> > 
> > The first one is an unchanged resubmission of a patch from a gicv3
> > series I sent a while ago.
> > 
> > The next patches implement the workarounds for ThunderX's gicv3. Patch
> > #2 implements the cpu workaround for gicv3 on ThunderX. Patch #3 is a
> > prerequisit for patch #5. Patch #4 adds generic code to parse the hw
> > revision provided by an IIDR. This patch is used for the implementa-
> > tion of the actual gicv3-its workaround in #5. Patch #6 updates to the
> > new jump label API.
> > 
> > All current review comments addressed so far with v5
> 
> Catalin, Will: assuming you don't have any objection to this series,
> how do you want to deal with patch 2?
> 
> Thanks,
> 
> 	M.



-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1230668

On Tue, Sep 22, 2015 at 07:09:32PM +0100, Marc Zyngier wrote:
> On Tue, 22 Sep 2015 17:57:01 +0100
> Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
> [Duh. Now with Will and Catalin on CC]
> 
> > On Mon, 21 Sep 2015 22:58:33 +0200
> > Robert Richter <rric@kernel.org> wrote:
> > 
> > > From: Robert Richter <rrichter@cavium.com>
> > > 
> > > This patch series adds gicv3 updates and workarounds for HW errata in
> > > Cavium's ThunderX GICV3.
> > > 
> > > The patches has been rebased onto 4.3-rc1. Note that there are two
> > > important fixes. See below for all changes.
> > > 
> > > The first one is an unchanged resubmission of a patch from a gicv3
> > > series I sent a while ago.
> > > 
> > > The next patches implement the workarounds for ThunderX's gicv3. Patch
> > > #2 implements the cpu workaround for gicv3 on ThunderX. Patch #3 is a
> > > prerequisit for patch #5. Patch #4 adds generic code to parse the hw
> > > revision provided by an IIDR. This patch is used for the implementa-
> > > tion of the actual gicv3-its workaround in #5. Patch #6 updates to the
> > > new jump label API.
> > > 
> > > All current review comments addressed so far with v5
> > 
> > Catalin, Will: assuming you don't have any objection to this series,
> > how do you want to deal with patch 2?

What are the actual dependencies here? AFAICT, the series is addressing
multiple errata, so would it be possible to make the arm64 bits somewhat
independent from the gic parts?

Also, I assume this is targetting 4.4?

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1230867

On Tue, 22 Sep 2015 19:27:26 +0100
Will Deacon <will.deacon@arm.com> wrote:

> On Tue, Sep 22, 2015 at 07:09:32PM +0100, Marc Zyngier wrote:
> > On Tue, 22 Sep 2015 17:57:01 +0100
> > Marc Zyngier <marc.zyngier@arm.com> wrote:
> > 
> > [Duh. Now with Will and Catalin on CC]
> > 
> > > On Mon, 21 Sep 2015 22:58:33 +0200
> > > Robert Richter <rric@kernel.org> wrote:
> > > 
> > > > From: Robert Richter <rrichter@cavium.com>
> > > > 
> > > > This patch series adds gicv3 updates and workarounds for HW errata in
> > > > Cavium's ThunderX GICV3.
> > > > 
> > > > The patches has been rebased onto 4.3-rc1. Note that there are two
> > > > important fixes. See below for all changes.
> > > > 
> > > > The first one is an unchanged resubmission of a patch from a gicv3
> > > > series I sent a while ago.
> > > > 
> > > > The next patches implement the workarounds for ThunderX's gicv3. Patch
> > > > #2 implements the cpu workaround for gicv3 on ThunderX. Patch #3 is a
> > > > prerequisit for patch #5. Patch #4 adds generic code to parse the hw
> > > > revision provided by an IIDR. This patch is used for the implementa-
> > > > tion of the actual gicv3-its workaround in #5. Patch #6 updates to the
> > > > new jump label API.
> > > > 
> > > > All current review comments addressed so far with v5
> > > 
> > > Catalin, Will: assuming you don't have any objection to this series,
> > > how do you want to deal with patch 2?
> 
> What are the actual dependencies here? AFAICT, the series is addressing
> multiple errata, so would it be possible to make the arm64 bits somewhat
> independent from the gic parts?

Patch 2 could be split into an arm64-specific part and a gic part, with
a bit of #ifdef-ery in gicv3_enable_quirks().

> Also, I assume this is targetting 4.4?

Up to you, really. It is not a regression, but it would still be nice
to have 4.3 working reliably on this HW.

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1232255

On Tue, Sep 22, 2015 at 08:41:34PM +0100, Marc Zyngier wrote:
> On Tue, 22 Sep 2015 19:27:26 +0100
> Will Deacon <will.deacon@arm.com> wrote:
> > On Tue, Sep 22, 2015 at 07:09:32PM +0100, Marc Zyngier wrote:
> > > > Catalin, Will: assuming you don't have any objection to this series,
> > > > how do you want to deal with patch 2?
> > 
> > What are the actual dependencies here? AFAICT, the series is addressing
> > multiple errata, so would it be possible to make the arm64 bits somewhat
> > independent from the gic parts?
> 
> Patch 2 could be split into an arm64-specific part and a gic part, with
> a bit of #ifdef-ery in gicv3_enable_quirks().

The arm64 part without CONFIG_CAVIUM_ERRATUM_* wouldn't cause any
problem. Anyway, I'm not too bothered about separate patches, I think
the whole series could go in via a single tree (irqchip).

> > Also, I assume this is targetting 4.4?
> 
> Up to you, really. It is not a regression, but it would still be nice
> to have 4.3 working reliably on this HW.

I don't have any objection to this patchset but it looks like quite a
lot of code for 4.3 and it is not a regression. Anyway, for the
arch/arm64 bits:

Acked-by: Catalin Marinas <catalin.marinas@arm.com>

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web