Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1231685 > unrolled thread
| Started by | Punit Vara <punitvara@gmail.com> |
|---|---|
| First post | 2015-09-23 22:00 +0200 |
| Last post | 2015-09-24 18:30 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments Punit Vara <punitvara@gmail.com> - 2015-09-23 22:00 +0200
Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-24 08:00 +0200
Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments punit vara <punitvara@gmail.com> - 2015-09-24 18:30 +0200
| From | Punit Vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-09-23 22:00 +0200 |
| Subject | [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments |
| Message-ID | <qbYmS-5Gt-13@gated-at.bofh.it> |
This patch is to the rtl871x_io.h file that fixes up following warning
reported by checkpatch.pl :
Signed-off-by: Punit Vara <punitvara@gmail.com>
---
drivers/staging/rtl8712/rtl871x_io.h | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_io.h b/drivers/staging/rtl8712/rtl871x_io.h
index 070cc03..9313943 100644
--- a/drivers/staging/rtl8712/rtl871x_io.h
+++ b/drivers/staging/rtl8712/rtl871x_io.h
@@ -48,10 +48,9 @@
#define _IO_SYNC_ BIT(13)
#define _IO_CMDMASK_ (0x1F80)
-/*
- For prompt mode accessing, caller shall free io_req
- Otherwise, io_handler will free io_req
-*/
+/* For prompt mode accessing, caller shall free io_req
+ * Otherwise, io_handler will free io_req
+ */
/* IO STATUS TYPE */
#define _IO_ERR_ BIT(2)
#define _IO_SUCCESS_ BIT(1)
@@ -68,9 +67,7 @@
#define IO_WR32_ASYNC (_IO_WRITE_ | _IO_WORD_)
#define IO_WR16_ASYNC (_IO_WRITE_ | _IO_HW_)
#define IO_WR8_ASYNC (_IO_WRITE_ | _IO_BYTE_)
-/*
- Only Sync. burst accessing is provided.
-*/
+/* Only Sync. burst accessing is provided.*/
#define IO_WR_BURST(x) (IO_WRITE_ | _IO_SYNC_ | _IO_BURST_ | \
((x) & _IOSZ_MASK_))
#define IO_RD_BURST(x) (_IO_SYNC_ | _IO_BURST_ | ((x) & _IOSZ_MASK_))
@@ -217,9 +214,7 @@ struct reg_protocol_wt {
#endif
};
-/*
-Below is the data structure used by _io_handler
-*/
+/* Below is the data structure used by _io_handler */
struct io_queue {
spinlock_t lock;
--
2.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Date | 2015-09-24 08:00 +0200 |
| Subject | Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments |
| Message-ID | <qc7Jw-2vR-1@gated-at.bofh.it> |
| In reply to | #1231685 |
On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote: > This patch is to the rtl871x_io.h file that fixes up following warning > reported by checkpatch.pl : > > Signed-off-by: Punit Vara <punitvara@gmail.com> > --- You missed copying the warning after mentioning "following warning" in your commit message. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | punit vara <punitvara@gmail.com> |
|---|---|
| Date | 2015-09-24 18:30 +0200 |
| Subject | Re: [PATCH] Staging: rtl8712: rtl871x_io.h: Coding style warning fix for block comments |
| Message-ID | <qchzb-8ls-1@gated-at.bofh.it> |
| In reply to | #1231863 |
On Thu, Sep 24, 2015 at 11:25 AM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > On Thu, Sep 24, 2015 at 01:22:33AM +0530, Punit Vara wrote: >> This patch is to the rtl871x_io.h file that fixes up following warning >> reported by checkpatch.pl : >> >> Signed-off-by: Punit Vara <punitvara@gmail.com> >> --- > You missed copying the warning after mentioning "following warning" in > your commit message. > > regards > sudip Surely I will resend it .First let Greg say whether I have to send in series or is it okay as it is. This was first time I have tried to fix so many warnings in different problems. Whatever patch having issues I would be happy to resend. Thank you for feedback and evaluation. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web