Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1232234 > unrolled thread
| Started by | Rob Herring <robh@kernel.org> |
|---|---|
| First post | 2015-09-24 18:20 +0200 |
| Last post | 2015-09-30 18:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver Rob Herring <robh@kernel.org> - 2015-09-24 18:20 +0200
Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver Felipe Balbi <balbi@ti.com> - 2015-09-30 18:20 +0200
| From | Rob Herring <robh@kernel.org> |
|---|---|
| Date | 2015-09-24 18:20 +0200 |
| Subject | Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver |
| Message-ID | <qchpw-8a5-17@gated-at.bofh.it> |
On Thu, Sep 24, 2015 at 4:26 AM, Subbaraya Sundeep Bhatta
<subbaraya.sundeep.bhatta@xilinx.com> wrote:
> Hi Peter,
>
>> -----Original Message-----
>> From: Peter Chen [mailto:peter.chen@freescale.com]
>> Sent: Thursday, September 24, 2015 2:41 PM
>> To: Subbaraya Sundeep Bhatta
>> Cc: balbi@ti.com; devicetree@vger.kernel.org; kishon@ti.com;
>> gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
>> kernel@vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta;
>> linux-arm-kernel@lists.infradead.org
>> Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver
>>
>> On Wed, Sep 23, 2015 at 06:24:01PM +0530, Subbaraya Sundeep Bhatta
>> wrote:
>> > This patch adds binding doc info for generic ULPI PHYs platform
>> > driver.
>> >
>> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
>> > ---
>> > .../devicetree/bindings/usb/ulpi-platform-phy.txt | 34
>> ++++++++++++++++++++
>> > 1 files changed, 34 insertions(+), 0 deletions(-) create mode 100644
>> > Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
>> >
>> > diff --git
>> > a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
>> > b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
>> > new file mode 100644
>> > index 0000000..7b8cbb4
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
>> > @@ -0,0 +1,34 @@
>> > +Platform driver for generic ULPI PHYs
>> > +
>> > +Required properties:
>> > +- compatible : Should be "ulpi-phy"
>> > +- reg : Physical base address and size of the USB
>> > + controller registers map to which this PHY
>> > + is connected.
>> > +- view-port : Should contain viewport register offset of the
>> > + USB controller to which this PHY is connected Optional
>> > +properties:
>> > +- drv-vbus : required if turning VBUS on/off has to be driven
>> > + by writing to PHY. This feature depends on board
>> > + design.
>> > +
>> > +Example:
>> > +Below example shows the PHY binding for Chipidea USB controller which
>> > +has ulpi viewport register at 0x0170
>> > +
>> > + usb_phy0: phy0 {
>> > + compatible = "ulpi-phy";
>> > + reg = <0xe0002000 0x1000>;
>> > + view-port = <0x0170>;
>> > + drv-vbus;
>> > + };
>> > +
>> > + usb0: usb@e0002000 {
>> > + compatible = "chipidea,usb2";
>> > + interrupt-parent = <&intc>;
>> > + interrupts = <0 21 4>;
>> > + reg = <0xe0002000 0x1000>;
>>
>> Although just call devm_ioremap twice for the same register region does not
>> cause any errors, I am not sure if it will has other potential problems. Cc: arm
>> list.
>
> Yes Peter I was also in doubt to call devm_ioremap twice for same register region.
> devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for
> adding arm-list.
Don't put overlapping resources in the DT. Having 2 drivers accessing
the same registers is not a clean or safe design.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Felipe Balbi <balbi@ti.com> |
|---|---|
| Date | 2015-09-30 18:20 +0200 |
| Message-ID | <qesgQ-1GU-69@gated-at.bofh.it> |
| In reply to | #1232234 |
[Multipart message — attachments visible in raw view] — view raw
On Thu, Sep 24, 2015 at 11:18:01AM -0500, Rob Herring wrote:
> On Thu, Sep 24, 2015 at 4:26 AM, Subbaraya Sundeep Bhatta
> <subbaraya.sundeep.bhatta@xilinx.com> wrote:
> > Hi Peter,
> >
> >> -----Original Message-----
> >> From: Peter Chen [mailto:peter.chen@freescale.com]
> >> Sent: Thursday, September 24, 2015 2:41 PM
> >> To: Subbaraya Sundeep Bhatta
> >> Cc: balbi@ti.com; devicetree@vger.kernel.org; kishon@ti.com;
> >> gregkh@linuxfoundation.org; linux-usb@vger.kernel.org; linux-
> >> kernel@vger.kernel.org; Punnaiah Choudary Kalluri; Subbaraya Sundeep Bhatta;
> >> linux-arm-kernel@lists.infradead.org
> >> Subject: Re: [RFC PATCH 1/2] usb: doc: Add bindings for ULPI platform driver
> >>
> >> On Wed, Sep 23, 2015 at 06:24:01PM +0530, Subbaraya Sundeep Bhatta
> >> wrote:
> >> > This patch adds binding doc info for generic ULPI PHYs platform
> >> > driver.
> >> >
> >> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> >> > ---
> >> > .../devicetree/bindings/usb/ulpi-platform-phy.txt | 34
> >> ++++++++++++++++++++
> >> > 1 files changed, 34 insertions(+), 0 deletions(-) create mode 100644
> >> > Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> >> >
> >> > diff --git
> >> > a/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> >> > b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> >> > new file mode 100644
> >> > index 0000000..7b8cbb4
> >> > --- /dev/null
> >> > +++ b/Documentation/devicetree/bindings/usb/ulpi-platform-phy.txt
> >> > @@ -0,0 +1,34 @@
> >> > +Platform driver for generic ULPI PHYs
> >> > +
> >> > +Required properties:
> >> > +- compatible : Should be "ulpi-phy"
> >> > +- reg : Physical base address and size of the USB
> >> > + controller registers map to which this PHY
> >> > + is connected.
> >> > +- view-port : Should contain viewport register offset of the
> >> > + USB controller to which this PHY is connected Optional
> >> > +properties:
> >> > +- drv-vbus : required if turning VBUS on/off has to be driven
> >> > + by writing to PHY. This feature depends on board
> >> > + design.
> >> > +
> >> > +Example:
> >> > +Below example shows the PHY binding for Chipidea USB controller which
> >> > +has ulpi viewport register at 0x0170
> >> > +
> >> > + usb_phy0: phy0 {
> >> > + compatible = "ulpi-phy";
> >> > + reg = <0xe0002000 0x1000>;
> >> > + view-port = <0x0170>;
> >> > + drv-vbus;
> >> > + };
> >> > +
> >> > + usb0: usb@e0002000 {
> >> > + compatible = "chipidea,usb2";
> >> > + interrupt-parent = <&intc>;
> >> > + interrupts = <0 21 4>;
> >> > + reg = <0xe0002000 0x1000>;
> >>
> >> Although just call devm_ioremap twice for the same register region does not
> >> cause any errors, I am not sure if it will has other potential problems. Cc: arm
> >> list.
> >
> > Yes Peter I was also in doubt to call devm_ioremap twice for same register region.
> > devm_ioremap_resource complained hence modified to devm_ioremap. Thanks for
> > adding arm-list.
>
> Don't put overlapping resources in the DT. Having 2 drivers accessing
> the same registers is not a clean or safe design.
thanks, saves me the trouble of saying the same thing.
Bottom line, if devm_ioremap_resource() fails, you're wrong. Just fix
your driver and move on.
--
balbi
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web