Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1232071 > unrolled thread

Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Tomi Valkeinen <tomi.valkeinen@ti.com> - 2015-09-24 14:00 +0200
    Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-09-25 15:50 +0200
      Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging Mike Rapoport <mike.rapoport@gmail.com> - 2015-09-27 06:50 +0200

#1232071 — Re: [PATCH v2 1/3] staging: sm7xxfb: move sm712fb out of staging

[Multipart message — attachments visible in raw view] — view raw

On 02/09/15 15:48, Sudip Mukherjee wrote:

> Now I am getting confused. :(
> Since this has already been merged I guess we need to maintain it now.

Oh, ok. I thought it was still in staging. I haven't been able to follow
the list properly lately...

Well, in theory we could still revert it, as it's only -rc2.

> So then should I fix the things you pointed out or should i instead
> give more priority to the DRM driver and fix these things later?

Is there a public datasheet for the HW?

The driver as it is now is quite horrible. Huge tables of raw data,
written directly to the registers. Lots of magic numbers all around.
Even with a datasheet, presuming it's public and it contains all those
values, the driver is rather unmaintainable.

All those need to be sorted out for the DRM driver anyway, so maybe it's
better to clean up the fb driver first.

> And, just to inform you, there are two more fbdev drivers in staging,
> staging/sm750fb and staging/fbtft. And the ultimate goal of any driver

Thanks for pointing this out, I need to check those and think how to
proceed.

 Tomi

[toc] | [next] | [standalone]

#1232834

On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
> 
> On 02/09/15 15:48, Sudip Mukherjee wrote:
> 
<snip>
> 
> Is there a public datasheet for the HW?
I could not find one in Silicon Motion website. I will try to find else
I can talk to them and keep it in my github. And can send you also if
you want.
> 
> The driver as it is now is quite horrible. Huge tables of raw data,
> written directly to the registers. Lots of magic numbers all around.
> Even with a datasheet, presuming it's public and it contains all those
> values, the driver is rather unmaintainable.
> 
> All those need to be sorted out for the DRM driver anyway, so maybe it's
> better to clean up the fb driver first.
Ok. I never looked at them to see how they can be made better. I will
see.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1233612

Hi Sudip,

On Fri, Sep 25, 2015 at 07:12:06PM +0530, Sudip Mukherjee wrote:
> On Thu, Sep 24, 2015 at 02:58:31PM +0300, Tomi Valkeinen wrote:
> > 
> > On 02/09/15 15:48, Sudip Mukherjee wrote:
> > 
> <snip>
> > 
> > Is there a public datasheet for the HW?
> I could not find one in Silicon Motion website. I will try to find else
> I can talk to them and keep it in my github. And can send you also if
> you want.

I'd appreciate sm750 datasheet, if you have one.

> > 
> > The driver as it is now is quite horrible. Huge tables of raw data,
> > written directly to the registers. Lots of magic numbers all around.
> > Even with a datasheet, presuming it's public and it contains all those
> > values, the driver is rather unmaintainable.
> > 
> > All those need to be sorted out for the DRM driver anyway, so maybe it's
> > better to clean up the fb driver first.
> Ok. I never looked at them to see how they can be made better. I will
> see.
> 
> regards
> sudip

--
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web