Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1232934 > unrolled thread

[PATCH] platform: x86: PMC IPC depends on ACPI

Started byLee Jones <lee.jones@linaro.org>
First post2015-09-25 18:40 +0200
Last post2015-10-03 19:00 +0200
Articles 3 — 3 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] platform: x86: PMC IPC depends on ACPI Lee Jones <lee.jones@linaro.org> - 2015-09-25 18:40 +0200
    Re: [PATCH] platform: x86: PMC IPC depends on ACPI Randy Dunlap <rdunlap@infradead.org> - 2015-09-26 04:00 +0200
      Re: [PATCH] platform: x86: PMC IPC depends on ACPI Darren Hart <dvhart@infradead.org> - 2015-10-03 19:00 +0200

#1232934 — [PATCH] platform: x86: PMC IPC depends on ACPI

FromLee Jones <lee.jones@linaro.org>
Date2015-09-25 18:40 +0200
Subject[PATCH] platform: x86: PMC IPC depends on ACPI
Message-ID<qcEcr-6SE-33@gated-at.bofh.it>
This patch solves:

on x86_64:

when CONFIG_ACPI is not enabled:

../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
    error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
        status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
        ^

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/platform/x86/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index c69bb70..744cb80 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -914,6 +914,7 @@ config PVPANIC
 
 config INTEL_PMC_IPC
 	tristate "Intel PMC IPC Driver"
+	depends on ACPI
 	---help---
 	This driver provides support for PMC control on some Intel platforms.
 	The PMC is an ARC processor which defines IPC commands for communication
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1233128

FromRandy Dunlap <rdunlap@infradead.org>
Date2015-09-26 04:00 +0200
Message-ID<qcMWl-2r2-1@gated-at.bofh.it>
In reply to#1232934
On 09/25/15 09:38, Lee Jones wrote:
> This patch solves:
> 
> on x86_64:
> 
> when CONFIG_ACPI is not enabled:
> 
> ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
> ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
>     error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
>         status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
>         ^
> 
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Works for me.  Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>


> ---
>  drivers/platform/x86/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index c69bb70..744cb80 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -914,6 +914,7 @@ config PVPANIC
>  
>  config INTEL_PMC_IPC
>  	tristate "Intel PMC IPC Driver"
> +	depends on ACPI
>  	---help---
>  	This driver provides support for PMC control on some Intel platforms.
>  	The PMC is an ARC processor which defines IPC commands for communication
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1238956

FromDarren Hart <dvhart@infradead.org>
Date2015-10-03 19:00 +0200
Message-ID<qfyka-7FN-13@gated-at.bofh.it>
In reply to#1233128
On Fri, Sep 25, 2015 at 06:53:56PM -0700, Randy Dunlap wrote:
> On 09/25/15 09:38, Lee Jones wrote:
> > This patch solves:
> > 
> > on x86_64:
> > 
> > when CONFIG_ACPI is not enabled:
> > 
> > ../drivers/mfd/intel_soc_pmic_bxtwc.c: In function 'bxtwc_probe':
> > ../drivers/mfd/intel_soc_pmic_bxtwc.c:342:2:
> >     error: implicit declaration of function 'acpi_evaluate_integer' [-Werror=implicit-function-declaration]
> >         status = acpi_evaluate_integer(handle, "_HRV", NULL, &hrv);
> >         ^
> > 
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> 
> Works for me.  Thanks.
> 
> Acked-by: Randy Dunlap <rdunlap@infradead.org>

Lee,

Since this appears to be the result of a patch applied to the mfd tree, would
you like to pick up this patch?

Acked-by: Darren Hart <dvhart@linux.intel.com>


-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web