Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1232594 > unrolled thread
| Started by | Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> |
|---|---|
| First post | 2015-09-25 08:40 +0200 |
| Last post | 2015-09-28 10:40 +0200 |
| Articles | 5 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 00/12] mtd: nand_bbt: introduce independent nand BBT Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> - 2015-09-25 08:40 +0200
Re: [PATCH 00/12] mtd: nand_bbt: introduce independent nand BBT Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-09-25 09:00 +0200
RE: [PATCH 00/12] mtd: nand_bbt: introduce independent nand BBT Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> - 2015-09-25 10:40 +0200
Re: [PATCH 12/12] mtd: nand-bbt: move nand_bbt.c to mtd folder Brian Norris <computersforpeace@gmail.com> - 2015-09-25 19:40 +0200
RE: [PATCH 12/12] mtd: nand-bbt: move nand_bbt.c to mtd folder Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> - 2015-09-28 10:40 +0200
| From | Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> |
|---|---|
| Date | 2015-09-25 08:40 +0200 |
| Subject | [PATCH 00/12] mtd: nand_bbt: introduce independent nand BBT |
| Message-ID | <qcuPM-1Sp-11@gated-at.bofh.it> |
Q3VycmVudGx5IG5hbmRfYmJ0LmMgaXMgdGllZCB3aXRoIHN0cnVjdCBuYW5kX2NoaXAsIGFuZCBp dCBtYWtlcyBvdGhlcg0KTkFORCBmYW1pbHkgY2hpcHMgaGFyZCB0byB1c2UgbmFuZF9iYnQuYy4g TWF5YmUgaXQncyB0aGUgcmVhc29uIHdoeQ0Kb25lbmFuZCBoYXMgb3duIGJidChvbmVuYW5kX2Ji dC5jKS4NCg0KU2VwYXJhdGUgc3RydWN0IG5hbmRfY2hpcCBmcm9tIEJCVCBjb2RlIGNhbiBtYWtl IGN1cnJlbnQgQkJUIHNoYXJlYWJsZS4NCldlIGNyZWF0ZSBzdHJ1Y3QgbmFuZF9iYnQgdG8gdGFr ZSBwbGFjZSBvZiBuYW5kX2NoaXAgaW4gbmFuZF9iYnQuYy4NClN0cnVjdCBuYW5kX2JidCBjb250 YWlucyBhbGwgdGhlIGluZm9ybWF0aW9uIEJCVCBuZWVkZWQgZnJvbSBvdXRzaWRlIGFuZA0KaXQg c2hvdWxkIGJlIGVtYmVkZGVkIGludG8gTkFORCBmYW1pbHkgY2hpcCBzdHJ1Y3QgKHN1Y2ggYXMg c3RydWN0IG5hbmRfY2hpcCkuDQpOQU5EIGZhbWlseSBkcml2ZXIgc2hvdWxkIGFsbG9jYXRlLCBp bml0aWFsaXplIGFuZCBmcmVlIHN0cnVjdCBuYW5kX2JidC4NCg0KQmVsb3cgaXMgbXRkIGZvbGRl ciBzdHJ1Y3R1cmUgd2Ugd2FudDoNCgltdGQNCgnilJzilIDilIAgS2NvbmZpZw0KCeKUnOKUgOKU gCBNYWtlZmlsZQ0KCeKUnOKUgOKUgCAuLi4NCgnilJzilIDilIAgbmFuZF9iYnQuYw0KCeKUnOKU gOKUgCBuYW5kDQoJ4pSCwqDCoCDilJzilIDilIAgS2NvbmZpZw0KCeKUgsKgwqAg4pSc4pSA4pSA IE1ha2VmaWxlDQoJ4pSCwqDCoCDilJzilIDilIAgbmFuZF9iYXNlLmMNCgnilILCoMKgIOKUnOKU gOKUgCBuYW5kX2lkcy5jDQoJ4pSCwqDCoCDilJzilIDilIAgLi4uDQoJ4pSCwqDCoCDilJTilIDi lIAgeHdheV9uYW5kLmMNCgnilJzilIDilIAgc3BpLW5hbmQNCgnilILCoMKgIOKUnOKUgOKUgCBL Y29uZmlnDQoJ4pSCwqDCoCDilJzilIDilIAgTWFrZWZpbGUNCgnilILCoMKgIOKUnOKUgOKUgCBz cGktbmFuZC1iYXNlLmMNCgnilILCoMKgIOKUnOKUgOKUgCAuLi4NCgnilILCoMKgIOKUlOKUgOKU gCBzcGktbmFuZC1kZXZpY2UuYw0KCeKUlOKUgOKUgCAuLi4NCg0KTW9zdCBvZiB0aGUgcGF0Y2gg aXMgYm9ycm93ZWQgZnJvbSBCcmlhbiBOb3JyaXMgPGNvbXB1dGVyc2ZvcnBlYWNlQGdtYWlsLmNv bT4uDQpodHRwOi8vZ2l0LmluZnJhZGVhZC5vcmcvdXNlcnMvbm9ycmlzL2xpbnV4LW10ZC5naXQv c2hvcnRsb2cvcmVmcy9oZWFkcy9uYW5kLWJidA0KQmFzZWQgb24gQnJpYW4ncyBzdWdnZXN0aW9u LCBJIG1ha2UgbXkgcHJldmlvdXMgQkJUIHBhdGNoIGludG8gMTIgaW5kZXBlbmRlbnQNCnBhdGNo ZXMuIFByZXZpb3VzIHBhdGNoIGlzIGh0dHA6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wYXRjaC80 OTIwNjYvDQpCZXNpZGUgdGhlIHBhdGNoIHNwbGl0LCBJIGFsc28gbW92ZWQgbmFuZF9iYnQuYyB0 byBtdGQgZm9sZGVyLCB3aGljaCBkaWRuJ3QgaW4NCnByZXZpb3VzIHBhdGNoLg0KDQpQYXRjaCAz LCA3LCA4LCA5LCAxMCBhbmQgMTEgYXJlIHRvdGFsbHkgYm9ycm93ZWQgZnJvbSBCcmlhbidzIGdp dCB0cmVlLiBJIGp1c3QNCnRlc3QgYW5kIHNwbGl0IHRoZSBjb2RlIGludG8gaW5kZXBlbmRlbnQg cGF0Y2guIFBhdGNoIDEsIDIsIDUgYW5kIDYgYXJlIHBhcnRpYWwNCmJvcnJvd2VkLiBJIG1ha2Ug c29tZSBjaGFuZ2VzIGZyb20gQnJpYW4ncyBnaXQgdHJlZSBhbmQgdGhlIGNoYW5nZXMgYXJlIHJl Y29yZGVkDQppbiBjb21taXQgbG9nLiBQYXRjaCA0IGFuZCAxMiBhcmUgd3JpdHRlbiBieSBtZS4N Cg0KVGhlIHBhdGNoIGlzIHRlc3RlZCBvbiBaZWQgYm9hcmQuIFRoaXMgdmVyc2lvbiBvZiB0aGlz IHNlcmllcyBpcyBiYXNlZCBvbiBtYXN0ZXINCmJyYW5jaCBvZiBsMi1tdGQuZ2l0IChjb21taXQg ZTEzMDVkZjEyODNjYmUxYWE1NzA5M2Y4NzY2YjJkZmU2NTBlZDVmZikuDQoNCkJyaWFuIE5vcnJp cyAoNik6DQoJbXRkOiBuYW5kX2JidDogYWRkIG5ldyBBUEkgZGVmaW5pdGlvbnMNCgltdGQ6IG5h bmQ6IG1ha2UgbmFuZF9lcmFzZV9uYW5kKCkgc3RhdGljDQoJbXRkOiBuYW5kX2JidDogcmVtb3Zl IHN0cnVjdCBuYW5kX2NoaXAgZnJvbSBuYW5kX2JidC5jDQoJbXRkOiBuYW5kX2JidDogcmVtb3Zl IG9sZCBBUEkgZGVmaW5pdGlvbnMNCgltdGQ6IG5hbmRfYmJ0OiByZW1vdmUgTkFORF9CQlRfRFlO QU1JQ1NUUlVDVCBtYWNybw0KCW10ZDogbmFuZDogcmVtb3ZlIG5hbmRfY2hpcC5iYnQNCkJyaWFu IE5vcnJpcyBhbmQgUGV0ZXIgUGFuICg0KToNCgltdGQ6IG5hbmRfYmJ0OiBuZXcgaGVhZGVyIGZv ciBuYW5kIGZhbWlseSBCQlQNCgltdGQ6IG5hbmRfYmJ0OiBpbnRyb2R1Y2Ugc3RydWN0IG5hbmRf YmJ0DQoJbXRkOiBuYW5kOiB1c2UgbmV3IEJCVCBBUEkgaW5zdGVhZCBvZiBvbGQgb25lcw0KCW10 ZDogbmFuZF9iYnQ6IHVzZSBlcmFzZSgpIGFuZCBpc19iYWRfYmJtKCkgaG9vayBpbiBCQlQNClBl dGVyIFBhbiAoMik6DQoJbXRkOiBuYW5kX2JidDogYWRkIG5hbmRfYmJ0X21hcmtiYWRfZmFjdG9y eSgpIGludGVyZmFjZQ0KCW10ZDogbmFuZC1iYnQ6IG1vdmUgbmFuZF9iYnQuYyB0byBtdGQgZm9s ZGVyDQoNCi0tLQ0KIGRyaXZlcnMvbXRkL0tjb25maWcgICAgICAgICAgfCAgICA3ICsNCiBkcml2 ZXJzL210ZC9NYWtlZmlsZSAgICAgICAgIHwgICAgMSArDQogZHJpdmVycy9tdGQvbmFuZC9LY29u ZmlnICAgICB8ICAgIDIgKy0NCiBkcml2ZXJzL210ZC9uYW5kL01ha2VmaWxlICAgIHwgICAgMiAr LQ0KIGRyaXZlcnMvbXRkL25hbmQvZG9jZzQuYyAgICAgfCAgICA2ICstDQogZHJpdmVycy9tdGQv bmFuZC9uYW5kX2Jhc2UuYyB8ICAxNDUgKysrKy0NCiBkcml2ZXJzL210ZC9uYW5kL25hbmRfYmJ0 LmMgIHwgMTM3NyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCiBk cml2ZXJzL210ZC9uYW5kX2JidC5jICAgICAgIHwgMTI4OSArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysNCiBpbmNsdWRlL2xpbnV4L210ZC9iYm0uaCAgICAgIHwgICA5NiAr LS0NCiBpbmNsdWRlL2xpbnV4L210ZC9uYW5kLmggICAgIHwgICAxNiArLQ0KIGluY2x1ZGUvbGlu dXgvbXRkL25hbmRfYmJ0LmggfCAgMTc3ICsrKysrKw0KIDExIGZpbGVzIGNoYW5nZWQsIDE2MjQg aW5zZXJ0aW9ucygrKSwgMTQ5NCBkZWxldGlvbnMoLSkNCiBkZWxldGUgbW9kZSAxMDA2NDQgZHJp dmVycy9tdGQvbmFuZC9uYW5kX2JidC5jDQogY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvbXRk L25hbmRfYmJ0LmMNCiBjcmVhdGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC9tdGQvbmFuZF9i YnQuaA0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2015-09-25 09:00 +0200 |
| Message-ID | <qcv98-2eP-5@gated-at.bofh.it> |
| In reply to | #1232594 |
Hi Peter, This comment is not related to the code itself, but next time you send a patch series, could you send all patches as a reply to the cover letter? This is automatically done when you use git send-email unless you pass the --no-thread option. The following command should do the trick: git send-email <path-to-your-patchset-dir>/*.patch Best Regards, Boris On Fri, 25 Sep 2015 06:34:34 +0000 Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> wrote: > Currently nand_bbt.c is tied with struct nand_chip, and it makes other > NAND family chips hard to use nand_bbt.c. Maybe it's the reason why > onenand has own bbt(onenand_bbt.c). > > Separate struct nand_chip from BBT code can make current BBT shareable. > We create struct nand_bbt to take place of nand_chip in nand_bbt.c. > Struct nand_bbt contains all the information BBT needed from outside and > it should be embedded into NAND family chip struct (such as struct nand_chip). > NAND family driver should allocate, initialize and free struct nand_bbt. > > Below is mtd folder structure we want: > mtd > ├── Kconfig > ├── Makefile > ├── ... > ├── nand_bbt.c > ├── nand > │ ├── Kconfig > │ ├── Makefile > │ ├── nand_base.c > │ ├── nand_ids.c > │ ├── ... > │ └── xway_nand.c > ├── spi-nand > │ ├── Kconfig > │ ├── Makefile > │ ├── spi-nand-base.c > │ ├── ... > │ └── spi-nand-device.c > └── ... > > Most of the patch is borrowed from Brian Norris <computersforpeace@gmail.com>. > http://git.infradead.org/users/norris/linux-mtd.git/shortlog/refs/heads/nand-bbt > Based on Brian's suggestion, I make my previous BBT patch into 12 independent > patches. Previous patch is http://patchwork.ozlabs.org/patch/492066/ > Beside the patch split, I also moved nand_bbt.c to mtd folder, which didn't in > previous patch. > > Patch 3, 7, 8, 9, 10 and 11 are totally borrowed from Brian's git tree. I just > test and split the code into independent patch. Patch 1, 2, 5 and 6 are partial > borrowed. I make some changes from Brian's git tree and the changes are recorded > in commit log. Patch 4 and 12 are written by me. > > The patch is tested on Zed board. This version of this series is based on master > branch of l2-mtd.git (commit e1305df1283cbe1aa57093f8766b2dfe650ed5ff). > > Brian Norris (6): > mtd: nand_bbt: add new API definitions > mtd: nand: make nand_erase_nand() static > mtd: nand_bbt: remove struct nand_chip from nand_bbt.c > mtd: nand_bbt: remove old API definitions > mtd: nand_bbt: remove NAND_BBT_DYNAMICSTRUCT macro > mtd: nand: remove nand_chip.bbt > Brian Norris and Peter Pan (4): > mtd: nand_bbt: new header for nand family BBT > mtd: nand_bbt: introduce struct nand_bbt > mtd: nand: use new BBT API instead of old ones > mtd: nand_bbt: use erase() and is_bad_bbm() hook in BBT > Peter Pan (2): > mtd: nand_bbt: add nand_bbt_markbad_factory() interface > mtd: nand-bbt: move nand_bbt.c to mtd folder > > --- > drivers/mtd/Kconfig | 7 + > drivers/mtd/Makefile | 1 + > drivers/mtd/nand/Kconfig | 2 +- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/docg4.c | 6 +- > drivers/mtd/nand/nand_base.c | 145 ++++- > drivers/mtd/nand/nand_bbt.c | 1377 ------------------------------------------ > drivers/mtd/nand_bbt.c | 1289 +++++++++++++++++++++++++++++++++++++++ > include/linux/mtd/bbm.h | 96 +-- > include/linux/mtd/nand.h | 16 +- > include/linux/mtd/nand_bbt.h | 177 ++++++ > 11 files changed, 1624 insertions(+), 1494 deletions(-) > delete mode 100644 drivers/mtd/nand/nand_bbt.c > create mode 100644 drivers/mtd/nand_bbt.c > create mode 100644 include/linux/mtd/nand_bbt.h -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> |
|---|---|
| Date | 2015-09-25 10:40 +0200 |
| Message-ID | <qcwHV-4uB-13@gated-at.bofh.it> |
| In reply to | #1232613 |
SGkgQm9yaXMsDQoNClNvcnJ5IGZvciB0cm91YmxlIHlvdS4gU2luY2UgSSBjYW5ub3Qgc2VuZCBt YWlsIHVzaW5nICdnaXQgc2VuZC1lbWFpbCcgcmlnaHQgbm93Lg0KSSBzZW50IHRoaXMgc2VyaWVz IGJ5IG91dGxvb2suIFRoYW5rcyBmb3IgeW91ciBzdWdnZXN0aW9uLiBJJ2xsIGZpeCB0aGlzIHNv b24uDQoNClBldGVyIFBhbg0KDQpPbiBGcmksIDI1IFNlcCAyMDE1IDE0OjU0OjM4ICswMDAwDQpC b3JpcyBCcmV6aWxsb24gPCBib3Jpcy5icmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tID4gd3Jv dGU6DQoNCj4gSGkgUGV0ZXIsDQo+IA0KPiBUaGlzIGNvbW1lbnQgaXMgbm90IHJlbGF0ZWQgdG8g dGhlIGNvZGUgaXRzZWxmLCBidXQgbmV4dCB0aW1lIHlvdSBzZW5kIGENCj4gcGF0Y2ggc2VyaWVz LCBjb3VsZCB5b3Ugc2VuZCBhbGwgcGF0Y2hlcyBhcyBhIHJlcGx5IHRvIHRoZSBjb3ZlciBsZXR0 ZXI/DQo+IFRoaXMgaXMgYXV0b21hdGljYWxseSBkb25lIHdoZW4geW91IHVzZSBnaXQgc2VuZC1l bWFpbCB1bmxlc3MgeW91IHBhc3MNCj4gdGhlIC0tbm8tdGhyZWFkIG9wdGlvbi4NCj4gVGhlIGZv bGxvd2luZyBjb21tYW5kIHNob3VsZCBkbyB0aGUgdHJpY2s6DQo+IA0KPiBnaXQgc2VuZC1lbWFp bCA8cGF0aC10by15b3VyLXBhdGNoc2V0LWRpcj4vKi5wYXRjaA0KPiANCj4gQmVzdCBSZWdhcmRz LA0KPiANCj4gQm9yaXMNCj4gDQo+IE9uIEZyaSwgMjUgU2VwIDIwMTUgMDY6MzQ6MzQgKzAwMDAN Cj4gUGV0ZXIgUGFuIOa9mOagiyAocGV0ZXJwYW5kb25nKSA8cGV0ZXJwYW5kb25nQG1pY3Jvbi5j b20+IHdyb3RlOg0KPiANCj4gPiBDdXJyZW50bHkgbmFuZF9iYnQuYyBpcyB0aWVkIHdpdGggc3Ry dWN0IG5hbmRfY2hpcCwgYW5kIGl0IG1ha2VzIG90aGVyDQo+ID4gTkFORCBmYW1pbHkgY2hpcHMg aGFyZCB0byB1c2UgbmFuZF9iYnQuYy4gTWF5YmUgaXQncyB0aGUgcmVhc29uIHdoeQ0KPiA+IG9u ZW5hbmQgaGFzIG93biBiYnQob25lbmFuZF9iYnQuYykuDQo+ID4NCj4gPiBTZXBhcmF0ZSBzdHJ1 Y3QgbmFuZF9jaGlwIGZyb20gQkJUIGNvZGUgY2FuIG1ha2UgY3VycmVudCBCQlQgc2hhcmVhYmxl Lg0KPiA+IFdlIGNyZWF0ZSBzdHJ1Y3QgbmFuZF9iYnQgdG8gdGFrZSBwbGFjZSBvZiBuYW5kX2No aXAgaW4gbmFuZF9iYnQuYy4NCj4gPiBTdHJ1Y3QgbmFuZF9iYnQgY29udGFpbnMgYWxsIHRoZSBp bmZvcm1hdGlvbiBCQlQgbmVlZGVkIGZyb20gb3V0c2lkZSBhbmQNCj4gPiBpdCBzaG91bGQgYmUg ZW1iZWRkZWQgaW50byBOQU5EIGZhbWlseSBjaGlwIHN0cnVjdCAoc3VjaCBhcyBzdHJ1Y3QNCj4g bmFuZF9jaGlwKS4NCj4gPiBOQU5EIGZhbWlseSBkcml2ZXIgc2hvdWxkIGFsbG9jYXRlLCBpbml0 aWFsaXplIGFuZCBmcmVlIHN0cnVjdCBuYW5kX2JidC4NCj4gPg0KPiA+IEJlbG93IGlzIG10ZCBm b2xkZXIgc3RydWN0dXJlIHdlIHdhbnQ6DQo+ID4gCW10ZA0KPiA+IAnilJzilIDilIAgS2NvbmZp Zw0KPiA+IAnilJzilIDilIAgTWFrZWZpbGUNCj4gPiAJ4pSc4pSA4pSAIC4uLg0KPiA+IAnilJzi lIDilIAgbmFuZF9iYnQuYw0KPiA+IAnilJzilIDilIAgbmFuZA0KPiA+IAnilILCoMKgIOKUnOKU gOKUgCBLY29uZmlnDQo+ID4gCeKUgsKgwqAg4pSc4pSA4pSAIE1ha2VmaWxlDQo+ID4gCeKUgsKg wqAg4pSc4pSA4pSAIG5hbmRfYmFzZS5jDQo+ID4gCeKUgsKgwqAg4pSc4pSA4pSAIG5hbmRfaWRz LmMNCj4gPiAJ4pSCwqDCoCDilJzilIDilIAgLi4uDQo+ID4gCeKUgsKgwqAg4pSU4pSA4pSAIHh3 YXlfbmFuZC5jDQo+ID4gCeKUnOKUgOKUgCBzcGktbmFuZA0KPiA+IAnilILCoMKgIOKUnOKUgOKU gCBLY29uZmlnDQo+ID4gCeKUgsKgwqAg4pSc4pSA4pSAIE1ha2VmaWxlDQo+ID4gCeKUgsKgwqAg 4pSc4pSA4pSAIHNwaS1uYW5kLWJhc2UuYw0KPiA+IAnilILCoMKgIOKUnOKUgOKUgCAuLi4NCj4g PiAJ4pSCwqDCoCDilJTilIDilIAgc3BpLW5hbmQtZGV2aWNlLmMNCj4gPiAJ4pSU4pSA4pSAIC4u Lg0KPiA+DQo+ID4gTW9zdCBvZiB0aGUgcGF0Y2ggaXMgYm9ycm93ZWQgZnJvbSBCcmlhbiBOb3Jy aXMNCj4gPGNvbXB1dGVyc2ZvcnBlYWNlQGdtYWlsLmNvbT4uDQo+ID4NCj4gaHR0cDovL2dpdC5p bmZyYWRlYWQub3JnL3VzZXJzL25vcnJpcy9saW51eC1tdGQuZ2l0L3Nob3J0bG9nL3JlZnMvaGVh ZHMvbmFuDQo+IGQtYmJ0DQo+ID4gQmFzZWQgb24gQnJpYW4ncyBzdWdnZXN0aW9uLCBJIG1ha2Ug bXkgcHJldmlvdXMgQkJUIHBhdGNoIGludG8gMTINCj4gaW5kZXBlbmRlbnQNCj4gPiBwYXRjaGVz LiBQcmV2aW91cyBwYXRjaCBpcyBodHRwOi8vcGF0Y2h3b3JrLm96bGFicy5vcmcvcGF0Y2gvNDky MDY2Lw0KPiA+IEJlc2lkZSB0aGUgcGF0Y2ggc3BsaXQsIEkgYWxzbyBtb3ZlZCBuYW5kX2JidC5j IHRvIG10ZCBmb2xkZXIsIHdoaWNoIGRpZG4ndA0KPiBpbg0KPiA+IHByZXZpb3VzIHBhdGNoLg0K PiA+DQo+ID4gUGF0Y2ggMywgNywgOCwgOSwgMTAgYW5kIDExIGFyZSB0b3RhbGx5IGJvcnJvd2Vk IGZyb20gQnJpYW4ncyBnaXQgdHJlZS4gSSBqdXN0DQo+ID4gdGVzdCBhbmQgc3BsaXQgdGhlIGNv ZGUgaW50byBpbmRlcGVuZGVudCBwYXRjaC4gUGF0Y2ggMSwgMiwgNSBhbmQgNiBhcmUNCj4gcGFy dGlhbA0KPiA+IGJvcnJvd2VkLiBJIG1ha2Ugc29tZSBjaGFuZ2VzIGZyb20gQnJpYW4ncyBnaXQg dHJlZSBhbmQgdGhlIGNoYW5nZXMgYXJlDQo+IHJlY29yZGVkDQo+ID4gaW4gY29tbWl0IGxvZy4g UGF0Y2ggNCBhbmQgMTIgYXJlIHdyaXR0ZW4gYnkgbWUuDQo+ID4NCj4gPiBUaGUgcGF0Y2ggaXMg dGVzdGVkIG9uIFplZCBib2FyZC4gVGhpcyB2ZXJzaW9uIG9mIHRoaXMgc2VyaWVzIGlzIGJhc2Vk IG9uDQo+IG1hc3Rlcg0KPiA+IGJyYW5jaCBvZiBsMi1tdGQuZ2l0IChjb21taXQNCj4gZTEzMDVk ZjEyODNjYmUxYWE1NzA5M2Y4NzY2YjJkZmU2NTBlZDVmZikuDQo+ID4NCj4gPiBCcmlhbiBOb3Jy aXMgKDYpOg0KPiA+IAltdGQ6IG5hbmRfYmJ0OiBhZGQgbmV3IEFQSSBkZWZpbml0aW9ucw0KPiA+ IAltdGQ6IG5hbmQ6IG1ha2UgbmFuZF9lcmFzZV9uYW5kKCkgc3RhdGljDQo+ID4gCW10ZDogbmFu ZF9iYnQ6IHJlbW92ZSBzdHJ1Y3QgbmFuZF9jaGlwIGZyb20gbmFuZF9iYnQuYw0KPiA+IAltdGQ6 IG5hbmRfYmJ0OiByZW1vdmUgb2xkIEFQSSBkZWZpbml0aW9ucw0KPiA+IAltdGQ6IG5hbmRfYmJ0 OiByZW1vdmUgTkFORF9CQlRfRFlOQU1JQ1NUUlVDVCBtYWNybw0KPiA+IAltdGQ6IG5hbmQ6IHJl bW92ZSBuYW5kX2NoaXAuYmJ0DQo+ID4gQnJpYW4gTm9ycmlzIGFuZCBQZXRlciBQYW4gKDQpOg0K PiA+IAltdGQ6IG5hbmRfYmJ0OiBuZXcgaGVhZGVyIGZvciBuYW5kIGZhbWlseSBCQlQNCj4gPiAJ bXRkOiBuYW5kX2JidDogaW50cm9kdWNlIHN0cnVjdCBuYW5kX2JidA0KPiA+IAltdGQ6IG5hbmQ6 IHVzZSBuZXcgQkJUIEFQSSBpbnN0ZWFkIG9mIG9sZCBvbmVzDQo+ID4gCW10ZDogbmFuZF9iYnQ6 IHVzZSBlcmFzZSgpIGFuZCBpc19iYWRfYmJtKCkgaG9vayBpbiBCQlQNCj4gPiBQZXRlciBQYW4g KDIpOg0KPiA+IAltdGQ6IG5hbmRfYmJ0OiBhZGQgbmFuZF9iYnRfbWFya2JhZF9mYWN0b3J5KCkg aW50ZXJmYWNlDQo+ID4gCW10ZDogbmFuZC1iYnQ6IG1vdmUgbmFuZF9iYnQuYyB0byBtdGQgZm9s ZGVyDQo+ID4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9tdGQvS2NvbmZpZyAgICAgICAgICB8ICAg IDcgKw0KPiA+ICBkcml2ZXJzL210ZC9NYWtlZmlsZSAgICAgICAgIHwgICAgMSArDQo+ID4gIGRy aXZlcnMvbXRkL25hbmQvS2NvbmZpZyAgICAgfCAgICAyICstDQo+ID4gIGRyaXZlcnMvbXRkL25h bmQvTWFrZWZpbGUgICAgfCAgICAyICstDQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvZG9jZzQuYyAg ICAgfCAgICA2ICstDQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvbmFuZF9iYXNlLmMgfCAgMTQ1ICsr KystDQo+ID4gIGRyaXZlcnMvbXRkL25hbmQvbmFuZF9iYnQuYyAgfCAxMzc3IC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICBkcml2ZXJzL210ZC9uYW5kX2Ji dC5jICAgICAgIHwgMTI4OQ0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr KysNCj4gPiAgaW5jbHVkZS9saW51eC9tdGQvYmJtLmggICAgICB8ICAgOTYgKy0tDQo+ID4gIGlu Y2x1ZGUvbGludXgvbXRkL25hbmQuaCAgICAgfCAgIDE2ICstDQo+ID4gIGluY2x1ZGUvbGludXgv bXRkL25hbmRfYmJ0LmggfCAgMTc3ICsrKysrKw0KPiA+ICAxMSBmaWxlcyBjaGFuZ2VkLCAxNjI0 IGluc2VydGlvbnMoKyksIDE0OTQgZGVsZXRpb25zKC0pDQo+ID4gIGRlbGV0ZSBtb2RlIDEwMDY0 NCBkcml2ZXJzL210ZC9uYW5kL25hbmRfYmJ0LmMNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRy aXZlcnMvbXRkL25hbmRfYmJ0LmMNCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGlu dXgvbXRkL25hbmRfYmJ0LmgNCj4gDQo+IA0KPiANCj4gLS0NCj4gQm9yaXMgQnJlemlsbG9uLCBG cmVlIEVsZWN0cm9ucw0KPiBFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nDQo+ IGh0dHA6Ly9mcmVlLWVsZWN0cm9ucy5jb20NCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Brian Norris <computersforpeace@gmail.com> |
|---|---|
| Date | 2015-09-25 19:40 +0200 |
| Subject | Re: [PATCH 12/12] mtd: nand-bbt: move nand_bbt.c to mtd folder |
| Message-ID | <qcF8t-8dM-5@gated-at.bofh.it> |
| In reply to | #1232594 |
Hi Peter, First of all, thanks for taking the time to try to address my long-delayed comments. I hope to give this a proper look soon. (I also hope you can fix the email threading soon! I know that's a pain...) But first, a simpler comment: On Fri, Sep 25, 2015 at 06:48:05AM +0000, Peter Pan 潘栋 (peterpandong) wrote: > Since struct nand_chip is removed from nand_bbt.c, BBT is now > shareable. Both NAND and SPI NAND can use it. So move nand_bbt.c > from nand/ foler to mtd/ folder and create MTD_NAND_BBT config. > Both NAND and SPI NAND should depend on MTD_NAND_BBT. > > Signed-off-by: Peter Pan <peterpandong@micron.com> > --- > drivers/mtd/Kconfig | 7 + > drivers/mtd/Makefile | 1 + > drivers/mtd/nand/Kconfig | 2 +- > drivers/mtd/nand/Makefile | 2 +- > drivers/mtd/nand/nand_bbt.c | 1289 ------------------------------------------- > drivers/mtd/nand_bbt.c | 1289 +++++++++++++++++++++++++++++++++++++++++++ > 6 files changed, 1299 insertions(+), 1291 deletions(-) > delete mode 100644 drivers/mtd/nand/nand_bbt.c > create mode 100644 drivers/mtd/nand_bbt.c > [...] > diff --git a/drivers/mtd/nand/nand_bbt.c b/drivers/mtd/nand/nand_bbt.c > deleted file mode 100644 > index 47c1084..0000000 > --- a/drivers/mtd/nand/nand_bbt.c > +++ /dev/null > @@ -1,1289 +0,0 @@ [snip deleting entire file] > diff --git a/drivers/mtd/nand_bbt.c b/drivers/mtd/nand_bbt.c > new file mode 100644 > index 0000000..47c1084 > --- /dev/null > +++ b/drivers/mtd/nand_bbt.c > @@ -0,0 +1,1289 @@ [snip adding the whole file again -- exactly the same I hope?] When moving files, it helps if you can use the '-M' (or '--find-renames') option to git-format-patch. That will give much smaller output that's easier to review. And if you had to change anything in the move, it should also help highlight exactly what changed, instead of including the entire file "diff". Regards, Brian P.S. Incidentally, this should also work around your issues with the copyright symbol. But then, I suspect that some people have used these sorts of non-ASCII characters just to fish out issues with mail clients/MTAs like yours :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Peter Pan 潘栋 (peterpandong) <peterpandong@micron.com> |
|---|---|
| Date | 2015-09-28 10:40 +0200 |
| Subject | RE: [PATCH 12/12] mtd: nand-bbt: move nand_bbt.c to mtd folder |
| Message-ID | <qdC8y-u0-15@gated-at.bofh.it> |
| In reply to | #1232963 |
SGkgQnJpYW4sDQoNClRoYW5rcyBmb3IgeW91ciByZXBseS4NCg0KT24gRnJpLCBTZXAgMjUsIDIw MTUgYXQgMDY6NDg6MDVBTSArMDAwMCwgQnJpYW4gTm9ycmlzIDwgY29tcHV0ZXJzZm9ycGVhY2VA Z21haWwuY29tID4NCndyb3RlOg0KPiBIaSBQZXRlciwNCj4gDQo+IEZpcnN0IG9mIGFsbCwgdGhh bmtzIGZvciB0YWtpbmcgdGhlIHRpbWUgdG8gdHJ5IHRvIGFkZHJlc3MgbXkNCj4gbG9uZy1kZWxh eWVkIGNvbW1lbnRzLiBJIGhvcGUgdG8gZ2l2ZSB0aGlzIGEgcHJvcGVyIGxvb2sgc29vbi4gKEkg YWxzbw0KPiBob3BlIHlvdSBjYW4gZml4IHRoZSBlbWFpbCB0aHJlYWRpbmcgc29vbiEgSSBrbm93 IHRoYXQncyBhIHBhaW4uLi4pDQoNClNvcnJ5IGZvciBicmluZ2luZyBpbmNvbnZlbmllbmNlIC4g SSdtIHdvcmtpbmcgb24gdGhpcyBub3cuIEknbSB0cnlpbmcgdG8gZW5hYmxlDQpnaXQtc2VuZC1l bWFpbCBvbiBteSBzZXJ2ZXIuIE9uY2UgaXQgZG9uZSwgSSB3aWxsIHJlc2VuZCB0aGlzIHNlcmll cy4gQnV0IHBsZWFzZSBsb29rDQphdCB0aGlzIHNlcmllcyBmaXJzdCBpZiB5b3UgaGF2ZSB0aW1l Lg0KDQo+IA0KPiBCdXQgZmlyc3QsIGEgc2ltcGxlciBjb21tZW50Og0KPiANCj4gT24gRnJpLCBT ZXAgMjUsIDIwMTUgYXQgMDY6NDg6MDVBTSArMDAwMCwgUGV0ZXIgUGFuIOa9mOagiyAocGV0ZXJw YW5kb25nKQ0KPiB3cm90ZToNCj4gPiBTaW5jZSBzdHJ1Y3QgbmFuZF9jaGlwIGlzIHJlbW92ZWQg ZnJvbSBuYW5kX2JidC5jLCBCQlQgaXMgbm93DQo+ID4gc2hhcmVhYmxlLiBCb3RoIE5BTkQgYW5k IFNQSSBOQU5EIGNhbiB1c2UgaXQuIFNvIG1vdmUgbmFuZF9iYnQuYw0KPiA+IGZyb20gbmFuZC8g Zm9sZXIgdG8gbXRkLyBmb2xkZXIgYW5kIGNyZWF0ZSBNVERfTkFORF9CQlQgY29uZmlnLg0KPiA+ IEJvdGggTkFORCBhbmQgU1BJIE5BTkQgc2hvdWxkIGRlcGVuZCBvbiBNVERfTkFORF9CQlQuDQo+ ID4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBQYW4gPHBldGVycGFuZG9uZ0BtaWNyb24uY29t Pg0KPiA+IC0tLQ0KPiA+ICBkcml2ZXJzL210ZC9LY29uZmlnICAgICAgICAgfCAgICA3ICsNCj4g PiAgZHJpdmVycy9tdGQvTWFrZWZpbGUgICAgICAgIHwgICAgMSArDQo+ID4gIGRyaXZlcnMvbXRk L25hbmQvS2NvbmZpZyAgICB8ICAgIDIgKy0NCj4gPiAgZHJpdmVycy9tdGQvbmFuZC9NYWtlZmls ZSAgIHwgICAgMiArLQ0KPiA+ICBkcml2ZXJzL210ZC9uYW5kL25hbmRfYmJ0LmMgfCAxMjg5IC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0NCj4gPiAgZHJpdmVycy9t dGQvbmFuZF9iYnQuYyAgICAgIHwgMTI4OQ0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrDQo+ID4gIDYgZmlsZXMgY2hhbmdlZCwgMTI5OSBpbnNlcnRpb25zKCsp LCAxMjkxIGRlbGV0aW9ucygtKQ0KPiA+ICBkZWxldGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tdGQv bmFuZC9uYW5kX2JidC5jDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2ZXJzL210ZC9uYW5k X2JidC5jDQo+ID4NCj4gWy4uLl0NCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZC9u YW5kX2JidC5jIGIvZHJpdmVycy9tdGQvbmFuZC9uYW5kX2JidC5jDQo+ID4gZGVsZXRlZCBmaWxl IG1vZGUgMTAwNjQ0DQo+ID4gaW5kZXggNDdjMTA4NC4uMDAwMDAwMA0KPiA+IC0tLSBhL2RyaXZl cnMvbXRkL25hbmQvbmFuZF9iYnQuYw0KPiA+ICsrKyAvZGV2L251bGwNCj4gPiBAQCAtMSwxMjg5 ICswLDAgQEANCj4gDQo+IFtzbmlwIGRlbGV0aW5nIGVudGlyZSBmaWxlXQ0KPiANCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9tdGQvbmFuZF9iYnQuYyBiL2RyaXZlcnMvbXRkL25hbmRfYmJ0LmMN Cj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAuLjQ3YzEwODQNCj4g PiAtLS0gL2Rldi9udWxsDQo+ID4gKysrIGIvZHJpdmVycy9tdGQvbmFuZF9iYnQuYw0KPiA+IEBA IC0wLDAgKzEsMTI4OSBAQA0KPiANCj4gW3NuaXAgYWRkaW5nIHRoZSB3aG9sZSBmaWxlIGFnYWlu IC0tIGV4YWN0bHkgdGhlIHNhbWUgSSBob3BlP10NCg0KWWVzLiBUaGUgd2hvbGUgZmlsZSBpcyBl eGFjdGx5IHRoZSBzYW1lLg0KDQo+IA0KPiBXaGVuIG1vdmluZyBmaWxlcywgaXQgaGVscHMgaWYg eW91IGNhbiB1c2UgdGhlICctTScgKG9yDQo+ICctLWZpbmQtcmVuYW1lcycpIG9wdGlvbiB0byBn aXQtZm9ybWF0LXBhdGNoLiBUaGF0IHdpbGwgZ2l2ZSBtdWNoDQo+IHNtYWxsZXIgb3V0cHV0IHRo YXQncyBlYXNpZXIgdG8gcmV2aWV3LiBBbmQgaWYgeW91IGhhZCB0byBjaGFuZ2UNCj4gYW55dGhp bmcgaW4gdGhlIG1vdmUsIGl0IHNob3VsZCBhbHNvIGhlbHAgaGlnaGxpZ2h0IGV4YWN0bHkgd2hh dA0KPiBjaGFuZ2VkLCBpbnN0ZWFkIG9mIGluY2x1ZGluZyB0aGUgZW50aXJlIGZpbGUgImRpZmYi Lg0KDQpUaGFua3MgYSBsb3QgZm9yIHlvdXIgc3VnZ2VzdGlvbi4gSSdtIHF1aXRlIG5ldyB3aXRo IHBhdGNoIHN1Ym1pdC4NClNvIHBsZWFzZSBmZWVsIGZyZWUgdG8gcG9pbnQgb3V0IG15IG1pc3Np bmcvbWlzdGFrZS4gVGhhbmtzIGluIGFkdmFuY2UuDQoNCj4gDQo+IFJlZ2FyZHMsDQo+IEJyaWFu DQo+IA0KPiBQLlMuIEluY2lkZW50YWxseSwgdGhpcyBzaG91bGQgYWxzbyB3b3JrIGFyb3VuZCB5 b3VyIGlzc3VlcyB3aXRoIHRoZQ0KPiBjb3B5cmlnaHQgc3ltYm9sLiBCdXQgdGhlbiwgSSBzdXNw ZWN0IHRoYXQgc29tZSBwZW9wbGUgaGF2ZSB1c2VkIHRoZXNlDQo+IHNvcnRzIG9mIG5vbi1BU0NJ SSBjaGFyYWN0ZXJzIGp1c3QgdG8gZmlzaCBvdXQgaXNzdWVzIHdpdGggbWFpbA0KPiBjbGllbnRz L01UQXMgbGlrZSB5b3VycyA6KQ0K -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web