Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1231868 > unrolled thread

Re: [PATCH] hid: enable hid device to suspend/resume asynchronously

Started by"Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
First post2015-09-24 08:10 +0200
Last post2015-09-25 14:10 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] hid: enable hid device to suspend/resume asynchronously "Fu, Zhonghui" <zhonghui.fu@linux.intel.com> - 2015-09-24 08:10 +0200
    Re: [PATCH] hid: enable hid device to suspend/resume  asynchronously Jiri Kosina <jikos@kernel.org> - 2015-09-25 14:10 +0200

#1231868 — Re: [PATCH] hid: enable hid device to suspend/resume asynchronously

From"Fu, Zhonghui" <zhonghui.fu@linux.intel.com>
Date2015-09-24 08:10 +0200
SubjectRe: [PATCH] hid: enable hid device to suspend/resume asynchronously
Message-ID<qc7Tc-2Wj-7@gated-at.bofh.it>

On 2015/9/4 21:10, Jiri Kosina wrote:
> On Mon, 17 Aug 2015, Fu, Zhonghui wrote:
>
>> Enable hid device to suspend/resume asynchronously. This can improve
>> system suspend/resume speed.
> How well was this tested?
>
> Power management is notorious for not being really in excellent shape on 
> many HID devices.
>
> So I'd like to be careful.
I were on leave these days, so sorry for late reply.

This can reduce system suspend/resume time about 20ms, from 1030ms to 1010ms on ASUS T100TA machine. Although the improvement is not very significant, but this can let your parent/child device suspend/resume more asynchronously and take advantage of multicore to improve overall system suspend/resume speed.

I have resent this patch with updated commit message - "[PATCH v2] hid: enable hid device to suspend/resume asynchronously".


Thanks,
Zhonghui

>
> Thanks,
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1232740 — Re: [PATCH] hid: enable hid device to suspend/resume asynchronously

FromJiri Kosina <jikos@kernel.org>
Date2015-09-25 14:10 +0200
SubjectRe: [PATCH] hid: enable hid device to suspend/resume asynchronously
Message-ID<qczZ8-T1-11@gated-at.bofh.it>
In reply to#1231868
On Thu, 24 Sep 2015, Fu, Zhonghui wrote:

> >> Enable hid device to suspend/resume asynchronously. This can improve
> >> system suspend/resume speed.
> > How well was this tested?
> >
> > Power management is notorious for not being really in excellent shape on 
> > many HID devices.
> >
> > So I'd like to be careful.
> I were on leave these days, so sorry for late reply.
> 
> This can reduce system suspend/resume time about 20ms, from 1030ms to 
> 1010ms on ASUS T100TA machine. Although the improvement is not very 
> significant, but this can let your parent/child device suspend/resume 
> more asynchronously and take advantage of multicore to improve overall 
> system suspend/resume speed.
> 
> I have resent this patch with updated commit message - "[PATCH v2] hid: 
> enable hid device to suspend/resume asynchronously".

Is there any reason why not enable this from userspace via sysfs instead, 
based on whitelist on known-to-be-well-behaved devices, from udev?

I am really careful when it comes to enabling features like this 
(especially given the state of PM support on some low-end devices) 
globally.

Thanks,

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web