Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1231833 > unrolled thread

[PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit

Started byTan Xiaojun <tanxiaojun@huawei.com>
First post2015-09-24 05:30 +0200
Last post2015-09-24 05:30 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit Tan Xiaojun <tanxiaojun@huawei.com> - 2015-09-24 05:30 +0200

#1231833 — [PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit

FromTan Xiaojun <tanxiaojun@huawei.com>
Date2015-09-24 05:30 +0200
Subject[PATCH RESEND] CMA: fix CONFIG_CMA_SIZE_MBYTES overflow in 64bit
Message-ID<qc5om-7HZ-19@gated-at.bofh.it>
In 64bit system, if you set CONFIG_CMA_SIZE_MBYTES>=2048, it will
overflow and size_bytes will be a big wrong number.

Set CONFIG_CMA_SIZE_MBYTES=2048 and you will get an info below
during system boot:

*********
cma: Failed to reserve 17592186042368 MiB
*********

Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
---
 drivers/base/dma-contiguous.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c
index 950fff9..426ba27 100644
--- a/drivers/base/dma-contiguous.c
+++ b/drivers/base/dma-contiguous.c
@@ -46,7 +46,7 @@ struct cma *dma_contiguous_default_area;
  * Users, who want to set the size of global CMA area for their system
  * should use cma= kernel parameter.
  */
-static const phys_addr_t size_bytes = CMA_SIZE_MBYTES * SZ_1M;
+static const phys_addr_t size_bytes = (phys_addr_t)CMA_SIZE_MBYTES * SZ_1M;
 static phys_addr_t size_cmdline = -1;
 static phys_addr_t base_cmdline;
 static phys_addr_t limit_cmdline;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web