Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1229491 > unrolled thread

[PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag

Started bySudeep Holla <sudeep.holla@arm.com>
First post2015-09-21 17:50 +0200
Last post2015-09-25 18:10 +0200
Articles 8 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-21 17:50 +0200
    Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Lee Jones <lee.jones@linaro.org> - 2015-09-22 01:30 +0200
      Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-09-22 02:50 +0200
        Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Lee Jones <lee.jones@linaro.org> - 2015-09-22 23:10 +0200
          Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-23 11:00 +0200
      Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-22 12:10 +0200
    [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-25 14:40 +0200
      Re: [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND  flag Lee Jones <lee.jones@linaro.org> - 2015-09-25 18:10 +0200

#1229491 — [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-09-21 17:50 +0200
Subject[PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag
Message-ID<qbbvQ-2wt-13@gated-at.bofh.it>
The driver handles wakeup irq correctly using irq_set_irq_wake. There's
no need to use IRQF_NO_SUSPEND while registering the interrupt.

This patch removes the use of IRQF_NO_SUSPEND flag.

Cc: Samuel Ortiz <sameo@linux.intel.com>
Cc: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/mfd/qcom_rpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 6afc9fabd94c..207a3bd68559 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
 	ret = devm_request_irq(&pdev->dev,
 			       irq_ack,
 			       qcom_rpm_ack_interrupt,
-			       IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND,
+			       IRQF_TRIGGER_RISING,
 			       "qcom_rpm_ack",
 			       rpm);
 	if (ret) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1229830

FromLee Jones <lee.jones@linaro.org>
Date2015-09-22 01:30 +0200
Message-ID<qbiH0-4zP-15@gated-at.bofh.it>
In reply to#1229491
The $SUBJECT is not correct.

> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
> no need to use IRQF_NO_SUSPEND while registering the interrupt.
> 
> This patch removes the use of IRQF_NO_SUSPEND flag.
> 
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/mfd/qcom_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

... code is fine though:

Acked-by: Lee Jones <lee.jones@linaro.org>

Please re-submit with the subject line fixed.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 6afc9fabd94c..207a3bd68559 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	ret = devm_request_irq(&pdev->dev,
>  			       irq_ack,
>  			       qcom_rpm_ack_interrupt,
> -			       IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND,
> +			       IRQF_TRIGGER_RISING,
>  			       "qcom_rpm_ack",
>  			       rpm);
>  	if (ret) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1229865

FromDmitry Torokhov <dmitry.torokhov@gmail.com>
Date2015-09-22 02:50 +0200
Message-ID<qbjWp-6fR-5@gated-at.bofh.it>
In reply to#1229830
On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
> The $SUBJECT is not correct.
>
>> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
>> no need to use IRQF_NO_SUSPEND while registering the interrupt.
>>
>> This patch removes the use of IRQF_NO_SUSPEND flag.
>>
>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>> Cc: Lee Jones <lee.jones@linaro.org>
>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>> ---
>>  drivers/mfd/qcom_rpm.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> ... code is fine though:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
> Please re-submit with the subject line fixed.

What's wrong with the subject?

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1230958

FromLee Jones <lee.jones@linaro.org>
Date2015-09-22 23:10 +0200
Message-ID<qbCZ4-af-29@gated-at.bofh.it>
In reply to#1229865
On Mon, 21 Sep 2015, Dmitry Torokhov wrote:

> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > The $SUBJECT is not correct.
> >
> >> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
> >> no need to use IRQF_NO_SUSPEND while registering the interrupt.
> >>
> >> This patch removes the use of IRQF_NO_SUSPEND flag.
> >>
> >> Cc: Samuel Ortiz <sameo@linux.intel.com>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >> ---
> >>  drivers/mfd/qcom_rpm.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > ... code is fine though:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Please re-submit with the subject line fixed.
> 
> What's wrong with the subject?

This patch has nothing to do with Input and the first word of the
explanatory sentence should start with an uppercase character.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1231260

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-09-23 11:00 +0200
Message-ID<qbO49-7Ek-13@gated-at.bofh.it>
In reply to#1230958

On 22/09/15 22:08, Lee Jones wrote:
> On Mon, 21 Sep 2015, Dmitry Torokhov wrote:
>
>> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>> The $SUBJECT is not correct.
>>>
>>>> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
>>>> no need to use IRQF_NO_SUSPEND while registering the interrupt.
>>>>
>>>> This patch removes the use of IRQF_NO_SUSPEND flag.
>>>>
>>>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>>>> Cc: Lee Jones <lee.jones@linaro.org>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>> ---
>>>>   drivers/mfd/qcom_rpm.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> ... code is fine though:
>>>
>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>>
>>> Please re-submit with the subject line fixed.
>>
>> What's wrong with the subject?
>
> This patch has nothing to do with Input and the first word of the
> explanatory sentence should start with an uppercase character.
>

Ah my stupid mistake, I didn't realize it. Sorry for the noise, will
fix it and send.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1230031

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-09-22 12:10 +0200
Message-ID<qbsGm-2d2-15@gated-at.bofh.it>
In reply to#1229830
Hi Lee,

On 22/09/15 00:21, Lee Jones wrote:
> The $SUBJECT is not correct.
>

Any suggestions ? Most of this series I have used "remove misuse..."
But this driver was doing things correctly, just that it left this
flag as is.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1232764 — [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag

FromSudeep Holla <sudeep.holla@arm.com>
Date2015-09-25 14:40 +0200
Subject[PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag
Message-ID<qcAsa-1qE-9@gated-at.bofh.it>
In reply to#1229491
The driver handles wakeup irq correctly using irq_set_irq_wake. There's
no need to use IRQF_NO_SUSPEND while registering the interrupt.

This patch removes the use of IRQF_NO_SUSPEND flag.

Cc: Samuel Ortiz <sameo@linux.intel.com>
Acked-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 drivers/mfd/qcom_rpm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Updated version with the $subject fixed and Lee's ACK.

diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 6afc9fabd94c..207a3bd68559 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
 	ret = devm_request_irq(&pdev->dev,
 			       irq_ack,
 			       qcom_rpm_ack_interrupt,
-			       IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND,
+			       IRQF_TRIGGER_RISING,
 			       "qcom_rpm_ack",
 			       rpm);
 	if (ret) {
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1232910 — Re: [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag

FromLee Jones <lee.jones@linaro.org>
Date2015-09-25 18:10 +0200
SubjectRe: [PATCH 07/17][UPDATE] mfd: qcom_rpm: Drop use of IRQF_NO_SUSPEND flag
Message-ID<qcDJp-6jZ-29@gated-at.bofh.it>
In reply to#1232764
On Fri, 25 Sep 2015, Sudeep Holla wrote:

> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
> no need to use IRQF_NO_SUSPEND while registering the interrupt.
> 
> This patch removes the use of IRQF_NO_SUSPEND flag.
> 
> Cc: Samuel Ortiz <sameo@linux.intel.com>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  drivers/mfd/qcom_rpm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Updated version with the $subject fixed and Lee's ACK.

Applied, thanks.

> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 6afc9fabd94c..207a3bd68559 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -550,7 +550,7 @@ static int qcom_rpm_probe(struct platform_device *pdev)
>  	ret = devm_request_irq(&pdev->dev,
>  			       irq_ack,
>  			       qcom_rpm_ack_interrupt,
> -			       IRQF_TRIGGER_RISING | IRQF_NO_SUSPEND,
> +			       IRQF_TRIGGER_RISING,
>  			       "qcom_rpm_ack",
>  			       rpm);
>  	if (ret) {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web