Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1223877 > unrolled thread
| Started by | Daniel Kurtz <djkurtz@chromium.org> |
|---|---|
| First post | 2015-09-14 09:40 +0200 |
| Last post | 2015-09-22 10:40 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support Daniel Kurtz <djkurtz@chromium.org> - 2015-09-14 09:40 +0200
Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support Daniel Kurtz <djkurtz@chromium.org> - 2015-09-22 09:40 +0200
Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support Sascha Hauer <s.hauer@pengutronix.de> - 2015-09-22 10:40 +0200
| From | Daniel Kurtz <djkurtz@chromium.org> |
|---|---|
| Date | 2015-09-14 09:40 +0200 |
| Subject | Re: [PATCH 2/3] thermal: Add Mediatek thermal controller support |
| Message-ID | <q8wwO-7Ze-3@gated-at.bofh.it> |
Hi Sascha,
On Mon, Aug 31, 2015 at 3:34 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> This adds support for the Mediatek thermal controller found on MT8173
> and likely other SoCs.
> The controller is a bit special. It does not have its own ADC, instead
> it controls the on-SoC AUXADC via AHB bus accesses. For this reason
> we need the physical address of the AUXADC. Also it controls a mux
> using AHB bus accesses, so we need the APMIXEDSYS physical address aswell.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
[snip...]
> +static int mtk_read_temp(void *data, long *temp)
> +{
> + struct mtk_thermal_bank *bank = data;
> +
> + mtk_thermal_get_bank(bank);
> +
> + *temp = mtk_thermal_bank_temperature(bank);
> +
> + mtk_thermal_put_bank(bank);
> +
> + return 0;
> +}
> +
> +static const struct thermal_zone_of_device_ops mtk_thermal_ops = {
> + .get_temp = mtk_read_temp,
On v4.3-rc1, this now causes a compile warning, since the prototype
for get_temp was changed to:
int (*get_temp)(void *, int *);
by:
commit 17e8351a77397e8a83727eb17e3a3e9b8ab5257a
thermal: consistently use int for temperatures
-Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Daniel Kurtz <djkurtz@chromium.org> |
|---|---|
| Date | 2015-09-22 09:40 +0200 |
| Message-ID | <qbqlc-7b4-9@gated-at.bofh.it> |
| In reply to | #1223877 |
On Mon, Sep 14, 2015 at 3:32 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
>
> Hi Sascha,
>
> On Mon, Aug 31, 2015 at 3:34 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > This adds support for the Mediatek thermal controller found on MT8173
> > and likely other SoCs.
> > The controller is a bit special. It does not have its own ADC, instead
> > it controls the on-SoC AUXADC via AHB bus accesses. For this reason
> > we need the physical address of the AUXADC. Also it controls a mux
> > using AHB bus accesses, so we need the APMIXEDSYS physical address aswell.
> >
> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
>
> [snip...]
>
> > +static int mtk_read_temp(void *data, long *temp)
> > +{
> > + struct mtk_thermal_bank *bank = data;
> > +
> > + mtk_thermal_get_bank(bank);
> > +
> > + *temp = mtk_thermal_bank_temperature(bank);
> > +
> > + mtk_thermal_put_bank(bank);
> > +
> > + return 0;
> > +}
> > +
> > +static const struct thermal_zone_of_device_ops mtk_thermal_ops = {
> > + .get_temp = mtk_read_temp,
>
> On v4.3-rc1, this now causes a compile warning, since the prototype
> for get_temp was changed to:
>
> int (*get_temp)(void *, int *);
>
> by:
> commit 17e8351a77397e8a83727eb17e3a3e9b8ab5257a
> thermal: consistently use int for temperatures
It is actually a little worse than a warning. This actually causes a
crash on boot.
Sascha, can you send out a rebased patch set on v4.3-rc1?
Thanks,
-Dan
>
>
> -Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Sascha Hauer <s.hauer@pengutronix.de> |
|---|---|
| Date | 2015-09-22 10:40 +0200 |
| Message-ID | <qbrhf-8vS-9@gated-at.bofh.it> |
| In reply to | #1229946 |
On Tue, Sep 22, 2015 at 03:30:47PM +0800, Daniel Kurtz wrote:
> On Mon, Sep 14, 2015 at 3:32 PM, Daniel Kurtz <djkurtz@chromium.org> wrote:
> >
> > Hi Sascha,
> >
> > On Mon, Aug 31, 2015 at 3:34 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > This adds support for the Mediatek thermal controller found on MT8173
> > > and likely other SoCs.
> > > The controller is a bit special. It does not have its own ADC, instead
> > > it controls the on-SoC AUXADC via AHB bus accesses. For this reason
> > > we need the physical address of the AUXADC. Also it controls a mux
> > > using AHB bus accesses, so we need the APMIXEDSYS physical address aswell.
> > >
> > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> > > Reviewed-by: Daniel Kurtz <djkurtz@chromium.org>
> >
> > [snip...]
> >
> > > +static int mtk_read_temp(void *data, long *temp)
> > > +{
> > > + struct mtk_thermal_bank *bank = data;
> > > +
> > > + mtk_thermal_get_bank(bank);
> > > +
> > > + *temp = mtk_thermal_bank_temperature(bank);
> > > +
> > > + mtk_thermal_put_bank(bank);
> > > +
> > > + return 0;
> > > +}
> > > +
> > > +static const struct thermal_zone_of_device_ops mtk_thermal_ops = {
> > > + .get_temp = mtk_read_temp,
> >
> > On v4.3-rc1, this now causes a compile warning, since the prototype
> > for get_temp was changed to:
> >
> > int (*get_temp)(void *, int *);
> >
> > by:
> > commit 17e8351a77397e8a83727eb17e3a3e9b8ab5257a
> > thermal: consistently use int for temperatures
>
> It is actually a little worse than a warning. This actually causes a
> crash on boot.
> Sascha, can you send out a rebased patch set on v4.3-rc1?
Yes, I'll send out a new version tomorrow. I am currently quite busy
with another project.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web