Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1231598 > unrolled thread

[PATCH 0/7] net: netcp: a set of bug fixes

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/7] net: netcp: a set of bug fixes Murali Karicheri <m-karicheri2@ti.com> - 2015-09-23 19:40 +0200
    [PATCH 3/7] net: netcp: move netcp_register_interface() to after attach module Murali Karicheri <m-karicheri2@ti.com> - 2015-09-23 19:40 +0200
    Re: [PATCH 0/7] net: netcp: a set of bug fixes David Miller <davem@davemloft.net> - 2015-09-23 23:40 +0200
    Re: [PATCH 0/7] net: netcp: a set of bug fixes Murali Karicheri <m-karicheri2@ti.com> - 2015-09-25 15:40 +0200

#1231598 — [PATCH 0/7] net: netcp: a set of bug fixes

This patch series fixes a set of issues in netcp driver seen during internal
testing of the driver. While at it, do some clean up as well.

The fixes are tested on K2HK, K2L and K2E EVMs and the boot up logs can be
seen at

 http://pastebin.ubuntu.com/12533100/

Murali Karicheri (6):
  net: netcp: remove dead code from the driver
  net: netcp: move netcp_register_interface() to after attach module
  net: netcp: add error check to netcp_allocate_rx_buf()
  net: netcp: check for interface handle in netcp_module_probe()
  net: netcp: allocate buffers to desc before re-enable interrupt
  net: netcp: fix deadlock reported by lockup detector

WingMan Kwok (1):
  net: netcp: ethss: fix error in calling sgmii api with incorrect
    offset

 drivers/net/ethernet/ti/netcp_core.c  | 74 +++++++++++++++++------------------
 drivers/net/ethernet/ti/netcp_ethss.c | 47 ++++++++++------------
 2 files changed, 55 insertions(+), 66 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1231599 — [PATCH 3/7] net: netcp: move netcp_register_interface() to after attach module

The netcp interface is not fully initialized before attach the module
to the interface. For example, the tx pipe/rx pipe is initialized
in ethss module as part of attach(). So until this is complete, the
interface can't be registered.  So move registration of interface to
net device outside the current loop that attaches the modules to the
interface.

Signed-off-by: Murali Karicheri <m-karicheri2@ti.com>
---
 drivers/net/ethernet/ti/netcp_core.c | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/ti/netcp_core.c b/drivers/net/ethernet/ti/netcp_core.c
index c0bc4b9..cf693de 100644
--- a/drivers/net/ethernet/ti/netcp_core.c
+++ b/drivers/net/ethernet/ti/netcp_core.c
@@ -291,13 +291,6 @@ static int netcp_module_probe(struct netcp_device *netcp_device,
 			    interface_list) {
 		struct netcp_intf_modpriv *intf_modpriv;
 
-		/* If interface not registered then register now */
-		if (!netcp_intf->netdev_registered)
-			ret = netcp_register_interface(netcp_intf);
-
-		if (ret)
-			return -ENODEV;
-
 		intf_modpriv = devm_kzalloc(dev, sizeof(*intf_modpriv),
 					    GFP_KERNEL);
 		if (!intf_modpriv)
@@ -323,6 +316,18 @@ static int netcp_module_probe(struct netcp_device *netcp_device,
 			continue;
 		}
 	}
+
+	/* Now register the interface with netdev */
+	list_for_each_entry(netcp_intf,
+			    &netcp_device->interface_head,
+			    interface_list) {
+		/* If interface not registered then register now */
+		if (!netcp_intf->netdev_registered) {
+			ret = netcp_register_interface(netcp_intf);
+			if (ret)
+				return -ENODEV;
+		}
+	}
 	return 0;
 }
 
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1231743

From: Murali Karicheri <m-karicheri2@ti.com>
Date: Wed, 23 Sep 2015 13:37:04 -0400

> This patch series fixes a set of issues in netcp driver seen during internal
> testing of the driver. While at it, do some clean up as well.
> 
> The fixes are tested on K2HK, K2L and K2E EVMs and the boot up logs can be
> seen at
> 
>  http://pastebin.ubuntu.com/12533100/

Series applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1232825

On 09/23/2015 01:37 PM, Murali Karicheri wrote:
> This patch series fixes a set of issues in netcp driver seen during internal
> testing of the driver. While at it, do some clean up as well.
>
> The fixes are tested on K2HK, K2L and K2E EVMs and the boot up logs can be
> seen at
>
>   http://pastebin.ubuntu.com/12533100/
>
> Murali Karicheri (6):
>    net: netcp: remove dead code from the driver
>    net: netcp: move netcp_register_interface() to after attach module
>    net: netcp: add error check to netcp_allocate_rx_buf()
>    net: netcp: check for interface handle in netcp_module_probe()
>    net: netcp: allocate buffers to desc before re-enable interrupt
>    net: netcp: fix deadlock reported by lockup detector
>
> WingMan Kwok (1):
>    net: netcp: ethss: fix error in calling sgmii api with incorrect
>      offset
>
>   drivers/net/ethernet/ti/netcp_core.c  | 74 +++++++++++++++++------------------
>   drivers/net/ethernet/ti/netcp_ethss.c | 47 ++++++++++------------
>   2 files changed, 55 insertions(+), 66 deletions(-)
>
Stable Maintainers, Greg,

Please ignore this as NetCP driver is only enabled in v4.2 and I was 
initially thinking it was in v4.1. So you don't need this for any stable 
release such as v4.1.x

Sorry for the noise.

Thanks
-- 
Murali Karicheri
Linux Kernel, Keystone
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web