Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230189 > unrolled thread

Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool

Started byJohannes Berg <johannes@sipsolutions.net>
First post2015-09-22 15:30 +0200
Last post2015-09-23 15:40 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool Johannes Berg <johannes@sipsolutions.net> - 2015-09-22 15:30 +0200
    Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool Yaowei Bai <bywxiaobai@163.com> - 2015-09-23 15:40 +0200

#1230189 — Re: [PATCH 4/4] sound/core/seq: make prioq_match return bool

FromJohannes Berg <johannes@sipsolutions.net>
Date2015-09-22 15:30 +0200
SubjectRe: [PATCH 4/4] sound/core/seq: make prioq_match return bool
Message-ID<qbvNU-6Aq-27@gated-at.bofh.it>
On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote:
> On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote:
> > 
> > > -static inline int prioq_match(struct snd_seq_event_cell *cell,
> > > +static inline bool prioq_match(struct snd_seq_event_cell *cell,
> > >  			      int client, int timestamp)
> > 
> > I think you should fix up the indentation now.
> 
> Sorry, I'm quite a new guy to linux kernel. I think you mean this 
> patch is not appropriate, right?
> 

No, the change itself is fine, but you should fix the indentation there
so it lines up properly after your change.

johannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1231446

FromYaowei Bai <bywxiaobai@163.com>
Date2015-09-23 15:40 +0200
Message-ID<qbSr9-5Br-23@gated-at.bofh.it>
In reply to#1230189
On Tue, Sep 22, 2015 at 03:28:12PM +0200, Johannes Berg wrote:
> On Tue, 2015-09-22 at 21:22 +0800, Yaowei Bai wrote:
> > On Mon, Sep 21, 2015 at 04:11:00PM +0200, Johannes Berg wrote:
> > > 
> > > > -static inline int prioq_match(struct snd_seq_event_cell *cell,
> > > > +static inline bool prioq_match(struct snd_seq_event_cell *cell,
> > > >  			      int client, int timestamp)
> > > 
> > > I think you should fix up the indentation now.
> > 
> > Sorry, I'm quite a new guy to linux kernel. I think you mean this 
> > patch is not appropriate, right?
> > 
> 
> No, the change itself is fine, but you should fix the indentation there
> so it lines up properly after your change.

OK, will send it ASAP. Thanks.

> 
> johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web