Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1231145 > unrolled thread

[PATCH 06/15] devm_memunmap: use devres_release()

Started byDan Williams <dan.j.williams@intel.com>
First post2015-09-23 06:50 +0200
Last post2015-09-24 17:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 06/15] devm_memunmap: use devres_release() Dan Williams <dan.j.williams@intel.com> - 2015-09-23 06:50 +0200
    Re: [PATCH 06/15] devm_memunmap: use devres_release() Christoph Hellwig <hch@infradead.org> - 2015-09-24 17:20 +0200

#1231145 — [PATCH 06/15] devm_memunmap: use devres_release()

FromDan Williams <dan.j.williams@intel.com>
Date2015-09-23 06:50 +0200
Subject[PATCH 06/15] devm_memunmap: use devres_release()
Message-ID<qbKae-20h-25@gated-at.bofh.it>
Remove open coded call to memunmap.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 kernel/memremap.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/kernel/memremap.c b/kernel/memremap.c
index 72b0c66628b6..0756273437e0 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -131,9 +131,8 @@ EXPORT_SYMBOL(devm_memremap);
 
 void devm_memunmap(struct device *dev, void *addr)
 {
-	WARN_ON(devres_destroy(dev, devm_memremap_release, devm_memremap_match,
-			       addr));
-	memunmap(addr);
+	WARN_ON(devres_release(dev, devm_memremap_release,
+				devm_memremap_match, addr));
 }
 EXPORT_SYMBOL(devm_memunmap);
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1232182

FromChristoph Hellwig <hch@infradead.org>
Date2015-09-24 17:20 +0200
Message-ID<qcgtt-6OZ-15@gated-at.bofh.it>
In reply to#1231145
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web