Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1231014 > unrolled thread
| Started by | Luis Henriques <luis.henriques@canonical.com> |
|---|---|
| First post | 2015-09-23 00:40 +0200 |
| Last post | 2015-09-24 08:30 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 3.10 02/20] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required Luis Henriques <luis.henriques@canonical.com> - 2015-09-23 00:40 +0200
Re: [PATCH 3.10 02/20] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required Markus Pargmann <mpa@pengutronix.de> - 2015-09-24 08:30 +0200
| From | Luis Henriques <luis.henriques@canonical.com> |
|---|---|
| Date | 2015-09-23 00:40 +0200 |
| Subject | Re: [PATCH 3.10 02/20] iio: bmg160: IIO_BUFFER and IIO_TRIGGERED_BUFFER are required |
| Message-ID | <qbEoa-26P-29@gated-at.bofh.it> |
On Sat, Sep 19, 2015 at 10:27:17AM -0700, Greg Kroah-Hartman wrote: > 3.10-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Markus Pargmann <mpa@pengutronix.de> > > commit 06d2f6ca5a38abe92f1f3a132b331eee773868c3 upstream. > > This patch adds selects for IIO_BUFFER and IIO_TRIGGERED_BUFFER. Without > IIO_BUFFER, the driver does not compile. > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > Signed-off-by: Jonathan Cameron <jic23@kernel.org> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > drivers/iio/gyro/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > --- a/drivers/iio/gyro/Kconfig > +++ b/drivers/iio/gyro/Kconfig > @@ -73,7 +73,8 @@ config IIO_ST_GYRO_SPI_3AXIS > config ITG3200 I know it's a bit too late as this kernel has been released already, but this patch doesn't look right to me. The original patch is changing the BMG160 driver, not the ITG3200. The same applies to the 3.14 kernel -- it's changing the wrong driver. Cheers, -- Luís > tristate "InvenSense ITG3200 Digital 3-Axis Gyroscope I2C driver" > depends on I2C > - select IIO_TRIGGERED_BUFFER if IIO_BUFFER > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > help > Say yes here to add support for the InvenSense ITG3200 digital > 3-axis gyroscope sensor. > > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Markus Pargmann <mpa@pengutronix.de> |
|---|---|
| Date | 2015-09-24 08:30 +0200 |
| Message-ID | <qc8cy-3kh-15@gated-at.bofh.it> |
| In reply to | #1231014 |
[Multipart message — attachments visible in raw view] — view raw
Hi, On Tue, Sep 22, 2015 at 11:30:25PM +0100, Luis Henriques wrote: > On Sat, Sep 19, 2015 at 10:27:17AM -0700, Greg Kroah-Hartman wrote: > > 3.10-stable review patch. If anyone has any objections, please let me know. > > > > ------------------ > > > > From: Markus Pargmann <mpa@pengutronix.de> > > > > commit 06d2f6ca5a38abe92f1f3a132b331eee773868c3 upstream. > > > > This patch adds selects for IIO_BUFFER and IIO_TRIGGERED_BUFFER. Without > > IIO_BUFFER, the driver does not compile. > > > > Signed-off-by: Markus Pargmann <mpa@pengutronix.de> > > Reviewed-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> > > Signed-off-by: Jonathan Cameron <jic23@kernel.org> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > --- > > drivers/iio/gyro/Kconfig | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > --- a/drivers/iio/gyro/Kconfig > > +++ b/drivers/iio/gyro/Kconfig > > @@ -73,7 +73,8 @@ config IIO_ST_GYRO_SPI_3AXIS > > config ITG3200 > > I know it's a bit too late as this kernel has been released already, > but this patch doesn't look right to me. The original patch is > changing the BMG160 driver, not the ITG3200. > > The same applies to the 3.14 kernel -- it's changing the wrong > driver. Thanks, this is right. I didn't notice this but the driver was introduced in 3.18: 22b46c45fb9b (iio:gyro:bmg160 Gyro Sensor driver) Best Regards, Markus > > Cheers, > -- > Luís > > > tristate "InvenSense ITG3200 Digital 3-Axis Gyroscope I2C driver" > > depends on I2C > > - select IIO_TRIGGERED_BUFFER if IIO_BUFFER > > + select IIO_BUFFER > > + select IIO_TRIGGERED_BUFFER > > help > > Say yes here to add support for the InvenSense ITG3200 digital > > 3-axis gyroscope sensor. > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe stable" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web