Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1230958 > unrolled thread

Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Lee Jones <lee.jones@linaro.org> - 2015-09-22 23:10 +0200
    Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag Sudeep Holla <sudeep.holla@arm.com> - 2015-09-23 11:00 +0200

#1230958 — Re: [PATCH 07/17] input: tegra-kbc: drop use of IRQF_NO_SUSPEND flag

On Mon, 21 Sep 2015, Dmitry Torokhov wrote:

> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
> > The $SUBJECT is not correct.
> >
> >> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
> >> no need to use IRQF_NO_SUSPEND while registering the interrupt.
> >>
> >> This patch removes the use of IRQF_NO_SUSPEND flag.
> >>
> >> Cc: Samuel Ortiz <sameo@linux.intel.com>
> >> Cc: Lee Jones <lee.jones@linaro.org>
> >> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> >> ---
> >>  drivers/mfd/qcom_rpm.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > ... code is fine though:
> >
> > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Please re-submit with the subject line fixed.
> 
> What's wrong with the subject?

This patch has nothing to do with Input and the first word of the
explanatory sentence should start with an uppercase character.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1231260

On 22/09/15 22:08, Lee Jones wrote:
> On Mon, 21 Sep 2015, Dmitry Torokhov wrote:
>
>> On Mon, Sep 21, 2015 at 4:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
>>> The $SUBJECT is not correct.
>>>
>>>> The driver handles wakeup irq correctly using irq_set_irq_wake. There's
>>>> no need to use IRQF_NO_SUSPEND while registering the interrupt.
>>>>
>>>> This patch removes the use of IRQF_NO_SUSPEND flag.
>>>>
>>>> Cc: Samuel Ortiz <sameo@linux.intel.com>
>>>> Cc: Lee Jones <lee.jones@linaro.org>
>>>> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>>>> ---
>>>>   drivers/mfd/qcom_rpm.c | 2 +-
>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> ... code is fine though:
>>>
>>> Acked-by: Lee Jones <lee.jones@linaro.org>
>>>
>>> Please re-submit with the subject line fixed.
>>
>> What's wrong with the subject?
>
> This patch has nothing to do with Input and the first word of the
> explanatory sentence should start with an uppercase character.
>

Ah my stupid mistake, I didn't realize it. Sorry for the noise, will
fix it and send.

Regards,
Sudeep
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web