Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1230944 > unrolled thread

Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

Started by"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
First post2015-09-22 23:00 +0200
Last post2015-09-24 06:50 +0200
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-09-22 23:00 +0200
    Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage Patrick Marlier <patrick.marlier@gmail.com> - 2015-09-23 20:00 +0200
      Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-09-24 06:50 +0200

#1230944 — Re: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage

From"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date2015-09-22 23:00 +0200
SubjectRe: [PATCH tip/core/rcu 3/4] md/bitmap: Fix list_entry_rcu usage
Message-ID<qbCPo-8bs-9@gated-at.bofh.it>
On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote:
> On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote:

[ . . . ]

> > Paul,
> > 
> > This sounds good to me. It should fix the performance issue (will
> > check with my benchmark).
> 
> Thank you, looking forward to seeing the results!

Just following up -- how is the benchmarking going?

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1231614

FromPatrick Marlier <patrick.marlier@gmail.com>
Date2015-09-23 20:00 +0200
Message-ID<qbWuL-2YN-45@gated-at.bofh.it>
In reply to#1230944
On 09/22/2015 10:50 PM, Paul E. McKenney wrote:
> On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote:
>> On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote:
>
> [ . . . ]
>
>>> Paul,
>>>
>>> This sounds good to me. It should fix the performance issue (will
>>> check with my benchmark).
>>
>> Thank you, looking forward to seeing the results!
>
> Just following up -- how is the benchmarking going?

Note that in my module I am using the kernel version 3.16.0-31 (I ported 
your change).
Here the results of my benchmark that tests rculist in the case of read 
only.

# 1st column : The number of threads
# 2nd : ops/s the original version
# 3rd : ops/s your version with lockless_dereference
1 883923 1747554
2 1741441 3543062
3 2462360 5103647
4 3437273 7176608
6 5155803 9812348
8 6718111 13330050
10 8519227 17458294
12 9773632 20298897
14 11555198 23191424
16 11643264 25125712

I get same performance with my patch.
So indeed it fixes the performance problem I was seeing.

Thanks a lot!
--
Pat
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]


#1231851

From"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Date2015-09-24 06:50 +0200
Message-ID<qc6DL-ZJ-1@gated-at.bofh.it>
In reply to#1231614
On Wed, Sep 23, 2015 at 07:57:53PM +0200, Patrick Marlier wrote:
> 
> On 09/22/2015 10:50 PM, Paul E. McKenney wrote:
> >On Sun, Sep 13, 2015 at 09:10:24AM -0700, Paul E. McKenney wrote:
> >>On Sun, Sep 13, 2015 at 12:06:33PM +0200, Patrick Marlier wrote:
> >
> >[ . . . ]
> >
> >>>Paul,
> >>>
> >>>This sounds good to me. It should fix the performance issue (will
> >>>check with my benchmark).
> >>
> >>Thank you, looking forward to seeing the results!
> >
> >Just following up -- how is the benchmarking going?
> 
> Note that in my module I am using the kernel version 3.16.0-31 (I
> ported your change).
> Here the results of my benchmark that tests rculist in the case of
> read only.
> 
> # 1st column : The number of threads
> # 2nd : ops/s the original version
> # 3rd : ops/s your version with lockless_dereference
> 1 883923 1747554
> 2 1741441 3543062
> 3 2462360 5103647
> 4 3437273 7176608
> 6 5155803 9812348
> 8 6718111 13330050
> 10 8519227 17458294
> 12 9773632 20298897
> 14 11555198 23191424
> 16 11643264 25125712
> 
> I get same performance with my patch.
> So indeed it fixes the performance problem I was seeing.

Nice, thank you!!!

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web