Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1221581 > unrolled thread

[PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value

Started byAzael Avalos <coproscefalo@gmail.com>
First post2015-09-09 19:30 +0200
Last post2015-09-19 00:20 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value Azael Avalos <coproscefalo@gmail.com> - 2015-09-09 19:30 +0200
    Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value Darren Hart <dvhart@infradead.org> - 2015-09-18 23:40 +0200
      Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value Azael Avalos <coproscefalo@gmail.com> - 2015-09-18 23:50 +0200
        Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value Darren Hart <dvhart@infradead.org> - 2015-09-19 00:20 +0200
          Re: [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value Azael Avalos <coproscefalo@gmail.com> - 2015-09-19 00:20 +0200

#1221581 — [PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value

FromAzael Avalos <coproscefalo@gmail.com>
Date2015-09-09 19:30 +0200
Subject[PATCH 2/2] toshiba_acpi: Change default Hotkey enabling value
Message-ID<q6Rm2-1gb-15@gated-at.bofh.it>
The driver currently uses the hotkey enabling value of 0x09 to enable
hotkey events, but windows uses a different value (0x01).

All Toshiba laptops accept the following "hotkey" parameters:
0x01 - Enable hotkey and system events.
0x03 - Enable system events only.
0x09 - Enable hotkey events only.
0x0b - Disable (hotkey and system) events.

This patch changes the default hotkey enabling value from 0x09 to 0x01,
enabling both the hotkey and system events.

Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
---
 drivers/platform/x86/toshiba_acpi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 5510d3f..803e967 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -131,7 +131,7 @@ MODULE_LICENSE("GPL");
 /* Field definitions */
 #define HCI_ACCEL_MASK			0x7fff
 #define HCI_HOTKEY_DISABLE		0x0b
-#define HCI_HOTKEY_ENABLE		0x09
+#define HCI_HOTKEY_ENABLE		0x01
 #define HCI_HOTKEY_SPECIAL_FUNCTIONS	0x10
 #define HCI_LCD_BRIGHTNESS_BITS		3
 #define HCI_LCD_BRIGHTNESS_SHIFT	(16-HCI_LCD_BRIGHTNESS_BITS)
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1228294

FromDarren Hart <dvhart@infradead.org>
Date2015-09-18 23:40 +0200
Message-ID<qabxT-6k6-9@gated-at.bofh.it>
In reply to#1221581
On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
> The driver currently uses the hotkey enabling value of 0x09 to enable
> hotkey events, but windows uses a different value (0x01).
> 
> All Toshiba laptops accept the following "hotkey" parameters:
> 0x01 - Enable hotkey and system events.
> 0x03 - Enable system events only.
> 0x09 - Enable hotkey events only.
> 0x0b - Disable (hotkey and system) events.
> 
> This patch changes the default hotkey enabling value from 0x09 to 0x01,
> enabling both the hotkey and system events.
> 
> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>

Queued to testing for 4.4.

Let me know if you were expecting 4.3....

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228301

FromAzael Avalos <coproscefalo@gmail.com>
Date2015-09-18 23:50 +0200
Message-ID<qabHz-6x4-13@gated-at.bofh.it>
In reply to#1228294
Hi Darren,

2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>:
> On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
>> The driver currently uses the hotkey enabling value of 0x09 to enable
>> hotkey events, but windows uses a different value (0x01).
>>
>> All Toshiba laptops accept the following "hotkey" parameters:
>> 0x01 - Enable hotkey and system events.
>> 0x03 - Enable system events only.
>> 0x09 - Enable hotkey events only.
>> 0x0b - Disable (hotkey and system) events.
>>
>> This patch changes the default hotkey enabling value from 0x09 to 0x01,
>> enabling both the hotkey and system events.
>>
>> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
>
> Queued to testing for 4.4.
>
> Let me know if you were expecting 4.3....

Nope, just the first two fixes were meant for 4.3, the rest
is 4.4 material, I just wanted to send them early.

>
> --
> Darren Hart
> Intel Open Source Technology Center


Cheers
Azael



-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228318

FromDarren Hart <dvhart@infradead.org>
Date2015-09-19 00:20 +0200
Message-ID<qacaB-7wO-7@gated-at.bofh.it>
In reply to#1228301
On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote:
> Hi Darren,
> 
> 2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>:
> > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
> >> The driver currently uses the hotkey enabling value of 0x09 to enable
> >> hotkey events, but windows uses a different value (0x01).
> >>
> >> All Toshiba laptops accept the following "hotkey" parameters:
> >> 0x01 - Enable hotkey and system events.
> >> 0x03 - Enable system events only.
> >> 0x09 - Enable hotkey events only.
> >> 0x0b - Disable (hotkey and system) events.
> >>
> >> This patch changes the default hotkey enabling value from 0x09 to 0x01,
> >> enabling both the hotkey and system events.
> >>
> >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
> >
> > Queued to testing for 4.4.
> >
> > Let me know if you were expecting 4.3....
> 
> Nope, just the first two fixes were meant for 4.3, the rest
> is 4.4 material, I just wanted to send them early.

OK, check mainline please, everything I plan to push for 4.3 is now there.
Please confirm it has all you expected.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228324

FromAzael Avalos <coproscefalo@gmail.com>
Date2015-09-19 00:20 +0200
Message-ID<qacaB-7wO-11@gated-at.bofh.it>
In reply to#1228318
Hi Darren,

2015-09-18 16:14 GMT-06:00 Darren Hart <dvhart@infradead.org>:
> On Fri, Sep 18, 2015 at 03:45:05PM -0600, Azael Avalos wrote:
>> Hi Darren,
>>
>> 2015-09-18 15:37 GMT-06:00 Darren Hart <dvhart@infradead.org>:
>> > On Wed, Sep 09, 2015 at 11:28:20AM -0600, Azael Avalos wrote:
>> >> The driver currently uses the hotkey enabling value of 0x09 to enable
>> >> hotkey events, but windows uses a different value (0x01).
>> >>
>> >> All Toshiba laptops accept the following "hotkey" parameters:
>> >> 0x01 - Enable hotkey and system events.
>> >> 0x03 - Enable system events only.
>> >> 0x09 - Enable hotkey events only.
>> >> 0x0b - Disable (hotkey and system) events.
>> >>
>> >> This patch changes the default hotkey enabling value from 0x09 to 0x01,
>> >> enabling both the hotkey and system events.
>> >>
>> >> Signed-off-by: Azael Avalos <coproscefalo@gmail.com>
>> >
>> > Queued to testing for 4.4.
>> >
>> > Let me know if you were expecting 4.3....
>>
>> Nope, just the first two fixes were meant for 4.3, the rest
>> is 4.4 material, I just wanted to send them early.
>
> OK, check mainline please, everything I plan to push for 4.3 is now there.
> Please confirm it has all you expected.

Yup, everything is in there, thanks.


-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web