Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1221589 > unrolled thread
| Started by | Azael Avalos <coproscefalo@gmail.com> |
|---|---|
| First post | 2015-09-09 19:40 +0200 |
| Last post | 2015-09-19 00:00 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion Azael Avalos <coproscefalo@gmail.com> - 2015-09-09 19:40 +0200
Re: [PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion Darren Hart <dvhart@infradead.org> - 2015-09-19 00:00 +0200
| From | Azael Avalos <coproscefalo@gmail.com> |
|---|---|
| Date | 2015-09-09 19:40 +0200 |
| Subject | [PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion |
| Message-ID | <q6RvI-1rs-9@gated-at.bofh.it> |
This patch adds the 0x prefix to the values printed by such function, the values are already being printed in hex, but without the prefix, causing confussion, even though the file under Documentation/ABI clearly states that hey are hex values. Simply add the 0x prefix to avoid such confussion. Signed-off-by: Azael Avalos <coproscefalo@gmail.com> --- drivers/platform/x86/toshiba_acpi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c index 9f7ced1..50a2116 100644 --- a/drivers/platform/x86/toshiba_acpi.c +++ b/drivers/platform/x86/toshiba_acpi.c @@ -1669,10 +1669,10 @@ static ssize_t available_kbd_modes_show(struct device *dev, struct toshiba_acpi_dev *toshiba = dev_get_drvdata(dev); if (toshiba->kbd_type == 1) - return sprintf(buf, "%x %x\n", + return sprintf(buf, "0x%x 0x%x\n", SCI_KBD_MODE_FNZ, SCI_KBD_MODE_AUTO); - return sprintf(buf, "%x %x %x\n", + return sprintf(buf, "0x%x 0x%x 0x%x\n", SCI_KBD_MODE_AUTO, SCI_KBD_MODE_ON, SCI_KBD_MODE_OFF); } static DEVICE_ATTR_RO(available_kbd_modes); -- 2.5.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Darren Hart <dvhart@infradead.org> |
|---|---|
| Date | 2015-09-19 00:00 +0200 |
| Subject | Re: [PATCH 1/1] toshiba_acpi: Add 0x prefix to available_kbd_modes_show funtion |
| Message-ID | <qabRh-6KO-25@gated-at.bofh.it> |
| In reply to | #1221589 |
On Wed, Sep 09, 2015 at 11:30:09AM -0600, Azael Avalos wrote: > This patch adds the 0x prefix to the values printed by such function, the > values are already being printed in hex, but without the prefix, causing > confussion, even though the file under Documentation/ABI clearly states > that hey are hex values. > > Simply add the 0x prefix to avoid such confussion. > > Signed-off-by: Azael Avalos <coproscefalo@gmail.com> Queued to testing for 4.4. -- Darren Hart Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web