Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1228975 > unrolled thread

[PATCH 0/2] x86: NMI vs paravirt fixes

Started byAndy Lutomirski <luto@kernel.org>
First post2015-09-21 01:40 +0200
Last post2015-09-21 21:20 +0200
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH 0/2] x86: NMI vs paravirt fixes Andy Lutomirski <luto@kernel.org> - 2015-09-21 01:40 +0200
    Re: [PATCH 0/2] x86: NMI vs paravirt fixes Andy Lutomirski <luto@amacapital.net> - 2015-09-21 21:20 +0200

#1228975 — [PATCH 0/2] x86: NMI vs paravirt fixes

FromAndy Lutomirski <luto@kernel.org>
Date2015-09-21 01:40 +0200
Subject[PATCH 0/2] x86: NMI vs paravirt fixes
Message-ID<qaWn7-6bs-13@gated-at.bofh.it>
These are for x86/urgent.

This fixes at least one problem that Sasha can trigger using some
crazy configuration + Trinity.  I can't reproduce the full file of
nastiness that he's seeing, but these patches both look legit to me,
they fix what look like real bugs, and they seem to help Sasha's
tests.

Patch 1 is ugly.  Feel free to tell me to shove the asm into the
entry asm files, although that will involve duplicating it for
32-bit and 64-bit kernels.

Andy Lutomirski (2):
  x86/paravirt: Replace the paravirt nop with a bona fide empty function
  x86/nmi/64: Fix a paravirt stack-clobbering bug in the NMI code

 arch/x86/entry/entry_64.S  | 16 +++++++++++++++-
 arch/x86/kernel/paravirt.c | 16 ++++++++++++----
 2 files changed, 27 insertions(+), 5 deletions(-)

-- 
2.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]


#1229675

FromAndy Lutomirski <luto@amacapital.net>
Date2015-09-21 21:20 +0200
Message-ID<qbeN3-7m5-7@gated-at.bofh.it>
In reply to#1228975
On Sun, Sep 20, 2015 at 4:32 PM, Andy Lutomirski <luto@kernel.org> wrote:
> These are for x86/urgent.
>
> This fixes at least one problem that Sasha can trigger using some
> crazy configuration + Trinity.  I can't reproduce the full file of
> nastiness that he's seeing, but these patches both look legit to me,
> they fix what look like real bugs, and they seem to help Sasha's
> tests.
>
> Patch 1 is ugly.  Feel free to tell me to shove the asm into the
> entry asm files, although that will involve duplicating it for
> 32-bit and 64-bit kernels.

It turns out that Sasha had noreplace-paravirt on, which is probably
how he was able to hit these reliably.

They're still bugs, though.

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web