Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1228833 > unrolled thread
| Started by | Lee Jones <lee.jones@linaro.org> |
|---|---|
| First post | 2015-09-20 06:30 +0200 |
| Last post | 2015-09-21 19:10 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mfd: tps6105x: Fix NULL pointer access. Lee Jones <lee.jones@linaro.org> - 2015-09-20 06:30 +0200
Re: [PATCH] mfd: tps6105x: Fix NULL pointer access. Grigoryev Denis <grigoryev@fastwel.ru> - 2015-09-21 13:30 +0200
[PATCH v2] mfd: tps6105x: Fix NULL pointer access. Grigoryev Denis <grigoryev@fastwel.ru> - 2015-09-21 15:50 +0200
Re: [PATCH v2] mfd: tps6105x: Fix NULL pointer access. Grigoryev Denis <grigoryev@fastwel.ru> - 2015-09-21 19:10 +0200
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Date | 2015-09-20 06:30 +0200 |
| Subject | Re: [PATCH] mfd: tps6105x: Fix NULL pointer access. |
| Message-ID | <qaEqd-60W-1@gated-at.bofh.it> |
On Fri, 04 Sep 2015, Grigoryev Denis wrote:
> When tps6105x used in TPS6105X_MODE_SHUTDOWN mode the driver calls
> mfd_add_devices() with mfd_cell->name == NULL, that causes an ooops in
> platform_device_register() later.
>
> This patch reorders mfd_cell structures and makes code to call
> mfd_add_devices() with proper number of cells.
>
> Signed-off-by: Denis Grigoryev <grigoryev@spb.prosoft.ru>
> ---
> drivers/mfd/tps6105x.c | 16 +++++++++-------
> 1 file changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c
> index 5de95c2..be2c286 100644
> --- a/drivers/mfd/tps6105x.c
> +++ b/drivers/mfd/tps6105x.c
> @@ -124,11 +124,11 @@ static int tps6105x_startup(struct tps6105x *tps6105x)
> */
> static struct mfd_cell tps6105x_cells[] = {
> {
> - /* name will be runtime assigned */
> + .name = "tps6105x-gpio",
> .id = -1,
> },
> {
> - .name = "tps6105x-gpio",
> + /* name will be runtime assigned */
> .id = -1,
> },
> };
So you have 2 cells with identical .name's and identical .id's.
How does that work?
> @@ -138,6 +138,7 @@ static int tps6105x_probe(struct i2c_client *client,
> {
> struct tps6105x *tps6105x;
> struct tps6105x_platform_data *pdata;
> + int n_cells = ARRAY_SIZE(tps6105x_cells);
> int ret;
> int i;
>
> @@ -162,33 +163,34 @@ static int tps6105x_probe(struct i2c_client *client,
> case TPS6105X_MODE_SHUTDOWN:
> dev_info(&client->dev,
> "present, not used for anything, only GPIO\n");
> + n_cells = 1;
> break;
> case TPS6105X_MODE_TORCH:
> - tps6105x_cells[0].name = "tps6105x-leds";
> + tps6105x_cells[1].name = "tps6105x-leds";
Now you're over-writing cell names! I'd say this was a hack.
Please just create an entry for each device, like usual.
> dev_warn(&client->dev,
> "torch mode is unsupported\n");
> break;
> case TPS6105X_MODE_TORCH_FLASH:
> - tps6105x_cells[0].name = "tps6105x-flash";
> + tps6105x_cells[1].name = "tps6105x-flash";
> dev_warn(&client->dev,
> "flash mode is unsupported\n");
> break;
> case TPS6105X_MODE_VOLTAGE:
> - tps6105x_cells[0].name ="tps6105x-regulator";
> + tps6105x_cells[1].name = "tps6105x-regulator";
> break;
> default:
> break;
> }
>
> /* Set up and register the platform devices. */
> - for (i = 0; i < ARRAY_SIZE(tps6105x_cells); i++) {
> + for (i = 0; i < n_cells; i++) {
> /* One state holder for all drivers, this is simple */
> tps6105x_cells[i].platform_data = tps6105x;
> tps6105x_cells[i].pdata_size = sizeof(*tps6105x);
> }
>
> return mfd_add_devices(&client->dev, 0, tps6105x_cells,
> - ARRAY_SIZE(tps6105x_cells), NULL, 0, NULL);
> + n_cells, NULL, 0, NULL);
> }
>
> static int tps6105x_remove(struct i2c_client *client)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Grigoryev Denis <grigoryev@fastwel.ru> |
|---|---|
| Date | 2015-09-21 13:30 +0200 |
| Message-ID | <qb7se-5bY-31@gated-at.bofh.it> |
| In reply to | #1228833 |
CgpPbiBTYXQuLCAyMC8wOS8yMDE1INCyIDA1OjIwICswMTAwLCBMZWUgSm9uZXMgd3JvdGU6Cj4g T24gRnJpLCAwNCBTZXAgMjAxNSwgR3JpZ29yeWV2IERlbmlzIHdyb3RlOgo+IAo+ID4gV2hlbiB0 cHM2MTA1eCB1c2VkIGluIFRQUzYxMDVYX01PREVfU0hVVERPV04gbW9kZSB0aGUgZHJpdmVyIGNh bGxzCj4gPiBtZmRfYWRkX2RldmljZXMoKSB3aXRoIG1mZF9jZWxsLT5uYW1lID09IE5VTEwsIHRo YXQgY2F1c2VzIGFuIG9vb3BzIGluCj4gPiBwbGF0Zm9ybV9kZXZpY2VfcmVnaXN0ZXIoKSBsYXRl ci4KPiA+IAo+ID4gVGhpcyBwYXRjaCByZW9yZGVycyBtZmRfY2VsbCBzdHJ1Y3R1cmVzIGFuZCBt YWtlcyBjb2RlIHRvIGNhbGwKPiA+IG1mZF9hZGRfZGV2aWNlcygpIHdpdGggcHJvcGVyIG51bWJl ciBvZiBjZWxscy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogRGVuaXMgR3JpZ29yeWV2IDxncmln b3J5ZXZAc3BiLnByb3NvZnQucnU+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL21mZC90cHM2MTA1eC5j IHwgICAxNiArKysrKysrKystLS0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9u cygrKSwgNyBkZWxldGlvbnMoLSkKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3Rw czYxMDV4LmMgYi9kcml2ZXJzL21mZC90cHM2MTA1eC5jCj4gPiBpbmRleCA1ZGU5NWMyLi5iZTJj Mjg2IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9tZmQvdHBzNjEwNXguYwo+ID4gKysrIGIvZHJp dmVycy9tZmQvdHBzNjEwNXguYwo+ID4gQEAgLTEyNCwxMSArMTI0LDExIEBAIHN0YXRpYyBpbnQg dHBzNjEwNXhfc3RhcnR1cChzdHJ1Y3QgdHBzNjEwNXggKnRwczYxMDV4KQo+ID4gICAqLwo+ID4g IHN0YXRpYyBzdHJ1Y3QgbWZkX2NlbGwgdHBzNjEwNXhfY2VsbHNbXSA9IHsKPiA+ICAJewo+ID4g LQkJLyogbmFtZSB3aWxsIGJlIHJ1bnRpbWUgYXNzaWduZWQgKi8KPiA+ICsJCS5uYW1lID0gInRw czYxMDV4LWdwaW8iLAo+ID4gIAkJLmlkID0gLTEsCj4gPiAgCX0sCj4gPiAgCXsKPiA+IC0JCS5u YW1lID0gInRwczYxMDV4LWdwaW8iLAo+ID4gKwkJLyogbmFtZSB3aWxsIGJlIHJ1bnRpbWUgYXNz aWduZWQgKi8KPiA+ICAJCS5pZCA9IC0xLAo+ID4gIAl9LAo+ID4gIH07Cj4gCj4gU28geW91IGhh dmUgMiBjZWxscyB3aXRoIGlkZW50aWNhbCAubmFtZSdzIGFuZCBpZGVudGljYWwgLmlkJ3MuCj4g Cj4gSG93IGRvZXMgdGhhdCB3b3JrPwo+IAoKIE5vLiBIZXJlIGlzIHRoZSBmaXJzdCBjZWxsIHdp dGggLm5hbWUgPSAidHBzNjEwNXgtZ3BpbyIsIHRoZSBzZWNvbmQgb25lCmhhcyBubyBuYW1lIGFz c2lnbmVkLiBUaGUgbmFtZSBvZiBzZWNvbmQgY2VsbCAob3IgaXQncyBhYnNlbmNlKSB3aWxsIGJl CmNob3NlbiBpbiBydW50aW1lIGluIHN3aXRjaCgpIGJlbG93IGRlcGVuZGluZyBvbiBzZWxlY3Rl ZCBJQyBvcGVyYXRpb24KbW9kZS4KCiBUaGlzIHBhdGNoIGlzIGEgZml4IG9mIHBvc3NpYmxlIE5V TEwgcG9pbnRlciBhY2Nlc3MgSSBlbmNvdW50ZXJlZCB3aXRoCm1pbmltYWwgaW52YXNpb24gdG8g dGhlIGNvZGUuIEkgYXBvbG9naXplIGZvciB0b28gc2hvcnQgZGVzY3JpcHRpb24gdG8KdGhpcyBw YXRjaC4KCj4gPiBAQCAtMTM4LDYgKzEzOCw3IEBAIHN0YXRpYyBpbnQgdHBzNjEwNXhfcHJvYmUo c3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKPiA+ICB7Cj4gPiAgCXN0cnVjdCB0cHM2MTA1eAkJ CSp0cHM2MTA1eDsKPiA+ICAJc3RydWN0IHRwczYxMDV4X3BsYXRmb3JtX2RhdGEJKnBkYXRhOwo+ ID4gKwlpbnQgbl9jZWxscyA9IEFSUkFZX1NJWkUodHBzNjEwNXhfY2VsbHMpOwo+ID4gIAlpbnQg cmV0Owo+ID4gIAlpbnQgaTsKPiA+ICAKPiA+IEBAIC0xNjIsMzMgKzE2MywzNCBAQCBzdGF0aWMg aW50IHRwczYxMDV4X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4gPiAgCWNhc2Ug VFBTNjEwNVhfTU9ERV9TSFVURE9XTjoKPiA+ICAJCWRldl9pbmZvKCZjbGllbnQtPmRldiwKPiA+ ICAJCQkgInByZXNlbnQsIG5vdCB1c2VkIGZvciBhbnl0aGluZywgb25seSBHUElPXG4iKTsKPiA+ ICsJCW5fY2VsbHMgPSAxOwo+ID4gIAkJYnJlYWs7Cj4gPiAgCWNhc2UgVFBTNjEwNVhfTU9ERV9U T1JDSDoKPiA+IC0JCXRwczYxMDV4X2NlbGxzWzBdLm5hbWUgPSAidHBzNjEwNXgtbGVkcyI7Cj4g PiArCQl0cHM2MTA1eF9jZWxsc1sxXS5uYW1lID0gInRwczYxMDV4LWxlZHMiOwo+IAo+IE5vdyB5 b3UncmUgb3Zlci13cml0aW5nIGNlbGwgbmFtZXMhICBJJ2Qgc2F5IHRoaXMgd2FzIGEgaGFjay4K PgoKTm8uIEhlcmUgSSBhc3NpZ24gYSBuYW1lIHRvIHRoZSBzZWNvbmQgY2VsbC4gSXQncyBiZWVu IHVua25vd24gdW50aWwgSQpnZXQgZGVzaXJlZCBJQyBtb2RlLgoKPiBQbGVhc2UganVzdCBjcmVh dGUgYW4gZW50cnkgZm9yIGVhY2ggZGV2aWNlLCBsaWtlIHVzdWFsLgo+IAoKSGVyZSBpcyBvbmx5 IHR3byBkZXZpY2VzLiBUaGUgZmlyc3Qgb25lIGlzICJncGlvIiB3aGljaCBhbHdheXMgcHJlc2Vu dCwKdGhlIHNlY29uZCBvbmUgaXMgc2VsZWN0ZWQgZGVwZW5kaW5nIG9uIElDIG1vZGUuIEEgcGF0 Y2ggd2l0aCBhbiBlbnRyeQpmb3IgZWFjaCBkZXZpY2Ugd2lsbCBiZSB0b28gY29tcGxleCBmb3Ig YSBmaXguCgpJJ20gd29ya2luZyBvbiAiZmxhc2giIGZ1bmN0aW9uIGFuZCBEVCBiaW5kaW5ncyBm b3IgdGhpcyBkcml2ZXIgc28geW91CmNhbiByZWplY3QgdGhpcyBwYXRjaCBpZiB5b3UgbGlrZS4K Cj4gPiAgCQlkZXZfd2FybigmY2xpZW50LT5kZXYsCj4gPiAgCQkJICJ0b3JjaCBtb2RlIGlzIHVu c3VwcG9ydGVkXG4iKTsKPiA+ICAJCWJyZWFrOwo+ID4gIAljYXNlIFRQUzYxMDVYX01PREVfVE9S Q0hfRkxBU0g6Cj4gPiAtCQl0cHM2MTA1eF9jZWxsc1swXS5uYW1lID0gInRwczYxMDV4LWZsYXNo IjsKPiA+ICsJCXRwczYxMDV4X2NlbGxzWzFdLm5hbWUgPSAidHBzNjEwNXgtZmxhc2giOwo+ID4g IAkJZGV2X3dhcm4oJmNsaWVudC0+ZGV2LAo+ID4gIAkJCSAiZmxhc2ggbW9kZSBpcyB1bnN1cHBv cnRlZFxuIik7Cj4gPiAgCQlicmVhazsKPiA+ICAJY2FzZSBUUFM2MTA1WF9NT0RFX1ZPTFRBR0U6 Cj4gPiAtCQl0cHM2MTA1eF9jZWxsc1swXS5uYW1lID0idHBzNjEwNXgtcmVndWxhdG9yIjsKPiA+ ICsJCXRwczYxMDV4X2NlbGxzWzFdLm5hbWUgPSAidHBzNjEwNXgtcmVndWxhdG9yIjsKPiA+ICAJ CWJyZWFrOwo+ID4gIAlkZWZhdWx0Ogo+ID4gIAkJYnJlYWs7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJ LyogU2V0IHVwIGFuZCByZWdpc3RlciB0aGUgcGxhdGZvcm0gZGV2aWNlcy4gKi8KPiA+IC0JZm9y IChpID0gMDsgaSA8IEFSUkFZX1NJWkUodHBzNjEwNXhfY2VsbHMpOyBpKyspIHsKPiA+ICsJZm9y IChpID0gMDsgaSA8IG5fY2VsbHM7IGkrKykgewo+ID4gIAkJLyogT25lIHN0YXRlIGhvbGRlciBm b3IgYWxsIGRyaXZlcnMsIHRoaXMgaXMgc2ltcGxlICovCj4gPiAgCQl0cHM2MTA1eF9jZWxsc1tp XS5wbGF0Zm9ybV9kYXRhID0gdHBzNjEwNXg7Cj4gPiAgCQl0cHM2MTA1eF9jZWxsc1tpXS5wZGF0 YV9zaXplID0gc2l6ZW9mKCp0cHM2MTA1eCk7Cj4gPiAgCX0KPiA+ICAKPiA+ICAJcmV0dXJuIG1m ZF9hZGRfZGV2aWNlcygmY2xpZW50LT5kZXYsIDAsIHRwczYxMDV4X2NlbGxzLAo+ID4gLQkJCSAg ICAgICBBUlJBWV9TSVpFKHRwczYxMDV4X2NlbGxzKSwgTlVMTCwgMCwgTlVMTCk7Cj4gPiArCQkJ ICAgICAgIG5fY2VsbHMsIE5VTEwsIDAsIE5VTEwpOwo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMg aW50IHRwczYxMDV4X3JlbW92ZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50KQo+IAoKCg== -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Grigoryev Denis <grigoryev@fastwel.ru> |
|---|---|
| Date | 2015-09-21 15:50 +0200 |
| Subject | [PATCH v2] mfd: tps6105x: Fix NULL pointer access. |
| Message-ID | <qb9DI-8gq-21@gated-at.bofh.it> |
| In reply to | #1228833 |
V2hlbiB0cHM2MTA1eCB1c2VkIGluIFRQUzYxMDVYX01PREVfU0hVVERPV04gbW9kZSB0aGUgZHJp dmVyIGNhbGxzCm1mZF9hZGRfZGV2aWNlcygpIHdpdGggbWZkX2NlbGwtPm5hbWUgPT0gTlVMTCwg dGhhdCBjYXVzZXMgYW4gb29vcHMgaW4KcGxhdGZvcm1fZGV2aWNlX3JlZ2lzdGVyKCkgbGF0ZXIu CgpUaGlzIHBhdGNoIGFkZHMgYW4gbWZkX2NlbGwgZm9yIGVhY2ggcG9zc2libGUgbW9kZSB0aGVy ZWJ5IGV4Y2x1ZGluZyBydW50aW1lCi5uYW1lIGFzc2lnbm1lbnQuCgpTaWduZWQtb2ZmLWJ5OiBE ZW5pcyBHcmlnb3J5ZXYgPGdyaWdvcnlldkBmYXN0d2VsLnJ1PgotLS0KIGRyaXZlcnMvbWZkL3Rw czYxMDV4LmMgfCAgIDYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDM2IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3RwczYxMDV4LmMgYi9kcml2ZXJzL21mZC90cHM2 MTA1eC5jCmluZGV4IDVkZTk1YzIuLjRkYmZiNDUgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWZkL3Rw czYxMDV4LmMKKysrIGIvZHJpdmVycy9tZmQvdHBzNjEwNXguYwpAQCAtMTE5LDE3ICsxMTksMjUg QEAgc3RhdGljIGludCB0cHM2MTA1eF9zdGFydHVwKHN0cnVjdCB0cHM2MTA1eCAqdHBzNjEwNXgp CiB9CiAKIC8qCi0gKiBNRkQgY2VsbHMgLSB3ZSBoYXZlIG9uZSBjZWxsIHdoaWNoIGlzIHNlbGVj dGVkIG9wZXJhdGlvbgotICogbW9kZSwgYW5kIHdlIGFsd2F5cyBoYXZlIGEgR1BJTyBjZWxsLgot ICovCisgKiAgKiBNRkQgY2VsbHMgLSB3ZSBhbHdheXMgaGF2ZSBhIEdQSU8gY2VsbCBhbmQgd2Ug aGF2ZSBvbmUgY2VsbAorICogICAqIHdoaWNoIGlzIHNlbGVjdGVkIG9wZXJhdGlvbiBtb2RlLgor ICogICAgKi8KIHN0YXRpYyBzdHJ1Y3QgbWZkX2NlbGwgdHBzNjEwNXhfY2VsbHNbXSA9IHsKLQl7 Ci0JCS8qIG5hbWUgd2lsbCBiZSBydW50aW1lIGFzc2lnbmVkICovCi0JCS5pZCA9IC0xLAorCVtU UFM2MTA1WF9SRUcwX01PREVfU0hVVERPV05dICAgPSB7CisJCS5uYW1lCQkJPSAidHBzNjEwNXgt Z3BpbyIsCisJCS5pZAkJCT0gLTEsCisJfSwKKwlbVFBTNjEwNVhfUkVHMF9NT0RFX1RPUkNIXQk9 IHsKKwkJLm5hbWUJCQk9ICJ0cHM2MTA1eC1sZWRzIiwKKwkJLmlkCQkJPSAtMSwKKwl9LAorCVtU UFM2MTA1WF9SRUcwX01PREVfVE9SQ0hfRkxBU0hdID0geworCQkubmFtZQkJCT0gInRwczYxMDV4 LWZsYXNoIiwKKwkJLmlkCQkJPSAtMSwKIAl9LAotCXsKLQkJLm5hbWUgPSAidHBzNjEwNXgtZ3Bp byIsCi0JCS5pZCA9IC0xLAorCVtUUFM2MTA1WF9SRUcwX01PREVfVk9MVEFHRV0JPSB7CisJCS5u YW1lCQkJPSAidHBzNjEwNXgtcmVndWxhdG9yIiwKKwkJLmlkCQkJPSAtMSwKIAl9LAogfTsKIApA QCAtMTU3LDYgKzE2NSwxOCBAQCBzdGF0aWMgaW50IHRwczYxMDV4X3Byb2JlKHN0cnVjdCBpMmNf Y2xpZW50ICpjbGllbnQsCiAJCXJldHVybiByZXQ7CiAJfQogCisJLyogU2V0IHVwIGFuZCByZWdp c3RlciB0aGUgcGxhdGZvcm0gZGV2aWNlcy4gKi8KKwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0la RSh0cHM2MTA1eF9jZWxscyk7IGkrKykgeworCQkvKiBPbmUgc3RhdGUgaG9sZGVyIGZvciBhbGwg ZHJpdmVycywgdGhpcyBpcyBzaW1wbGUgKi8KKwkJdHBzNjEwNXhfY2VsbHNbaV0ucGxhdGZvcm1f ZGF0YSA9IHRwczYxMDV4OworCQl0cHM2MTA1eF9jZWxsc1tpXS5wZGF0YV9zaXplID0gc2l6ZW9m KCp0cHM2MTA1eCk7CisJfQorCisJcmV0ID0gbWZkX2FkZF9kZXZpY2VzKCZjbGllbnQtPmRldiwg LTEsIHRwczYxMDV4X2NlbGxzLAorCQkJICAgICAgMSwgTlVMTCwgMCwgTlVMTCk7CisJaWYgKHJl dCkKKwkJcmV0dXJuIHJldDsKKwogCS8qIFJlbW92ZSB3YXJuaW5nIHRleHRzIHdoZW4geW91IGlt cGxlbWVudCBuZXcgY2VsbCBkcml2ZXJzICovCiAJc3dpdGNoIChwZGF0YS0+bW9kZSkgewogCWNh c2UgVFBTNjEwNVhfTU9ERV9TSFVURE9XTjoKQEAgLTE2NCwzMSArMTg0LDIxIEBAIHN0YXRpYyBp bnQgdHBzNjEwNXhfcHJvYmUoc3RydWN0IGkyY19jbGllbnQgKmNsaWVudCwKIAkJCSAicHJlc2Vu dCwgbm90IHVzZWQgZm9yIGFueXRoaW5nLCBvbmx5IEdQSU9cbiIpOwogCQlicmVhazsKIAljYXNl IFRQUzYxMDVYX01PREVfVE9SQ0g6Ci0JCXRwczYxMDV4X2NlbGxzWzBdLm5hbWUgPSAidHBzNjEw NXgtbGVkcyI7Ci0JCWRldl93YXJuKCZjbGllbnQtPmRldiwKLQkJCSAidG9yY2ggbW9kZSBpcyB1 bnN1cHBvcnRlZFxuIik7Ci0JCWJyZWFrOwogCWNhc2UgVFBTNjEwNVhfTU9ERV9UT1JDSF9GTEFT SDoKLQkJdHBzNjEwNXhfY2VsbHNbMF0ubmFtZSA9ICJ0cHM2MTA1eC1mbGFzaCI7Ci0JCWRldl93 YXJuKCZjbGllbnQtPmRldiwKLQkJCSAiZmxhc2ggbW9kZSBpcyB1bnN1cHBvcnRlZFxuIik7Ci0J CWJyZWFrOwogCWNhc2UgVFBTNjEwNVhfTU9ERV9WT0xUQUdFOgotCQl0cHM2MTA1eF9jZWxsc1sw XS5uYW1lID0idHBzNjEwNXgtcmVndWxhdG9yIjsKKwkJcmV0ID0gbWZkX2FkZF9kZXZpY2VzKCZj bGllbnQtPmRldiwgLTEsCisJCQkJICAgICAgJnRwczYxMDV4X2NlbGxzW3BkYXRhLT5tb2RlXSwK KwkJCQkgICAgICAxLCBOVUxMLCAwLCBOVUxMKTsKIAkJYnJlYWs7CiAJZGVmYXVsdDoKKwkJZGV2 X3dhcm4oJmNsaWVudC0+ZGV2LCAiaW52YWxpZCBtb2RlOiAlZFxuIiwgcGRhdGEtPm1vZGUpOwog CQlicmVhazsKIAl9CiAKLQkvKiBTZXQgdXAgYW5kIHJlZ2lzdGVyIHRoZSBwbGF0Zm9ybSBkZXZp Y2VzLiAqLwotCWZvciAoaSA9IDA7IGkgPCBBUlJBWV9TSVpFKHRwczYxMDV4X2NlbGxzKTsgaSsr KSB7Ci0JCS8qIE9uZSBzdGF0ZSBob2xkZXIgZm9yIGFsbCBkcml2ZXJzLCB0aGlzIGlzIHNpbXBs ZSAqLwotCQl0cHM2MTA1eF9jZWxsc1tpXS5wbGF0Zm9ybV9kYXRhID0gdHBzNjEwNXg7Ci0JCXRw czYxMDV4X2NlbGxzW2ldLnBkYXRhX3NpemUgPSBzaXplb2YoKnRwczYxMDV4KTsKLQl9CisJaWYg KHJldCkKKwkJbWZkX3JlbW92ZV9kZXZpY2VzKCZjbGllbnQtPmRldik7CiAKLQlyZXR1cm4gbWZk X2FkZF9kZXZpY2VzKCZjbGllbnQtPmRldiwgMCwgdHBzNjEwNXhfY2VsbHMsCi0JCQkgICAgICAg QVJSQVlfU0laRSh0cHM2MTA1eF9jZWxscyksIE5VTEwsIDAsIE5VTEwpOworCXJldHVybiByZXQ7 CiB9CiAKIHN0YXRpYyBpbnQgdHBzNjEwNXhfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll bnQpCi0tIAoxLjcuMTAuNAoK -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Grigoryev Denis <grigoryev@fastwel.ru> |
|---|---|
| Date | 2015-09-21 19:10 +0200 |
| Subject | Re: [PATCH v2] mfd: tps6105x: Fix NULL pointer access. |
| Message-ID | <qbcLf-4tN-1@gated-at.bofh.it> |
| In reply to | #1229337 |
T2gsIHNvcnJ5LiBXaXRoIGZ1cnRoZXIgdGVzdGluZyBJIHJlYWxpemVkIHRoYXQgSSBtYWRlIGEg bWlzdGFrZSBhbmQKdHlwb3MuIEkgd2lsbCBzZW5kIHRoZSBwYXRjaCB2My4KCk15IGFwb2xvZ2ll cyBmb3IgdGhlIGZsb29kLiBJJ20gbmV3IGluIExLTUwuCgpPbiBNb24uLCAyMS8wOS8yMDE1IGF0 IDEzOjQxICswMDAwLCBHcmlnb3J5ZXYgRGVuaXMgd3JvdGU6Cj4gV2hlbiB0cHM2MTA1eCB1c2Vk IGluIFRQUzYxMDVYX01PREVfU0hVVERPV04gbW9kZSB0aGUgZHJpdmVyIGNhbGxzCj4gbWZkX2Fk ZF9kZXZpY2VzKCkgd2l0aCBtZmRfY2VsbC0+bmFtZSA9PSBOVUxMLCB0aGF0IGNhdXNlcyBhbiBv b29wcyBpbgo+IHBsYXRmb3JtX2RldmljZV9yZWdpc3RlcigpIGxhdGVyLgo+IAo+IFRoaXMgcGF0 Y2ggYWRkcyBhbiBtZmRfY2VsbCBmb3IgZWFjaCBwb3NzaWJsZSBtb2RlIHRoZXJlYnkgZXhjbHVk aW5nIHJ1bnRpbWUKPiAubmFtZSBhc3NpZ25tZW50Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IERlbmlz IEdyaWdvcnlldiA8Z3JpZ29yeWV2QGZhc3R3ZWwucnU+Cj4gLS0tCj4gIGRyaXZlcnMvbWZkL3Rw czYxMDV4LmMgfCAgIDYyICsrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMzYgaW5zZXJ0aW9ucygrKSwgMjYgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3RwczYxMDV4LmMgYi9kcml2ZXJzL21m ZC90cHM2MTA1eC5jCj4gaW5kZXggNWRlOTVjMi4uNGRiZmI0NSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL21mZC90cHM2MTA1eC5jCj4gKysrIGIvZHJpdmVycy9tZmQvdHBzNjEwNXguYwo+IEBAIC0x MTksMTcgKzExOSwyNSBAQCBzdGF0aWMgaW50IHRwczYxMDV4X3N0YXJ0dXAoc3RydWN0IHRwczYx MDV4ICp0cHM2MTA1eCkKPiAgfQo+ICAKPiAgLyoKPiAtICogTUZEIGNlbGxzIC0gd2UgaGF2ZSBv bmUgY2VsbCB3aGljaCBpcyBzZWxlY3RlZCBvcGVyYXRpb24KPiAtICogbW9kZSwgYW5kIHdlIGFs d2F5cyBoYXZlIGEgR1BJTyBjZWxsLgo+IC0gKi8KPiArICogICogTUZEIGNlbGxzIC0gd2UgYWx3 YXlzIGhhdmUgYSBHUElPIGNlbGwgYW5kIHdlIGhhdmUgb25lIGNlbGwKPiArICogICAqIHdoaWNo IGlzIHNlbGVjdGVkIG9wZXJhdGlvbiBtb2RlLgo+ICsgKiAgICAqLwo+ICBzdGF0aWMgc3RydWN0 IG1mZF9jZWxsIHRwczYxMDV4X2NlbGxzW10gPSB7Cj4gLQl7Cj4gLQkJLyogbmFtZSB3aWxsIGJl IHJ1bnRpbWUgYXNzaWduZWQgKi8KPiAtCQkuaWQgPSAtMSwKPiArCVtUUFM2MTA1WF9SRUcwX01P REVfU0hVVERPV05dICAgPSB7Cj4gKwkJLm5hbWUJCQk9ICJ0cHM2MTA1eC1ncGlvIiwKPiArCQku aWQJCQk9IC0xLAo+ICsJfSwKPiArCVtUUFM2MTA1WF9SRUcwX01PREVfVE9SQ0hdCT0gewo+ICsJ CS5uYW1lCQkJPSAidHBzNjEwNXgtbGVkcyIsCj4gKwkJLmlkCQkJPSAtMSwKPiArCX0sCj4gKwlb VFBTNjEwNVhfUkVHMF9NT0RFX1RPUkNIX0ZMQVNIXSA9IHsKPiArCQkubmFtZQkJCT0gInRwczYx MDV4LWZsYXNoIiwKPiArCQkuaWQJCQk9IC0xLAo+ICAJfSwKPiAtCXsKPiAtCQkubmFtZSA9ICJ0 cHM2MTA1eC1ncGlvIiwKPiAtCQkuaWQgPSAtMSwKPiArCVtUUFM2MTA1WF9SRUcwX01PREVfVk9M VEFHRV0JPSB7Cj4gKwkJLm5hbWUJCQk9ICJ0cHM2MTA1eC1yZWd1bGF0b3IiLAo+ICsJCS5pZAkJ CT0gLTEsCj4gIAl9LAo+ICB9Owo+ICAKPiBAQCAtMTU3LDYgKzE2NSwxOCBAQCBzdGF0aWMgaW50 IHRwczYxMDV4X3Byb2JlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQsCj4gIAkJcmV0dXJuIHJl dDsKPiAgCX0KPiAgCj4gKwkvKiBTZXQgdXAgYW5kIHJlZ2lzdGVyIHRoZSBwbGF0Zm9ybSBkZXZp Y2VzLiAqLwo+ICsJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUodHBzNjEwNXhfY2VsbHMpOyBp KyspIHsKPiArCQkvKiBPbmUgc3RhdGUgaG9sZGVyIGZvciBhbGwgZHJpdmVycywgdGhpcyBpcyBz aW1wbGUgKi8KPiArCQl0cHM2MTA1eF9jZWxsc1tpXS5wbGF0Zm9ybV9kYXRhID0gdHBzNjEwNXg7 Cj4gKwkJdHBzNjEwNXhfY2VsbHNbaV0ucGRhdGFfc2l6ZSA9IHNpemVvZigqdHBzNjEwNXgpOwo+ ICsJfQo+ICsKPiArCXJldCA9IG1mZF9hZGRfZGV2aWNlcygmY2xpZW50LT5kZXYsIC0xLCB0cHM2 MTA1eF9jZWxscywKPiArCQkJICAgICAgMSwgTlVMTCwgMCwgTlVMTCk7Cj4gKwlpZiAocmV0KQo+ ICsJCXJldHVybiByZXQ7Cj4gKwo+ICAJLyogUmVtb3ZlIHdhcm5pbmcgdGV4dHMgd2hlbiB5b3Ug aW1wbGVtZW50IG5ldyBjZWxsIGRyaXZlcnMgKi8KPiAgCXN3aXRjaCAocGRhdGEtPm1vZGUpIHsK PiAgCWNhc2UgVFBTNjEwNVhfTU9ERV9TSFVURE9XTjoKPiBAQCAtMTY0LDMxICsxODQsMjEgQEAg c3RhdGljIGludCB0cHM2MTA1eF9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+ICAJ CQkgInByZXNlbnQsIG5vdCB1c2VkIGZvciBhbnl0aGluZywgb25seSBHUElPXG4iKTsKPiAgCQli cmVhazsKPiAgCWNhc2UgVFBTNjEwNVhfTU9ERV9UT1JDSDoKPiAtCQl0cHM2MTA1eF9jZWxsc1sw XS5uYW1lID0gInRwczYxMDV4LWxlZHMiOwo+IC0JCWRldl93YXJuKCZjbGllbnQtPmRldiwKPiAt CQkJICJ0b3JjaCBtb2RlIGlzIHVuc3VwcG9ydGVkXG4iKTsKPiAtCQlicmVhazsKPiAgCWNhc2Ug VFBTNjEwNVhfTU9ERV9UT1JDSF9GTEFTSDoKPiAtCQl0cHM2MTA1eF9jZWxsc1swXS5uYW1lID0g InRwczYxMDV4LWZsYXNoIjsKPiAtCQlkZXZfd2FybigmY2xpZW50LT5kZXYsCj4gLQkJCSAiZmxh c2ggbW9kZSBpcyB1bnN1cHBvcnRlZFxuIik7Cj4gLQkJYnJlYWs7Cj4gIAljYXNlIFRQUzYxMDVY X01PREVfVk9MVEFHRToKPiAtCQl0cHM2MTA1eF9jZWxsc1swXS5uYW1lID0idHBzNjEwNXgtcmVn dWxhdG9yIjsKPiArCQlyZXQgPSBtZmRfYWRkX2RldmljZXMoJmNsaWVudC0+ZGV2LCAtMSwKPiAr CQkJCSAgICAgICZ0cHM2MTA1eF9jZWxsc1twZGF0YS0+bW9kZV0sCj4gKwkJCQkgICAgICAxLCBO VUxMLCAwLCBOVUxMKTsKPiAgCQlicmVhazsKPiAgCWRlZmF1bHQ6Cj4gKwkJZGV2X3dhcm4oJmNs aWVudC0+ZGV2LCAiaW52YWxpZCBtb2RlOiAlZFxuIiwgcGRhdGEtPm1vZGUpOwo+ICAJCWJyZWFr Owo+ICAJfQo+ICAKPiAtCS8qIFNldCB1cCBhbmQgcmVnaXN0ZXIgdGhlIHBsYXRmb3JtIGRldmlj ZXMuICovCj4gLQlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRSh0cHM2MTA1eF9jZWxscyk7IGkr Kykgewo+IC0JCS8qIE9uZSBzdGF0ZSBob2xkZXIgZm9yIGFsbCBkcml2ZXJzLCB0aGlzIGlzIHNp bXBsZSAqLwo+IC0JCXRwczYxMDV4X2NlbGxzW2ldLnBsYXRmb3JtX2RhdGEgPSB0cHM2MTA1eDsK PiAtCQl0cHM2MTA1eF9jZWxsc1tpXS5wZGF0YV9zaXplID0gc2l6ZW9mKCp0cHM2MTA1eCk7Cj4g LQl9Cj4gKwlpZiAocmV0KQo+ICsJCW1mZF9yZW1vdmVfZGV2aWNlcygmY2xpZW50LT5kZXYpOwo+ ICAKPiAtCXJldHVybiBtZmRfYWRkX2RldmljZXMoJmNsaWVudC0+ZGV2LCAwLCB0cHM2MTA1eF9j ZWxscywKPiAtCQkJICAgICAgIEFSUkFZX1NJWkUodHBzNjEwNXhfY2VsbHMpLCBOVUxMLCAwLCBO VUxMKTsKPiArCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgdHBzNjEwNXhfcmVt b3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGllbnQpCgo= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web