Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1228178 > unrolled thread
| Started by | Luis de Bethencourt <luis@debethencourt.com> |
|---|---|
| First post | 2015-09-18 19:00 +0200 |
| Last post | 2015-09-21 10:10 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] pwm: atmel-hlcdc: Fix module autoload for OF platform driver Luis de Bethencourt <luis@debethencourt.com> - 2015-09-18 19:00 +0200
Re: [PATCH] pwm: atmel-hlcdc: Fix module autoload for OF platform driver Thierry Reding <thierry.reding@gmail.com> - 2015-09-21 10:10 +0200
| From | Luis de Bethencourt <luis@debethencourt.com> |
|---|---|
| Date | 2015-09-18 19:00 +0200 |
| Subject | [PATCH] pwm: atmel-hlcdc: Fix module autoload for OF platform driver |
| Message-ID | <qa7aW-8r0-27@gated-at.bofh.it> |
This platform driver has a OF device ID table but the OF module
alias information is not created so module autoloading won't work.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Hello,
This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
that information so modules have the correct aliases built-in and
autoloading works correctly.
A longer explanation by Javier Canillas can be found here:
https://lkml.org/lkml/2015/7/30/519
Thanks,
Luis
drivers/pwm/pwm-atmel-hlcdc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
index 5df1db4..be7bb05 100644
--- a/drivers/pwm/pwm-atmel-hlcdc.c
+++ b/drivers/pwm/pwm-atmel-hlcdc.c
@@ -236,6 +236,7 @@ static const struct of_device_id atmel_hlcdc_dt_ids[] = {
},
{ /* sentinel */ },
};
+MODULE_DEVICE_TABLE(of, atmel_hlcdc_dt_ids);
static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
{
--
2.4.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Thierry Reding <thierry.reding@gmail.com> |
|---|---|
| Date | 2015-09-21 10:10 +0200 |
| Subject | Re: [PATCH] pwm: atmel-hlcdc: Fix module autoload for OF platform driver |
| Message-ID | <qb4kG-Od-17@gated-at.bofh.it> |
| In reply to | #1228178 |
[Multipart message — attachments visible in raw view] — view raw
On Fri, Sep 18, 2015 at 06:58:21PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > > > Hello, > > This patch adds the missing MODULE_DEVICE_TABLE() for OF to export > that information so modules have the correct aliases built-in and > autoloading works correctly. > > A longer explanation by Javier Canillas can be found here: > https://lkml.org/lkml/2015/7/30/519 This is useful information and belongs in the commit message, so I moved it into the commit message before applying. Thanks, Thierry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web