Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1226601 > unrolled thread
| Started by | Duc Dang <dhdang@apm.com> |
|---|---|
| First post | 2015-09-17 02:40 +0200 |
| Last post | 2015-09-18 19:30 +0200 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver Duc Dang <dhdang@apm.com> - 2015-09-17 02:40 +0200
Re: [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver Marc Zyngier <marc.zyngier@arm.com> - 2015-09-18 11:10 +0200
Re: [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver Duc Dang <dhdang@apm.com> - 2015-09-18 19:30 +0200
| From | Duc Dang <dhdang@apm.com> |
|---|---|
| Date | 2015-09-17 02:40 +0200 |
| Subject | [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver |
| Message-ID | <q9voZ-3Qg-1@gated-at.bofh.it> |
With commit 8d63bc7beaee ("PCI/MSI: pci-xgene-msi: Get rid of
struct msi_controller"), it is no longer required to assign
msi_controller for X-Gene PCIe host bridge to support MSI. This
patch removes this unnecessary code and also helps avoid a warning
message ("failed to enable MSI") during boot.
Signed-off-by: Duc Dang <dhdang@apm.com>
Cc: Tanmay Inamdar <tinamdar@apm.com>
---
drivers/pci/host/pci-xgene.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index 0236ab9..ae00ce2 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -509,24 +509,6 @@ static int xgene_pcie_setup(struct xgene_pcie_port *port,
return 0;
}
-static int xgene_pcie_msi_enable(struct pci_bus *bus)
-{
- struct device_node *msi_node;
-
- msi_node = of_parse_phandle(bus->dev.of_node,
- "msi-parent", 0);
- if (!msi_node)
- return -ENODEV;
-
- bus->msi = of_pci_find_msi_chip_by_node(msi_node);
- if (!bus->msi)
- return -ENODEV;
-
- of_node_put(msi_node);
- bus->msi->dev = &bus->dev;
- return 0;
-}
-
static int xgene_pcie_probe_bridge(struct platform_device *pdev)
{
struct device_node *dn = pdev->dev.of_node;
@@ -567,10 +549,6 @@ static int xgene_pcie_probe_bridge(struct platform_device *pdev)
if (!bus)
return -ENOMEM;
- if (IS_ENABLED(CONFIG_PCI_MSI))
- if (xgene_pcie_msi_enable(bus))
- dev_info(port->dev, "failed to enable MSI\n");
-
pci_scan_child_bus(bus);
pci_assign_unassigned_bus_resources(bus);
pci_bus_add_devices(bus);
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Marc Zyngier <marc.zyngier@arm.com> |
|---|---|
| Date | 2015-09-18 11:10 +0200 |
| Subject | Re: [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver |
| Message-ID | <q9ZQ7-6yg-31@gated-at.bofh.it> |
| In reply to | #1226601 |
On Wed, 16 Sep 2015 17:31:40 -0700
Duc Dang <dhdang@apm.com> wrote:
> With commit 8d63bc7beaee ("PCI/MSI: pci-xgene-msi: Get rid of
> struct msi_controller"), it is no longer required to assign
> msi_controller for X-Gene PCIe host bridge to support MSI. This
> patch removes this unnecessary code and also helps avoid a warning
> message ("failed to enable MSI") during boot.
>
> Signed-off-by: Duc Dang <dhdang@apm.com>
> Cc: Tanmay Inamdar <tinamdar@apm.com>
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [next] | [standalone]
| From | Duc Dang <dhdang@apm.com> |
|---|---|
| Date | 2015-09-18 19:30 +0200 |
| Subject | Re: [PATCH 1/1] PCI/MSI: X-Gene: Remove msi_controller assignment in X-Gene PCIe driver |
| Message-ID | <qa7DY-Mt-5@gated-at.bofh.it> |
| In reply to | #1227695 |
On Fri, Sep 18, 2015 at 1:59 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> On Wed, 16 Sep 2015 17:31:40 -0700
> Duc Dang <dhdang@apm.com> wrote:
>
>> With commit 8d63bc7beaee ("PCI/MSI: pci-xgene-msi: Get rid of
>> struct msi_controller"), it is no longer required to assign
>> msi_controller for X-Gene PCIe host bridge to support MSI. This
>> patch removes this unnecessary code and also helps avoid a warning
>> message ("failed to enable MSI") during boot.
>>
>> Signed-off-by: Duc Dang <dhdang@apm.com>
>> Cc: Tanmay Inamdar <tinamdar@apm.com>
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Thanks, Marc.
>
> M.
> --
> Jazz is not dead. It just smells funny.
--
Regards,
Duc Dang.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web