Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220379 > unrolled thread

[PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

Started bySylvain Rochet <sylvain.rochet@finsecur.com>
First post2015-09-07 22:20 +0200
Last post2015-09-18 16:30 +0200
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding Sylvain Rochet <sylvain.rochet@finsecur.com> - 2015-09-07 22:20 +0200
    Re: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep  capabilities support on device tree binding Felipe Balbi <balbi@ti.com> - 2015-09-18 16:30 +0200
      [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-18 17:00 +0200
        Re: [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support  on device tree binding Felipe Balbi <balbi@ti.com> - 2015-09-18 17:10 +0200
    Re: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep  capabilities support on device tree binding Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-09-18 16:30 +0200

#1220379 — [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

FromSylvain Rochet <sylvain.rochet@finsecur.com>
Date2015-09-07 22:20 +0200
Subject[PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Message-ID<q6b3s-7yq-3@gated-at.bofh.it>
The recently added endpoint capabilities flags verification breaks Atmel
USBA because the endpoint configuration was only added when the driver
is bound using the legacy pdata interface.

Convert endpoint configuration to new capabilities model when driver is
bound to a device tree as well.

Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
---
 drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 2cbbb46..c2ea5e1 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2002,6 +2002,17 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 		ep->udc = udc;
 		INIT_LIST_HEAD(&ep->queue);
 
+		if (ep->index == 0) {
+			ep->ep.caps.type_control = true;
+		} else {
+			ep->ep.caps.type_iso = ep->can_isoc;
+			ep->ep.caps.type_bulk = true;
+			ep->ep.caps.type_int = true;
+		}
+
+		ep->ep.caps.dir_in = true;
+		ep->ep.caps.dir_out = true;
+
 		if (i)
 			list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
 
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1227913 — Re: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

FromFelipe Balbi <balbi@ti.com>
Date2015-09-18 16:30 +0200
SubjectRe: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Message-ID<qa4PM-5bi-15@gated-at.bofh.it>
In reply to#1220379

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 18, 2015 at 04:22:07PM +0200, Nicolas Ferre wrote:
> Le 07/09/2015 22:19, Sylvain Rochet a écrit :
> > The recently added endpoint capabilities flags verification breaks Atmel
> > USBA because the endpoint configuration was only added when the driver
> > is bound using the legacy pdata interface.
> > 
> > Convert endpoint configuration to new capabilities model when driver is
> > bound to a device tree as well.
> > 
> > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> 
> With this additional tag:
> Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")
> 
> Felipe, Greg,
> 
> It is considered as a fix for 4.3. Can you please queue it for the "4.3-rc" phase?

sure thing, just, please, resend with linux-usb in Cc :-)

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1227967 — [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

FromNicolas Ferre <nicolas.ferre@atmel.com>
Date2015-09-18 17:00 +0200
Subject[PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Message-ID<qa5iP-5JO-25@gated-at.bofh.it>
In reply to#1227913
From: Sylvain Rochet <sylvain.rochet@finsecur.com>

The recently added endpoint capabilities flags verification breaks Atmel
USBA because the endpoint configuration was only added when the driver
is bound using the legacy pdata interface.

Convert endpoint configuration to new capabilities model when driver is
bound to a device tree as well.

Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")
Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
---
Felipe,

As you've just requested, here is the same patch sent to linux-usb ml. I had
added the "Fixes" and my SoB tags.

For the record:
It is considered as a fix for 4.3. Can you please queue it for the "4.3-rc"
phase?

Bye,


 drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
index 3dfada8d6061..f0f2b066ac08 100644
--- a/drivers/usb/gadget/udc/atmel_usba_udc.c
+++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
@@ -2002,6 +2002,17 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
 		ep->udc = udc;
 		INIT_LIST_HEAD(&ep->queue);
 
+		if (ep->index == 0) {
+			ep->ep.caps.type_control = true;
+		} else {
+			ep->ep.caps.type_iso = ep->can_isoc;
+			ep->ep.caps.type_bulk = true;
+			ep->ep.caps.type_int = true;
+		}
+
+		ep->ep.caps.dir_in = true;
+		ep->ep.caps.dir_out = true;
+
 		if (i)
 			list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
 
-- 
2.1.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228018 — Re: [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

FromFelipe Balbi <balbi@ti.com>
Date2015-09-18 17:10 +0200
SubjectRe: [PATCH] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Message-ID<qa5sv-6aQ-67@gated-at.bofh.it>
In reply to#1227967

[Multipart message — attachments visible in raw view] — view raw

On Fri, Sep 18, 2015 at 04:58:28PM +0200, Nicolas Ferre wrote:
> From: Sylvain Rochet <sylvain.rochet@finsecur.com>
> 
> The recently added endpoint capabilities flags verification breaks Atmel
> USBA because the endpoint configuration was only added when the driver
> is bound using the legacy pdata interface.
> 
> Convert endpoint configuration to new capabilities model when driver is
> bound to a device tree as well.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> Felipe,
> 
> As you've just requested, here is the same patch sent to linux-usb ml. I had
> added the "Fixes" and my SoB tags.
> 
> For the record:
> It is considered as a fix for 4.3. Can you please queue it for the "4.3-rc"
> phase?

thanks, I'll take it for -rc3 (already sent my -rc2 pull request).

-- 
balbi

[toc] | [prev] | [next] | [standalone]

#1227918 — Re: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding

FromNicolas Ferre <nicolas.ferre@atmel.com>
Date2015-09-18 16:30 +0200
SubjectRe: [PATCH linux-next] usb: gadget: atmel_usba_udc: add ep capabilities support on device tree binding
Message-ID<qa4PM-5bi-17@gated-at.bofh.it>
In reply to#1220379
Le 07/09/2015 22:19, Sylvain Rochet a écrit :
> The recently added endpoint capabilities flags verification breaks Atmel
> USBA because the endpoint configuration was only added when the driver
> is bound using the legacy pdata interface.
> 
> Convert endpoint configuration to new capabilities model when driver is
> bound to a device tree as well.
> 
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>

Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>

With this additional tag:
Fixes: 47bef3865115 ("usb: gadget: atmel_usba_udc: add ep capabilities support")

Felipe, Greg,

It is considered as a fix for 4.3. Can you please queue it for the "4.3-rc" phase?

Thanks, bye.

> ---
>  drivers/usb/gadget/udc/atmel_usba_udc.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c
> index 2cbbb46..c2ea5e1 100644
> --- a/drivers/usb/gadget/udc/atmel_usba_udc.c
> +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c
> @@ -2002,6 +2002,17 @@ static struct usba_ep * atmel_udc_of_init(struct platform_device *pdev,
>  		ep->udc = udc;
>  		INIT_LIST_HEAD(&ep->queue);
>  
> +		if (ep->index == 0) {
> +			ep->ep.caps.type_control = true;
> +		} else {
> +			ep->ep.caps.type_iso = ep->can_isoc;
> +			ep->ep.caps.type_bulk = true;
> +			ep->ep.caps.type_int = true;
> +		}
> +
> +		ep->ep.caps.dir_in = true;
> +		ep->ep.caps.dir_out = true;
> +
>  		if (i)
>  			list_add_tail(&ep->ep.ep_list, &udc->gadget.ep_list);
>  
> 


-- 
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web