Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1220263 > unrolled thread

Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D Shawn Guo <shawnguo@kernel.org> - 2015-09-07 17:20 +0200
    RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D Shenwei Wang <Shenwei.Wang@freescale.com> - 2015-09-08 17:10 +0200
      Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D Shawn Guo <shawnguo@kernel.org> - 2015-09-18 16:20 +0200
        RE: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D Shenwei Wang <Shenwei.Wang@freescale.com> - 2015-09-18 16:40 +0200
          Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D Shawn Guo <shawnguo@kernel.org> - 2015-09-19 03:20 +0200

#1220263 — Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D

On Fri, Jul 31, 2015 at 04:33:59PM -0500, Shenwei Wang wrote:
> IMX7D contains a new version of GPC IP block (GPCv2). It has two
> major functions: power management and wakeup source management.
> 
> GPCv2 provides low power mode control for Cortex-A7 and Cortex-M4
> domains. And it can support WAIT, STOP, and DSM(Deep Sleep Mode) modes.
> After configuring the GPCv2 module, the platform can enter into a
> selected mode either automatically triggered by ARM WFI instruction or
> manually by software. The system will exit the low power states
> by the predefined wakeup sources which are managed by the gpcv2
> irqchip driver.
> 
> This patch adds a new suspend driver to manage the power states on IMX7D.
> It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states.
> 
> Signed-off-by: Shenwei Wang <shenwei.wang@freescale.com>
> Signed-off-by: Anson Huang <b20788@freescale.com>

Please stop sending patches to my Linaro mailbox, and use
shawnguo@kernel.org instead.  You should already get that if you ever
run ./scripts/get_maintainer.pl on the patch.  Also please always copy
kernel@pengutronix.de for i.MX platform patches like this.

> ---
>  arch/arm/mach-imx/Kconfig        |   1 +
>  arch/arm/mach-imx/Makefile       |   2 +
>  arch/arm/mach-imx/common.h       |   4 +
>  arch/arm/mach-imx/pm-imx7.c      | 917 +++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-imx/suspend-imx7.S | 529 ++++++++++++++++++++++
>  5 files changed, 1453 insertions(+)

1453 lines addition to kernel only for i.MX7D suspend support.  Yes,
this is the way we support suspend on i.MX6, but that's enough, and
we have to stop this somewhere.  I would ask you to take Sudeep's
comment and adopt PSCI for i.MX7D power management.

Shawn

[1] https://lkml.org/lkml/2015/8/26/554
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1220914

> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo@kernel.org]
> > This patch adds a new suspend driver to manage the power states on IMX7D.
> > It currently supports "SUSPEND_STANDBY" and "SUSPEND_MEM" states.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@freescale.com>
> > Signed-off-by: Anson Huang <b20788@freescale.com>
> 
> Please stop sending patches to my Linaro mailbox, and use
> shawnguo@kernel.org instead.  You should already get that if you ever
> run ./scripts/get_maintainer.pl on the patch.  Also please always copy
> kernel@pengutronix.de for i.MX platform patches like this.

Noted.

> > ---
> >  arch/arm/mach-imx/Kconfig        |   1 +
> >  arch/arm/mach-imx/Makefile       |   2 +
> >  arch/arm/mach-imx/common.h       |   4 +
> >  arch/arm/mach-imx/pm-imx7.c      | 917
> +++++++++++++++++++++++++++++++++++++++
> >  arch/arm/mach-imx/suspend-imx7.S | 529 ++++++++++++++++++++++
> >  5 files changed, 1453 insertions(+)
> 
> 1453 lines addition to kernel only for i.MX7D suspend support.  Yes, this is the
> way we support suspend on i.MX6, but that's enough, and we have to stop this
> somewhere.  I would ask you to take Sudeep's comment and adopt PSCI for
> i.MX7D power management.

According to PSCI spec, a supervisory software must be implemented under either
HVC(EL2) or SMC(EL3) privilege level. I agree that, with this idea, we could finally move 
these 1453 lines of codes from kernel into a platform specific firmware. The problem
is we don't have the firmware so far, and we haven't even had a plan to enable the
hypervisor or secure software on this platform. Because low power consumption is
the key feature of this i.MX7D platform, please continue to consider the current 
implementation and get this feature supported first. 

Thanks,
Shenwei

 
> Shawn
> 
> [1] https://lkml.org/lkml/2015/8/26/554
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1227904

On Tue, Sep 08, 2015 at 03:01:07PM +0000, Shenwei Wang wrote:
> > >  arch/arm/mach-imx/Kconfig        |   1 +
> > >  arch/arm/mach-imx/Makefile       |   2 +
> > >  arch/arm/mach-imx/common.h       |   4 +
> > >  arch/arm/mach-imx/pm-imx7.c      | 917
> > +++++++++++++++++++++++++++++++++++++++
> > >  arch/arm/mach-imx/suspend-imx7.S | 529 ++++++++++++++++++++++
> > >  5 files changed, 1453 insertions(+)
> > 
> > 1453 lines addition to kernel only for i.MX7D suspend support.  Yes, this is the
> > way we support suspend on i.MX6, but that's enough, and we have to stop this
> > somewhere.  I would ask you to take Sudeep's comment and adopt PSCI for
> > i.MX7D power management.
> 
> According to PSCI spec, a supervisory software must be implemented under either
> HVC(EL2) or SMC(EL3) privilege level. I agree that, with this idea, we could finally move 
> these 1453 lines of codes from kernel into a platform specific firmware. The problem
> is we don't have the firmware so far, and we haven't even had a plan to enable the
> hypervisor or secure software on this platform. Because low power consumption is
> the key feature of this i.MX7D platform, please continue to consider the current 
> implementation and get this feature supported first. 

Can't U-Boot be considered as a firmware to implement PSCI?  I have seen
an initial ARMv7 PSCI core support for U-Boot added by Marc Zyngier.

Shawn

[1] http://lists.denx.de/pipermail/u-boot/2013-December/168655.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1227927

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU2hhd24gR3VvIFttYWls
dG86c2hhd25ndW9Aa2VybmVsLm9yZ10NCj4gU2VudDogMjAxNcTqOdTCMTjI1SA5OjE1DQo+IFRv
OiBXYW5nIFNoZW53ZWktQjM4MzM5DQo+IENjOiBqYXNvbkBsYWtlZGFlbW9uLm5ldDsgSHVhbmcg
WW9uZ2NhaS1CMjA3ODg7DQo+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGtlcm5lbEBw
ZW5ndXRyb25peC5kZTsgU3VkZWVwIEhvbGxhOw0KPiB0Z2x4QGxpbnV0cm9uaXguZGU7IHNoYXdu
Lmd1b0BsaW5hcm8ub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4g
U3ViamVjdDogUmU6IFtQQVRDSCB2OCAyLzJdIEFSTTogaW14OiBzdXBwb3J0IHN1c3BlbmQgc3Rh
dGVzIG9uIGlteDdEDQo+IA0KPiBPbiBUdWUsIFNlcCAwOCwgMjAxNSBhdCAwMzowMTowN1BNICsw
MDAwLCBTaGVud2VpIFdhbmcgd3JvdGU6DQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLWlteC9LY29u
ZmlnICAgICAgICB8ICAgMSArDQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLWlteC9NYWtlZmlsZSAg
ICAgICB8ICAgMiArDQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLWlteC9jb21tb24uaCAgICAgICB8
ICAgNCArDQo+ID4gPiA+ICBhcmNoL2FybS9tYWNoLWlteC9wbS1pbXg3LmMgICAgICB8IDkxNw0K
PiA+ID4gKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiA+ICBh
cmNoL2FybS9tYWNoLWlteC9zdXNwZW5kLWlteDcuUyB8IDUyOSArKysrKysrKysrKysrKysrKysr
KysrDQo+ID4gPiA+ICA1IGZpbGVzIGNoYW5nZWQsIDE0NTMgaW5zZXJ0aW9ucygrKQ0KPiA+ID4N
Cj4gPiA+IDE0NTMgbGluZXMgYWRkaXRpb24gdG8ga2VybmVsIG9ubHkgZm9yIGkuTVg3RCBzdXNw
ZW5kIHN1cHBvcnQuICBZZXMsDQo+ID4gPiB0aGlzIGlzIHRoZSB3YXkgd2Ugc3VwcG9ydCBzdXNw
ZW5kIG9uIGkuTVg2LCBidXQgdGhhdCdzIGVub3VnaCwgYW5kDQo+ID4gPiB3ZSBoYXZlIHRvIHN0
b3AgdGhpcyBzb21ld2hlcmUuICBJIHdvdWxkIGFzayB5b3UgdG8gdGFrZSBTdWRlZXAncw0KPiA+
ID4gY29tbWVudCBhbmQgYWRvcHQgUFNDSSBmb3IgaS5NWDdEIHBvd2VyIG1hbmFnZW1lbnQuDQo+
ID4NCj4gPiBBY2NvcmRpbmcgdG8gUFNDSSBzcGVjLCBhIHN1cGVydmlzb3J5IHNvZnR3YXJlIG11
c3QgYmUgaW1wbGVtZW50ZWQNCj4gPiB1bmRlciBlaXRoZXINCj4gPiBIVkMoRUwyKSBvciBTTUMo
RUwzKSBwcml2aWxlZ2UgbGV2ZWwuIEkgYWdyZWUgdGhhdCwgd2l0aCB0aGlzIGlkZWEsIHdlDQo+
ID4gY291bGQgZmluYWxseSBtb3ZlIHRoZXNlIDE0NTMgbGluZXMgb2YgY29kZXMgZnJvbSBrZXJu
ZWwgaW50byBhDQo+ID4gcGxhdGZvcm0gc3BlY2lmaWMgZmlybXdhcmUuIFRoZSBwcm9ibGVtIGlz
IHdlIGRvbid0IGhhdmUgdGhlIGZpcm13YXJlDQo+ID4gc28gZmFyLCBhbmQgd2UgaGF2ZW4ndCBl
dmVuIGhhZCBhIHBsYW4gdG8gZW5hYmxlIHRoZSBoeXBlcnZpc29yIG9yDQo+ID4gc2VjdXJlIHNv
ZnR3YXJlIG9uIHRoaXMgcGxhdGZvcm0uIEJlY2F1c2UgbG93IHBvd2VyIGNvbnN1bXB0aW9uIGlz
IHRoZQ0KPiA+IGtleSBmZWF0dXJlIG9mIHRoaXMgaS5NWDdEIHBsYXRmb3JtLCBwbGVhc2UgY29u
dGludWUgdG8gY29uc2lkZXIgdGhlIGN1cnJlbnQNCj4gaW1wbGVtZW50YXRpb24gYW5kIGdldCB0
aGlzIGZlYXR1cmUgc3VwcG9ydGVkIGZpcnN0Lg0KPiANCj4gQ2FuJ3QgVS1Cb290IGJlIGNvbnNp
ZGVyZWQgYXMgYSBmaXJtd2FyZSB0byBpbXBsZW1lbnQgUFNDST8gIEkgaGF2ZSBzZWVuIGFuDQo+
IGluaXRpYWwgQVJNdjcgUFNDSSBjb3JlIHN1cHBvcnQgZm9yIFUtQm9vdCBhZGRlZCBieSBNYXJj
IFp5bmdpZXIuDQoNClRoZSBjdXJyZW50IFBTQ0kgc3VwcG9ydCBpbiB1Ym9vdCBpcyBub3QgY29t
cGxldGUuIEl0IGNhbiBub3cgc3VwcG9ydCBjcHVpZGxlLCBzaHV0ZG93biwgDQphbmQgcmVzZXQu
IEJ1dCB0byBzdXBwb3J0IHN5c3RlbSBzdXNwZW5kLCB0aGVyZSB3b3VsZCBiZSBhIGxvdCBtb3Jl
IHRhc2tzLiBGb3IgZXhhbXBsZSwNCmV2ZW4gdGhlIGN1cnJlbnQgd2FrZXVwIHNvdXJjZSBtYW5h
Z2VtZW50IGNvZGVzIHdpbGwgaGF2ZSB0byBtb3ZlIGludG8gdGhlIGZpcm13YXJlIA0KdG9vLiBJ
dCBpcyBub3QgYSBzaG9ydCB0aW1lIHRhc2suIFBsZWFzZSBjb250aW51ZSB0byBjb25zaWRlciB0
aGlzIHBsYXRmb3JtIGRlcGVuZGVudCBpbXBsZW1lbnRhdGlvbg0KZmlyc3QsIG1lYW53aGlsZSwg
d2Ugd2lsbCBzdGFydCB0byBtaWdyYXRlIHRoZSBzb2x1dGlvbiB0byBQU0NJLiBIb3dldmVyIGl0
IHdpbGwgdGFrZSBzb21lIHRpbWUuDQoNClRoYW5rcywNClNoZW53ZWkNCg0KPiBTaGF3bg0KPiAN
Cj4gWzFdIGh0dHA6Ly9saXN0cy5kZW54LmRlL3BpcGVybWFpbC91LWJvb3QvMjAxMy1EZWNlbWJl
ci8xNjg2NTUuaHRtbA0K
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1228364

On Fri, Sep 18, 2015 at 02:38:39PM +0000, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Shawn Guo [mailto:shawnguo@kernel.org]
> > Sent: 2015年9月18日 9:15
> > To: Wang Shenwei-B38339
> > Cc: jason@lakedaemon.net; Huang Yongcai-B20788;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; Sudeep Holla;
> > tglx@linutronix.de; shawn.guo@linaro.org; linux-arm-kernel@lists.infradead.org
> > Subject: Re: [PATCH v8 2/2] ARM: imx: support suspend states on imx7D
> > 
> > On Tue, Sep 08, 2015 at 03:01:07PM +0000, Shenwei Wang wrote:
> > > > >  arch/arm/mach-imx/Kconfig        |   1 +
> > > > >  arch/arm/mach-imx/Makefile       |   2 +
> > > > >  arch/arm/mach-imx/common.h       |   4 +
> > > > >  arch/arm/mach-imx/pm-imx7.c      | 917
> > > > +++++++++++++++++++++++++++++++++++++++
> > > > >  arch/arm/mach-imx/suspend-imx7.S | 529 ++++++++++++++++++++++
> > > > >  5 files changed, 1453 insertions(+)
> > > >
> > > > 1453 lines addition to kernel only for i.MX7D suspend support.  Yes,
> > > > this is the way we support suspend on i.MX6, but that's enough, and
> > > > we have to stop this somewhere.  I would ask you to take Sudeep's
> > > > comment and adopt PSCI for i.MX7D power management.
> > >
> > > According to PSCI spec, a supervisory software must be implemented
> > > under either
> > > HVC(EL2) or SMC(EL3) privilege level. I agree that, with this idea, we
> > > could finally move these 1453 lines of codes from kernel into a
> > > platform specific firmware. The problem is we don't have the firmware
> > > so far, and we haven't even had a plan to enable the hypervisor or
> > > secure software on this platform. Because low power consumption is the
> > > key feature of this i.MX7D platform, please continue to consider the current
> > implementation and get this feature supported first.
> > 
> > Can't U-Boot be considered as a firmware to implement PSCI?  I have seen an
> > initial ARMv7 PSCI core support for U-Boot added by Marc Zyngier.
> 
> The current PSCI support in uboot is not complete. It can now support cpuidle, shutdown, 
> and reset. But to support system suspend, there would be a lot more tasks. For example,
> even the current wakeup source management codes will have to move into the firmware 
> too. It is not a short time task. Please continue to consider this platform dependent implementation
> first, meanwhile, we will start to migrate the solution to PSCI. However it will take some time.

I have zero interest to maintain this pile of code in the mainline
kernel.  Take it as a motivation to move to PSCI soon, or you maintain
it on your own as a out-of-tree patch for whatever long time you like.

Shawn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web