Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328439 > unrolled thread

[PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

Back to article view | Back to linux.kernel

Contents

  [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes Stephen Boyd <sboyd@codeaurora.org> - 2016-02-07 08:50 +0100
    Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup()  prototypes Jyri Sarha <jsarha@ti.com> - 2016-02-07 10:50 +0100
      Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup()  prototypes Stephen Boyd <sboyd@codeaurora.org> - 2016-02-08 23:20 +0100

#1328439 — [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

These functions either never existed or were only used in
OF_CLK_DECLARE() macros. Remove the dead prototypes.

Cc: Jyri Sarha <jsarha@ti.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
 include/linux/clk-provider.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index 9c3a18c1a984..fce7f027f8a7 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
 		const char *parent_name, unsigned gpio, bool active_low,
 		unsigned long flags);
 
-void of_gpio_clk_gate_setup(struct device_node *node);
-
 /**
  * struct clk_gpio_mux - gpio controlled clock multiplexer
  *
@@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
 		const char * const *parent_names, u8 num_parents, unsigned gpio,
 		bool active_low, unsigned long flags);
 
-void of_gpio_mux_clk_setup(struct device_node *node);
-
 /**
  * clk_register - allocate a new clock, register it and return an opaque cookie
  * @dev: device that is registering this clock
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [next] | [standalone]

#1328457 — Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

On 02/07/16 09:42, Stephen Boyd wrote:
> These functions either never existed or were only used in
> OF_CLK_DECLARE() macros. Remove the dead prototypes.
>

Yes, they were used by OF_CLK_DECLARE() macros. I originally made the 
of_gpio_clk_gate_setup() non static just because the other basic clocks 
were implemented the same way. Actually I do not follow why the 
functions needed to be non static in the first place. Surely the 
declarations can go now after the conversion to a platform driver.

Acked-by: Jyri Sarha <jsarha@ti.com>

> Cc: Jyri Sarha <jsarha@ti.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
>   include/linux/clk-provider.h | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index 9c3a18c1a984..fce7f027f8a7 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -626,8 +626,6 @@ struct clk *clk_register_gpio_gate(struct device *dev, const char *name,
>   		const char *parent_name, unsigned gpio, bool active_low,
>   		unsigned long flags);
>
> -void of_gpio_clk_gate_setup(struct device_node *node);
> -
>   /**
>    * struct clk_gpio_mux - gpio controlled clock multiplexer
>    *
> @@ -643,8 +641,6 @@ struct clk *clk_register_gpio_mux(struct device *dev, const char *name,
>   		const char * const *parent_names, u8 num_parents, unsigned gpio,Acked-by:
>   		bool active_low, unsigned long flags);
>
> -void of_gpio_mux_clk_setup(struct device_node *node);
> -
>   /**
>    * clk_register - allocate a new clock, register it and return an opaque cookie
>    * @dev: device that is registering this clock
>

[toc] | [prev] | [next] | [standalone]

#1329635 — Re: [PATCH] clk: provider: Remove of_gpio_{gate,mux}_clk_setup() prototypes

On 02/07, Jyri Sarha wrote:
> On 02/07/16 09:42, Stephen Boyd wrote:
> >These functions either never existed or were only used in
> >OF_CLK_DECLARE() macros. Remove the dead prototypes.
> >
> 
> Yes, they were used by OF_CLK_DECLARE() macros. I originally made
> the of_gpio_clk_gate_setup() non static just because the other basic
> clocks were implemented the same way. Actually I do not follow why
> the functions needed to be non static in the first place. Surely the
> declarations can go now after the conversion to a platform driver.
> 

Thanks. There is some exporting of basic type functions for u300.
I'm not entirely sure why we do it there either though.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web