Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1326008 > unrolled thread

Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

Started byGreg Kroah-Hartman <gregkh@linuxfoundation.org>
First post2016-02-03 23:30 +0100
Last post2016-02-07 10:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning  generated by sparse Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-02-03 23:30 +0100
    Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning  generated by sparse Niranjan Dighe <niranjan.dighe@gmail.com> - 2016-02-07 10:10 +0100

#1326008 — Re: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse

FromGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Date2016-02-03 23:30 +0100
SubjectRe: [PATCH] staging: lustre: Fix 'unexpected unlock' warning generated by sparse
Message-ID<qYe5Y-7Yi-7@gated-at.bofh.it>
On Sun, Jan 03, 2016 at 08:27:04AM +0530, Niranjan Dighe wrote:
> Added annotation '__must_hold' to function ksocknal_send_keepalive_locked
> which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is
> not acquired in the current function, sparse warns about context imbalance
> 
> Signed-off-by: Niranjan Dighe <niranjan.dighe@gmail.com>
> ---
>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 1 +
>  1 file changed, 1 insertion(+)

Doesn't apply to my tree :(

[toc] | [next] | [standalone]


#1328447

FromNiranjan Dighe <niranjan.dighe@gmail.com>
Date2016-02-07 10:10 +0100
Message-ID<qZtvX-3Zv-1@gated-at.bofh.it>
In reply to#1326008
On Thu, Feb 4, 2016 at 3:53 AM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Sun, Jan 03, 2016 at 08:27:04AM +0530, Niranjan Dighe wrote:
>> Added annotation '__must_hold' to function ksocknal_send_keepalive_locked
>> which unlocks the lock ksocknal_data.ksnd_global_lock. As this lock is
>> not acquired in the current function, sparse warns about context imbalance
>>
>> Signed-off-by: Niranjan Dighe <niranjan.dighe@gmail.com>
>> ---
>>  drivers/staging/lustre/lnet/klnds/socklnd/socklnd_cb.c | 1 +
>>  1 file changed, 1 insertion(+)
>
> Doesn't apply to my tree :(

Sorry about this Greg, I will recreate it on the latest staging-next and resend.

Thanks,
Niranjan Dighe

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web