Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324392 > unrolled thread
| Started by | Tadeusz Struk <tadeusz.struk@intel.com> |
|---|---|
| First post | 2016-02-02 19:20 +0100 |
| Last post | 2016-02-09 09:50 +0100 |
| Articles | 10 — 5 participants |
Back to article view | Back to linux.kernel
[PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2016-02-02 19:20 +0100
Re: [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 08:50 +0100
Re: [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api David Howells <dhowells@redhat.com> - 2016-02-06 11:10 +0100
Re: [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 15:30 +0100
Re: [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api David Howells <dhowells@redhat.com> - 2016-02-07 01:50 +0100
Re: [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-07 02:30 +0100
Transferring applied X.509 patches from crypto/next to security/next David Howells <dhowells@redhat.com> - 2016-02-08 15:00 +0100
Re: Transferring applied X.509 patches from crypto/next to security/next Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-08 22:30 +0100
Re: Transferring applied X.509 patches from crypto/next to security/next James Morris <jmorris@namei.org> - 2016-02-09 02:10 +0100
Re: Transferring applied X.509 patches from crypto/next to security/next Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-09 09:50 +0100
| From | Tadeusz Struk <tadeusz.struk@intel.com> |
|---|---|
| Date | 2016-02-02 19:20 +0100 |
| Subject | [PATCH v5 0/3] crypto: KEYS: convert public key to akcipher api |
| Message-ID | <qXNIu-6Z3-25@gated-at.bofh.it> |
Resend v5 rebased on top of 4.5
This patch set converts the module verification and digital signature
code to the new akcipher API.
RSA implementation has been removed from crypto/asymmetric_keys and the
new API is used for cryptographic primitives.
There is no need for MPI above the akcipher API anymore.
Modules can be verified with software as well as HW RSA implementations.
Patches generated against cryptodev-2.6
Changes in v5:
- Revert back v4 and add a new patch that removes the MPIs from the
public_key_signature struct after the asymmetric_verify funtc in
digsig is converted as proposed by Herbert.
Changes in v4:
- Flatten both patches into one to avoid bisect compilation problems.
Changes in v3:
- Don't include keys/asymmetric-type.h in crypto/public_key.h
Changes in v2:
- Fix the whey public_key_signature is setup. The pointer s needs to
point to the signature instread of the signature_v2_hdr.
- Select CRYPTO_RSA when INTEGRITY_ASYMMETRIC_KEYS is selected.
---
Tadeusz Struk (3):
crypto: KEYS: convert public key and digsig asym to the akcipher api
integrity: convert digsig to akcipher api
crypto: public_key: remove MPIs from public_key_signature struct
crypto/asymmetric_keys/Kconfig | 2
crypto/asymmetric_keys/Makefile | 7 -
crypto/asymmetric_keys/pkcs7_parser.c | 12 +-
crypto/asymmetric_keys/pkcs7_trust.c | 2
crypto/asymmetric_keys/pkcs7_verify.c | 2
crypto/asymmetric_keys/public_key.c | 64 +++------
crypto/asymmetric_keys/public_key.h | 36 -----
crypto/asymmetric_keys/rsa.c | 213 +++++++++++------------------
crypto/asymmetric_keys/x509_cert_parser.c | 37 +----
crypto/asymmetric_keys/x509_public_key.c | 17 +-
crypto/asymmetric_keys/x509_rsakey.asn1 | 4 -
include/crypto/public_key.h | 48 +------
security/integrity/Kconfig | 1
security/integrity/digsig_asymmetric.c | 10 -
14 files changed, 139 insertions(+), 316 deletions(-)
delete mode 100644 crypto/asymmetric_keys/public_key.h
delete mode 100644 crypto/asymmetric_keys/x509_rsakey.asn1
--
[toc] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-02-06 08:50 +0100 |
| Message-ID | <qZ5MZ-46X-7@gated-at.bofh.it> |
| In reply to | #1324392 |
On Tue, Feb 02, 2016 at 10:08:48AM -0800, Tadeusz Struk wrote: > Resend v5 rebased on top of 4.5 > > This patch set converts the module verification and digital signature > code to the new akcipher API. > RSA implementation has been removed from crypto/asymmetric_keys and the > new API is used for cryptographic primitives. > There is no need for MPI above the akcipher API anymore. > Modules can be verified with software as well as HW RSA implementations. > > Patches generated against cryptodev-2.6 Applied. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-06 11:10 +0100 |
| Message-ID | <qZ7Yu-5HU-13@gated-at.bofh.it> |
| In reply to | #1328246 |
Herbert Xu <herbert@gondor.apana.org.au> wrote: > Applied. Hmmm... That means that the crypto branch and the security branch are going to conflict. David
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-02-06 15:30 +0100 |
| Message-ID | <qZc26-8te-5@gated-at.bofh.it> |
| In reply to | #1328266 |
On Sat, Feb 06, 2016 at 10:00:21AM +0000, David Howells wrote: > > Hmmm... That means that the crypto branch and the security branch are going > to conflict. I thought you were OK with it going in now as you said that you'll fix it up later. Sorry for the misunderstanding. Do you want me to revert? Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-07 01:50 +0100 |
| Message-ID | <qZlI5-6LG-3@gated-at.bofh.it> |
| In reply to | #1328306 |
Herbert Xu <herbert@gondor.apana.org.au> wrote: > > Hmmm... That means that the crypto branch and the security branch are going > > to conflict. > > I thought you were OK with it going in now as you said that you'll > fix it up later. Sorry for the misunderstanding. Do you want me to > revert? Ummm. I did say I'd take it on top of my patches. How did you take it? Did you merge Tadeusz's branch? If so, I can probably merge it into mine also and git will Just Do The Right Thing™. David
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-02-07 02:30 +0100 |
| Message-ID | <qZmkN-7jz-3@gated-at.bofh.it> |
| In reply to | #1328395 |
On Sun, Feb 07, 2016 at 12:43:53AM +0000, David Howells wrote: > > Ummm. I did say I'd take it on top of my patches. How did you take it? Did > you merge Tadeusz's branch? If so, I can probably merge it into mine also and > git will Just Do The Right Thing™. No I merged them as individual patches. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [next] | [standalone]
| From | David Howells <dhowells@redhat.com> |
|---|---|
| Date | 2016-02-08 15:00 +0100 |
| Subject | Transferring applied X.509 patches from crypto/next to security/next |
| Message-ID | <qZUw9-63L-1@gated-at.bofh.it> |
| In reply to | #1328306 |
Herbert Xu <herbert@gondor.apana.org.au> wrote: > > Hmmm... That means that the crypto branch and the security branch are going > > to conflict. > > I thought you were OK with it going in now as you said that you'll > fix it up later. Sorry for the misunderstanding. Do you want me to > revert? If you can back them out, I'll apply them to my keys-next branch. Unless James is willing to rebase security/next on top of your crypto branch? David
[toc] | [prev] | [next] | [standalone]
| From | Mimi Zohar <zohar@linux.vnet.ibm.com> |
|---|---|
| Date | 2016-02-08 22:30 +0100 |
| Subject | Re: Transferring applied X.509 patches from crypto/next to security/next |
| Message-ID | <r01xE-2sd-17@gated-at.bofh.it> |
| In reply to | #1329069 |
Hi Herbert, On Mon, 2016-02-08 at 13:58 +0000, David Howells wrote: > Herbert Xu <herbert@gondor.apana.org.au> wrote: > > > > Hmmm... That means that the crypto branch and the security branch are going > > > to conflict. > > > > I thought you were OK with it going in now as you said that you'll > > fix it up later. Sorry for the misunderstanding. Do you want me to > > revert? > > If you can back them out, I'll apply them to my keys-next branch. Unless > James is willing to rebase security/next on top of your crypto branch? Could we upstream these patches via James' tree? If you re-base these patches on top of the James' security-next branch and send him a pull request, we can then base on our patches on top of them. Mimi
[toc] | [prev] | [next] | [standalone]
| From | James Morris <jmorris@namei.org> |
|---|---|
| Date | 2016-02-09 02:10 +0100 |
| Subject | Re: Transferring applied X.509 patches from crypto/next to security/next |
| Message-ID | <r04Yx-50D-15@gated-at.bofh.it> |
| In reply to | #1329069 |
On Mon, 8 Feb 2016, David Howells wrote: > Herbert Xu <herbert@gondor.apana.org.au> wrote: > > > > Hmmm... That means that the crypto branch and the security branch are going > > > to conflict. > > > > I thought you were OK with it going in now as you said that you'll > > fix it up later. Sorry for the misunderstanding. Do you want me to > > revert? > > If you can back them out, I'll apply them to my keys-next branch. Unless > James is willing to rebase security/next on top of your crypto branch? > I don't want to rebase my tree. -- James Morris <jmorris@namei.org>
[toc] | [prev] | [next] | [standalone]
| From | Herbert Xu <herbert@gondor.apana.org.au> |
|---|---|
| Date | 2016-02-09 09:50 +0100 |
| Subject | Re: Transferring applied X.509 patches from crypto/next to security/next |
| Message-ID | <r0c9H-1Bp-15@gated-at.bofh.it> |
| In reply to | #1329808 |
On Tue, Feb 09, 2016 at 12:01:19PM +1100, James Morris wrote: > > > > If you can back them out, I'll apply them to my keys-next branch. Unless > > James is willing to rebase security/next on top of your crypto branch? > > > > I don't want to rebase my tree. OK, I've just reverted the patches and pushed it out. Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web