Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1329154 > unrolled thread
| Started by | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| First post | 2016-02-08 16:10 +0100 |
| Last post | 2016-02-08 19:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] iio: Fix documentation for iio_dev mlock Daniel Baluta <daniel.baluta@intel.com> - 2016-02-08 16:10 +0100
Re: [PATCH] iio: Fix documentation for iio_dev mlock Jonathan Cameron <jic23@kernel.org> - 2016-02-08 19:40 +0100
| From | Daniel Baluta <daniel.baluta@intel.com> |
|---|---|
| Date | 2016-02-08 16:10 +0100 |
| Subject | [PATCH] iio: Fix documentation for iio_dev mlock |
| Message-ID | <qZVBU-70K-29@gated-at.bofh.it> |
mlock *must* be used by core and drivers to protect access
to devices state changes.
Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
---
At a first glance there are few places where access to iio_dev
state changes are done without mlock protection. Will fix them
with follow up patches.
include/linux/iio/iio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index b589411..ce9e9c1 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
* @buffer: [DRIVER] any buffer present
* @buffer_list: [INTERN] list of all buffers currently attached
* @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
- * @mlock: [INTERN] lock used to prevent simultaneous device state
+ * @mlock: [DRIVER] lock used to prevent simultaneous device state
* changes
* @available_scan_masks: [DRIVER] optional array of allowed bitmasks
* @masklength: [INTERN] the length of the mask established from
--
2.5.0
[toc] | [next] | [standalone]
| From | Jonathan Cameron <jic23@kernel.org> |
|---|---|
| Date | 2016-02-08 19:40 +0100 |
| Message-ID | <qZYT8-Dx-19@gated-at.bofh.it> |
| In reply to | #1329154 |
On 08/02/16 15:03, Daniel Baluta wrote:
> mlock *must* be used by core and drivers to protect access
> to devices state changes.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Applied. Thanks for cleaning this up.
Jonathan
> ---
> At a first glance there are few places where access to iio_dev
> state changes are done without mlock protection. Will fix them
> with follow up patches.
>
> include/linux/iio/iio.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index b589411..ce9e9c1 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -448,7 +448,7 @@ struct iio_buffer_setup_ops {
> * @buffer: [DRIVER] any buffer present
> * @buffer_list: [INTERN] list of all buffers currently attached
> * @scan_bytes: [INTERN] num bytes captured to be fed to buffer demux
> - * @mlock: [INTERN] lock used to prevent simultaneous device state
> + * @mlock: [DRIVER] lock used to prevent simultaneous device state
> * changes
> * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
> * @masklength: [INTERN] the length of the mask established from
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web