Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1329388 > unrolled thread

[PATCH v2] staging: most: return error value

Started bySudip Mukherjee <sudipm.mukherjee@gmail.com>
First post2016-02-08 18:30 +0100
Last post2016-02-08 18:30 +0100
Articles 1 — 1 participant

Back to article view | Back to linux.kernel


Contents

  [PATCH v2] staging: most: return error value Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-08 18:30 +0100

#1329388 — [PATCH v2] staging: most: return error value

FromSudip Mukherjee <sudipm.mukherjee@gmail.com>
Date2016-02-08 18:30 +0100
Subject[PATCH v2] staging: most: return error value
Message-ID<qZXNp-8m9-49@gated-at.bofh.it>
On error we were returning retval, but retval is not having the error
value. We will get the error value using PTR_ERR.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

v2: sent after rebasing

 drivers/staging/most/aim-cdev/cdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/most/aim-cdev/cdev.c b/drivers/staging/most/aim-cdev/cdev.c
index 3a2dbf1..de4f76a 100644
--- a/drivers/staging/most/aim-cdev/cdev.c
+++ b/drivers/staging/most/aim-cdev/cdev.c
@@ -470,8 +470,8 @@ static int aim_probe(struct most_interface *iface, int channel_id,
 				     NULL,
 				     "%s", name);
 
-	retval = IS_ERR(c->dev);
-	if (retval) {
+	if (IS_ERR(c->dev)) {
+		retval = PTR_ERR(c->dev);
 		pr_info("failed to create new device node %s\n", name);
 		goto error_create_device;
 	}
-- 
1.9.1

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web