Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1328663 > unrolled thread

[PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count

Started byPaul Gortmaker <paul.gortmaker@windriver.com>
First post2016-02-08 01:10 +0100
Last post2016-02-08 17:00 +0100
Articles 3 — 2 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 01:10 +0100
    Re: [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count Arnd Bergmann <arnd@arndb.de> - 2016-02-08 11:00 +0100
      Re: [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count Paul Gortmaker <paul.gortmaker@windriver.com> - 2016-02-08 17:00 +0100

#1328663 — [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-02-08 01:10 +0100
Subject[PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count
Message-ID<qZHyW-5BD-17@gated-at.bofh.it>
We would like to modularize some of the PCI platform specific
support code to keep multi platform bzImage sizes in check.

However, in a couple of the files we see this:

$ git grep -l of_irq_count drivers/pci
drivers/pci/host/pci-keystone.c
drivers/pci/host/pcie-iproc-msi.c

So, we export of_irq_count so we can make headway with the
modularization goal.

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Grant Likely <grant.likely@linaro.org>
Cc: devicetree@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 drivers/of/irq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 7ee21ae305ae..0d714748a571 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -449,6 +449,7 @@ int of_irq_count(struct device_node *dev)
 
 	return nr;
 }
+EXPORT_SYMBOL(of_irq_count);
 
 /**
  * of_irq_to_resource_table - Fill in resource table with node's IRQ info
-- 
2.6.1

[toc] | [next] | [standalone]


#1328869

FromArnd Bergmann <arnd@arndb.de>
Date2016-02-08 11:00 +0100
Message-ID<qZQLU-3tN-15@gated-at.bofh.it>
In reply to#1328663
On Sunday 07 February 2016 19:00:41 Paul Gortmaker wrote:
> diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> index 7ee21ae305ae..0d714748a571 100644
> --- a/drivers/of/irq.c
> +++ b/drivers/of/irq.c
> @@ -449,6 +449,7 @@ int of_irq_count(struct device_node *dev)
>  
>         return nr;
>  }
> +EXPORT_SYMBOL(of_irq_count);
>  
>  /**
>   * of_irq_to_resource_table - Fill in resource table with node's IRQ info
> -- 
> 

I think the drivers should be changed to call platform_irq_count() instead.

	Arnd

[toc] | [prev] | [next] | [standalone]


#1329221

FromPaul Gortmaker <paul.gortmaker@windriver.com>
Date2016-02-08 17:00 +0100
Message-ID<qZWoi-7it-3@gated-at.bofh.it>
In reply to#1328869
[Re: [PATCH 2/5] drivers/of: add EXPORT_SYMBOL to of_irq_count] On 08/02/2016 (Mon 10:56) Arnd Bergmann wrote:

> On Sunday 07 February 2016 19:00:41 Paul Gortmaker wrote:
> > diff --git a/drivers/of/irq.c b/drivers/of/irq.c
> > index 7ee21ae305ae..0d714748a571 100644
> > --- a/drivers/of/irq.c
> > +++ b/drivers/of/irq.c
> > @@ -449,6 +449,7 @@ int of_irq_count(struct device_node *dev)
> >  
> >         return nr;
> >  }
> > +EXPORT_SYMBOL(of_irq_count);
> >  
> >  /**
> >   * of_irq_to_resource_table - Fill in resource table with node's IRQ info
> > -- 
> > 
> 
> I think the drivers should be changed to call platform_irq_count() instead.

I'll look into that and see if it works.

P.
--

> 
> 	Arnd

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web