Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1326629 > unrolled thread
| Started by | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| First post | 2016-02-04 11:40 +0100 |
| Last post | 2016-02-08 15:20 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-04 11:40 +0100
Re: [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up Adrian Hunter <adrian.hunter@intel.com> - 2016-02-08 15:20 +0100
| From | Ulf Hansson <ulf.hansson@linaro.org> |
|---|---|
| Date | 2016-02-04 11:40 +0100 |
| Subject | Re: [PATCH v4 00/13] mmc: use sdhci_pltfm_init for private allocation and clean up |
| Message-ID | <qYpur-7mq-55@gated-at.bofh.it> |
+ Adrian
On 26 January 2016 at 11:15, Jisheng Zhang <jszhang@marvell.com> wrote:
> These patches are to complete the TODOs in Commit 0e748234293f ("mmc:
> sdhci: Add size for caller in init+register"), I.E:
>
> - todo: migrate clients to using allocation this way
> - todo: remove priv variable once migration is complete
>
> Since v3:
> - based on v4.5-rc1
> - add Ludovic's ack for sdhci-of-at91 changes
> - fix use-after-free in some drivers: some host drivers still needs to
> access sdhci_pltfm_host->private after sdhci_pltfm_unregister(), but
> the private should be already freed by sdhci_pltfm_unregister.
> - add patch5 to fix one clk bug in sdhci_arasan_remove(). IMHO, It's
> better to add this patch to fixes rather than waiting for next merge
> window
>
> Since v2:
> - based on mmc next tree and remove all priv usage introduced in newly
> commits in this tree
> - don't break two lines if sdhci_pltfm_init() call could be put into
> one line. Thank Ludovic Desroches.
>
> Since v1:
> - add new patch03 to factorise sdhci_msm_pdata outisde of sdhci_msm_host.
> This is to fix drivers/mmc/host/sdhci-msm.c:440:32: warning: 'msm_host'
> is used uninitialized in this function [-Wuninitialized]
> - Add Arnd's Ack for all patches except patch3 which is new in v2
>
>
> Jisheng Zhang (13):
> mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation
> mmc: sdhci-esdhc-imx: use sdhci_pltfm_init for private allocation
> mmc: sdhci-msm: factorise sdhci_msm_pdata outisde of sdhci_msm_host
> mmc: sdhci-msm: use sdhci_pltfm_init for private allocation
> mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()
> mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation
> mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation
> mmc: sdhci-of-esdhc: use sdhci_pltfm_init for private allocation
> mmc: sdhci-pxav3: use sdhci_pltfm_init for private allocation
> mmc: sdhci-st: use sdhci_pltfm_init for private allocation
> mmc: sdhci-tegra: use sdhci_pltfm_init for private allocation
> mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv
> mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host
>
> drivers/mmc/host/sdhci-bcm2835.c | 14 +++----------
> drivers/mmc/host/sdhci-esdhc-imx.c | 38 ++++++++++++++++--------------------
> drivers/mmc/host/sdhci-msm.c | 25 +++++++++++-------------
> drivers/mmc/host/sdhci-of-arasan.c | 33 +++++++++++++++----------------
> drivers/mmc/host/sdhci-of-at91.c | 33 ++++++++++++++-----------------
> drivers/mmc/host/sdhci-of-esdhc.c | 19 +++++++++---------
> drivers/mmc/host/sdhci-pltfm.h | 1 -
> drivers/mmc/host/sdhci-pxav2.c | 1 -
> drivers/mmc/host/sdhci-pxav3.c | 20 ++++++++-----------
> drivers/mmc/host/sdhci-st.c | 40 +++++++++++++++++++-------------------
> drivers/mmc/host/sdhci-tegra.c | 21 +++++++-------------
> 11 files changed, 106 insertions(+), 139 deletions(-)
>
> --
> 2.7.0
>
To avoid confusions. I don't intend to pick up any further sdhci
patches, unless they are acked by Adrian Hunter.
Kind regards
Uffe
[toc] | [next] | [standalone]
| From | Adrian Hunter <adrian.hunter@intel.com> |
|---|---|
| Date | 2016-02-08 15:20 +0100 |
| Message-ID | <qZUPw-6rJ-3@gated-at.bofh.it> |
| In reply to | #1326629 |
On 04/02/16 12:38, Ulf Hansson wrote:
> + Adrian
>
> On 26 January 2016 at 11:15, Jisheng Zhang <jszhang@marvell.com> wrote:
>> These patches are to complete the TODOs in Commit 0e748234293f ("mmc:
>> sdhci: Add size for caller in init+register"), I.E:
>>
>> - todo: migrate clients to using allocation this way
>> - todo: remove priv variable once migration is complete
>>
>> Since v3:
>> - based on v4.5-rc1
>> - add Ludovic's ack for sdhci-of-at91 changes
>> - fix use-after-free in some drivers: some host drivers still needs to
>> access sdhci_pltfm_host->private after sdhci_pltfm_unregister(), but
>> the private should be already freed by sdhci_pltfm_unregister.
>> - add patch5 to fix one clk bug in sdhci_arasan_remove(). IMHO, It's
>> better to add this patch to fixes rather than waiting for next merge
>> window
>>
>> Since v2:
>> - based on mmc next tree and remove all priv usage introduced in newly
>> commits in this tree
>> - don't break two lines if sdhci_pltfm_init() call could be put into
>> one line. Thank Ludovic Desroches.
>>
>> Since v1:
>> - add new patch03 to factorise sdhci_msm_pdata outisde of sdhci_msm_host.
>> This is to fix drivers/mmc/host/sdhci-msm.c:440:32: warning: 'msm_host'
>> is used uninitialized in this function [-Wuninitialized]
>> - Add Arnd's Ack for all patches except patch3 which is new in v2
>>
>>
>> Jisheng Zhang (13):
>> mmc: sdhci-bcm2835: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-esdhc-imx: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-msm: factorise sdhci_msm_pdata outisde of sdhci_msm_host
>> mmc: sdhci-msm: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()
>> mmc: sdhci-of-arasan: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-of-esdhc: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-pxav3: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-st: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-tegra: use sdhci_pltfm_init for private allocation
>> mmc: sdhci-pxav2: remove unnecessary assignment of pltfm_host->priv
>> mmc: sdhci-pltfm: remove priv variable from sdhci_pltfm_host
>>
>> drivers/mmc/host/sdhci-bcm2835.c | 14 +++----------
>> drivers/mmc/host/sdhci-esdhc-imx.c | 38 ++++++++++++++++--------------------
>> drivers/mmc/host/sdhci-msm.c | 25 +++++++++++-------------
>> drivers/mmc/host/sdhci-of-arasan.c | 33 +++++++++++++++----------------
>> drivers/mmc/host/sdhci-of-at91.c | 33 ++++++++++++++-----------------
>> drivers/mmc/host/sdhci-of-esdhc.c | 19 +++++++++---------
>> drivers/mmc/host/sdhci-pltfm.h | 1 -
>> drivers/mmc/host/sdhci-pxav2.c | 1 -
>> drivers/mmc/host/sdhci-pxav3.c | 20 ++++++++-----------
>> drivers/mmc/host/sdhci-st.c | 40 +++++++++++++++++++-------------------
>> drivers/mmc/host/sdhci-tegra.c | 21 +++++++-------------
>> 11 files changed, 106 insertions(+), 139 deletions(-)
>>
>> --
>> 2.7.0
>>
>
> To avoid confusions. I don't intend to pick up any further sdhci
> patches, unless they are acked by Adrian Hunter.
The patches look OK, although patch 6 doesn't apply cleanly anymore.
Nevertheless:
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web