Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1328630 > unrolled thread

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] staging: coding style cleanups for  staging/most/mostcore driver Greg KH <gregkh@linuxfoundation.org> - 2016-02-07 23:20 +0100

#1328630 — Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

On Fri, Jan 29, 2016 at 11:33:20PM +0530, Bijosh Thykkoottathil wrote:
> Fixes following coding style issues reported by the check patch script.
>     - ERROR: Macros with complex values should be enclosed in parentheses
> 
>     Moving static storage class to the beginning of declaration fixes these
>     errors.

Well that's a horrid fix for this, as you aren't doing anything
different here.

Fix the tool if it is reporting things incorrectly, don't blindly change
code for no reason please.  checkpatch isn't always correct, as you have
found out.

thanks,

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web